r48930 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r48929‎ | r48930 | r48931 >
Date:20:22, 27 March 2009
Author:ialex
Status:ok (Comments)
Tags:
Comment:
* (bug 17163) Added MediaWiki:Talkpage which will be displayed when viewing talk pages

This will be very use on the French Wikipedia to display links to realted pages, e.g. deletion request without having to add a template on every talk page
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messageTypes.inc (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -211,6 211,7 @@
212212 'otherlanguages',
213213 'redirectedfrom',
214214 'redirectpagesub',
 215 'talkpageheader',
215216 'lastmodifiedat',
216217 'viewcount',
217218 'protectedpage',
Index: trunk/phase3/maintenance/language/messageTypes.inc
@@ -69,6 69,7 @@
7070 'accesskey-watch',
7171 'accesskey-upload',
7272 'addsection',
 73 'talkpageheader',
7374 'anonnotice',
7475 'autoblock_whitelist',
7576 'searchmenu-help',
Index: trunk/phase3/includes/Article.php
@@ -865,6 865,13 @@
866866 }
867867 }
868868
 869 # Allow a specific header on talk pages, like [[MediaWiki:Talkpagetext]]
 870 if( $this->mTitle->isTalkPage() ) {
 871 if ( wfMsgForContent( 'talkpageheader' ) != '-' ) {
 872 $wgOut->addWikiMsgArray( 'talkpageheader', array(), array( 'content' ) );
 873 }
 874 }
 875
869876 $outputDone = false;
870877 wfRunHooks( 'ArticleViewHeader', array( &$this, &$outputDone, &$pcache ) );
871878 if( $pcache && $wgOut->tryParserCache( $this ) ) {
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -692,6 692,7 @@
693693 'otherlanguages' => 'In other languages',
694694 'redirectedfrom' => '(Redirected from $1)',
695695 'redirectpagesub' => 'Redirect page',
 696 'talkpageheader' => '-',
696697 'lastmodifiedat' => 'This page was last modified on $1, at $2.', # $1 date, $2 time
697698 'viewcount' => 'This page has been accessed {{PLURAL:$1|once|$1 times}}.',
698699 'protectedpage' => 'Protected page',
Index: trunk/phase3/RELEASE-NOTES
@@ -151,6 151,8 @@
152152 * Add a class if 'missingsummary' is triggered to allow styling of the summary
153153 line
154154 * Add CSS defintion of the 'wikitable' class to shared.css
 155 * (bug 17163) Added MediaWiki:Talkpage which will be displayed when viewing talk
 156 pages
155157
156158 === Bug fixes in 1.15 ===
157159 * (bug 16968) Special:Upload no longer throws useless warnings.

Follow-up revisions

RevisionCommit summaryAuthorDate
r48933Per raymond, tweak for r48930: add "mw-talkpageheader" arround the newly adde...ialex20:45, 27 March 2009
r48990Fixes for r48930:...ialex11:04, 29 March 2009

Comments

#Comment by Simetrical (talk | contribs)   21:41, 27 March 2009

Should this be a content or interface message? It's not actually included in the content, right?

#Comment by IAlex (talk | contribs)   22:33, 27 March 2009

This is like "MediaWiki:Editnotice" messages, the point is that admins don't have to translate or copy it in different languages so that all users see it.

#Comment by Nikerabbit (talk | contribs)   07:35, 28 March 2009

After double checking the code, MediaWiki:foo/uicodedifferentfromcontent is called first, but MediaWiki:foo only last after everything else.

#Comment by UV (talk | contribs)   22:49, 28 March 2009

typo in RELEASE-NOTES: instead of "MediaWiki:Talkpage", it should read "MediaWiki:Talkpageheader"

Status & tagging log