lib/commonio.c | 12 12 0 - 0 !
lib/sgroupio.c | 2 1 1 - 0 !
lib/shadowio.c | 2 1 1 - 0 !
3 files changed, 14 insertions( ), 2 deletions(-)

 set group and mode for [g]shadow files

Set group 'shadow' and mode 0400.

Fixes: #166793

man/useradd.8.xml | 2 1 1 - 0 !
src/useradd.c | 4 2 2 - 0 !
2 files changed, 3 insertions( ), 3 deletions(-)

 keep using debian's adduser defaults

Bug: https://github.com/shadow-maint/shadow/issues/501
Bug-Debian: https://bugs.debian.org/1004710

man/Makefile.am | 2 2 0 - 0 !
man/fr/Makefile.am | 1 1 0 - 0 !
man/fr/man8/shadowconfig.8 | 26 26 0 - 0 !
man/ja/Makefile.am | 1 1 0 - 0 !
man/ja/man8/shadowconfig.8 | 25 25 0 - 0 !
man/pl/Makefile.am | 1 1 0 - 0 !
man/pl/man8/shadowconfig.8 | 27 27 0 - 0 !
man/shadowconfig.8 | 41 41 0 - 0 !
man/shadowconfig.8.xml | 52 52 0 - 0 !
9 files changed, 176 insertions( )

 document the shadowconfig utility

Status wrt upstream: The shadowconfig utility is debian specific.
Its man page also (but it used to be distributed)

man/useradd.8.xml | 6 6 0 - 0 !
man/userdel.8.xml | 6 6 0 - 0 !
2 files changed, 12 insertions( )

 recommend using adduser and deluser

Fixes: #406046

Status wrt upstream: Debian specific patch.

lib/chkname.c | 47 15 32 - 0 !
man/groupadd.8.xml | 6 6 0 - 0 !
man/useradd.8.xml | 8 8 0 - 0 !
3 files changed, 29 insertions( ), 32 deletions(-)

 relax usernames/groupnames checking

Allows any non-empty user/grounames that don't contain ':', ',', '\\' or
'\n' characters and don't start with '-', ' ', or '~'. This patch is
more restrictive than original Karl's version. closes: #264879 Also
closes: #377844

Comments from Karl Ramm (shadow 1:4.0.3-9, 20 Aug 2003 02:06:50 -0400):

I can't come up with a good justification as to why characters other
than ':'s and '\0's should be disallowed in group and usernames (other
than '-' as the leading character).  Thus, the maintenance tools don't
anymore.  closes: #79682, #166798, #171179

Status wrt upstream: Debian specific. Not to be used upstream

tests/tests/common/config.sh | 16 9 7 - 0 !
tests/tests/libsubid/04_nss/Makefile | 13 8 5 - 0 !
tests/tests/libsubid/04_nss/subidnss.test | 2 1 1 - 0 !
tests/tests/libsubid/04_nss/test_range | 12 6 6 - 0 !
4 files changed, 24 insertions( ), 19 deletions(-)

 tests/: support run_some from exported tarball

common/config.sh currently tries to find the top directory by looking
for .git.  There are also many places under tests/ where we use
hard-coded ../../.. to find things like ${TOP_DIR}/lib.

We don't actually ship the tests with 'make dist'.  So we will
be exporting tests/ as a separate tarball.  In particular, I want
to then import this in the debian package.  However, there it will
be under shadow.git/debian/tests, not shadow.git/tests.

To support this, accept the environment variable BUILD_BASE_DIR,
which should point to shadow.git.

An alternative would be to move the tests to their own git
tree.  However, keeping tests in separate git tree tends to
lead to repos getting out of sync.  And we'd still need to accept
something like BUILD_BASE_DIR.

Note there are a lot of tests under run-all, which I'm not converting
as they currently are not being run in CI, so I'm more likely to
break something.

Changelog:
  2024 05 26: Incorporate feedback from alejandro-colomar

Link: <https://salsa.debian.org/debian/shadow/-/merge_requests/21>
Link: <https://salsa.debian.org/debian/shadow/-/merge_requests/22>
Cc: Chris Hofstaedtler <[email protected]>
Signed-off-by: Serge Hallyn <[email protected]>
Signed-off-by: Alejandro Colomar <[email protected]>

tests/tests/run_some | 68 0 68 - 0 !
1 file changed, 68 deletions(-)

 upstream testsuite: disable su tests

Debian uses su from util-linux, pointless/impossible to test shadow's su
here.

tests/tests/libsubid/04_nss/Makefile | 4 2 2 - 0 !
1 file changed, 2 insertions( ), 2 deletions(-)

 tests/libsubid/04_nss: fix setting basedir

etc/login.defs | 375 47 328 - 0 !
1 file changed, 47 insertions( ), 328 deletions(-)

 adapt login.defs for debian

Remove settings only applicable to shadow's su, which we do not use.
Remove settings only applicable without PAM support enabled.
Remove obscure commented-out settings.
Remove explanation about write(1), which Debian does not ship anymore.

lib/chkname.c | 6 6 0 - 0 !
1 file changed, 6 insertions( )

 define login_name_max on hurd

man/Makefile.am | 19 0 19 - 0 !
man/cs/Makefile.am | 5 0 5 - 0 !
man/da/Makefile.am | 4 0 4 - 0 !
man/de/Makefile.am | 9 0 9 - 0 !
man/fr/Makefile.am | 10 0 10 - 0 !
man/it/Makefile.am | 10 0 10 - 0 !
man/ja/Makefile.am | 8 0 8 - 0 !
man/ko/Makefile.am | 2 0 2 - 0 !
man/pl/Makefile.am | 5 0 5 - 0 !
man/ru/Makefile.am | 8 0 8 - 0 !
man/sv/Makefile.am | 7 0 7 - 0 !
man/tr/Makefile.am | 2 0 2 - 0 !
man/uk/Makefile.am | 10 0 10 - 0 !
man/zh_CN/Makefile.am | 9 0 9 - 0 !
man/zh_TW/Makefile.am | 2 0 2 - 0 !
src/Makefile.am | 7 3 4 - 0 !
16 files changed, 3 insertions( ), 114 deletions(-)

 stop building programs we do not install

lib/user_busy.c | 1 1 0 - 0 !
1 file changed, 1 insertion( )

 [patch] lib/user_busy.c: include <utmpx.h>

Since:
- utmpx APIs are used in non-Linux code blocks
- <utmpx.h> is already unconditionally included in Linux parts in other
  files
then unconditionally include it in this file as well.

Signed-off-by: Pino Toscano <[email protected]>