Package: chkrootkit / 0.57-2

Metadata

Package Version Patches format
chkrootkit 0.57-2 3.0 (quilt)

Patch series

view the series file
Patch File delta Description
01_nostrip.patch | (download)

Makefile | 8 0 8 - 0 !
1 file changed, 8 deletions(-)

 remove explicit use of 'strip' from the upstream makefile

 debhelper will automatically strip everything when we build the package.
 This is a Debian-specific modification - upstream unlikely to want this.

Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=436626
02_workingdir.patch | (download)

chkrootkit | 2 2 0 - 0 !
1 file changed, 2 insertions( )

 chkrootkit: cd /usr/lib/chkrootkit.

 Upstream chkrootkit is designed to be run from it's build directory, so calls all its executables with a "./" prefix.
 On Debian, executables are placed in /usr/lib/chkrootkit.
 .
 This could be upstreamed but presumably upstream would prefer the existing behaviour.
 .
 This patch is from 2017 or earlier.
Last-Updated: 2021-10-10
03_linedup_reports.patch | (download)

chkrootkit | 33 29 4 - 0 !
1 file changed, 29 insertions( ), 4 deletions(-)

 modify chkrootkit's printn to use printf if available.

 This improves readability of the output (if no -q given) by right-aligning
 the "nothing found" results.
 .
 A previous comment noted that upstream was not interested in this patch as
 printf is not portable. However, this patch should work even if printf is
 not present.

Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=343284
Last-updated: 2021-10-10
04_backslashes.patch | (download)

chkrootkit | 4 2 2 - 0 !
1 file changed, 2 insertions( ), 2 deletions(-)

 remove unnecessary backslashes from two chkrootkit messages

 This is upstreamable.
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=498063
Last-Updated: 2021-10-10
05_disable_enye.patch | (download)

chkproc.c | 2 2 0 - 0 !
1 file changed, 2 insertions( )

 chkproc: do not send signal 58 to pid 12345

 This disables the test for Enye LKM.

 As the bug report notes, sending a non-standard signal to test whether a process might be a
 trojan risks killing unrelated software and should not be done.
 .
 This is upstreamable and was first forwarded upstream in April 2008

06_quiet.patch | (download)

chklastlog.c | 14 12 2 - 0 !
chkrootkit | 218 128 90 - 0 !
2 files changed, 140 insertions( ), 92 deletions(-)

 make chklastlog support -q and make chk_* functions consistent

 The chk_* functions should not produce output unless in EXPERT mode,
 but should return INFECTED, NOT_FOUND etc and the main loop should produce output
 .
 This patch only looks at the chk_* functions (where * is in TROJANS - the functions
 names after the content of TOOLS are expected to produce output themselves, although
 this is not conistent (later debian patches address this)
 .
 This ensures even more output is hidden if -q is passed to chkrootkit
 .
 This is upstreamable.

Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=142422
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=190978
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=229869
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=306263
Last-Updated: 2023-02-19
07_promisc.patch | (download)

ifpromisc.c | 54 26 28 - 0 !
1 file changed, 26 insertions( ), 28 deletions(-)

 make ifpromisc output pid as well as name

 Makes a number of internal changes to ifpromisc
 .
 This introduces new behaviour where
 * if a 'packet sniffer' is detected, its pid is output as well as the name
 * instead of PF_PACKET the output is "PACKET_SNIFFER"
 .
 This is upstreamable.
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=333068
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=214990
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=202198
Last-Updated: 2021-10-10
08_unidentified.patch | (download)

chkproc.c | 2 1 1 - 0 !
chkrootkit | 52 28 24 - 0 !
2 files changed, 29 insertions( ), 25 deletions(-)

 collection of other changes to upstream source made by debian

 All changes appear upstreamable.
 This dates from 2017 or earlier.

Last-Updated: 2021-10-10
09_excludes.patch | (download)

README | 27 27 0 - 0 !
chkrootkit | 124 67 57 - 0 !
2 files changed, 94 insertions( ), 57 deletions(-)

 adds -e option to chkrootkit and function lookfor_rootkit

10_fixwarnings.patch | (download)

chklastlog.c | 2 1 1 - 0 !
chkwtmp.c | 1 1 0 - 0 !
2 files changed, 2 insertions( ), 1 deletion(-)

 some little fixes to silence compiler.

 This is from 2017 or earlier.
Last-Updated: 2023-02-18
11_logpath.patch | (download)

README.chklastlog | 4 2 2 - 0 !
README.chkwtmp | 2 1 1 - 0 !
check_wtmpx.c | 4 2 2 - 0 !
chklastlog.c | 4 2 2 - 0 !
chkutmp.c | 2 1 1 - 0 !
chkwtmp.c | 2 1 1 - 0 !
6 files changed, 9 insertions( ), 9 deletions(-)

 read logs from /var/log instead of /var/adm

 Potentially upstreamable
 (may also be non-portable)
 Dates from 2017 or earlier.

Last-Updated: 2021-10-10
12_procpsv3.patch | (download)

chkproc.c | 2 1 1 - 0 !
1 file changed, 1 insertion( ), 1 deletion(-)

 chkproc: default to procps version 3.

 Upstreamable.
 Dates from 2017 or earlier
Last-Updated: 2021-10-10
13_exitcode.patch | (download)

chkrootkit | 2 1 1 - 0 !
1 file changed, 1 insertion( ), 1 deletion(-)

 make chkrootkit explicitly exit 0

 Otherwise the exit code is that of the last test that ran.
 This is particularly useful when calling from a script with set -e (such as from cron)
 .
 Upstreamable

Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=541060
Last-Updated: 2021-10-10
14_chkutmp.patch | (download)

chkutmp.c | 12 7 5 - 0 !
1 file changed, 7 insertions( ), 5 deletions(-)

 chkutmp: fixe chkutmp parser

 Upstreamable.
 Dates from 2017 or earlier

Last-Updated: 2021-10-10
15_kfreebsd.patch | (download)

ifpromisc.c | 1 1 0 - 0 !
1 file changed, 1 insertion( )

 ifpromisc: add missing include <stdint.h>

 Upstreamable
 Dates from 2017 or earlier

Last-Updated: 2021-10-10
16_php.patch | (download)

chkrootkit | 30 17 13 - 0 !
1 file changed, 17 insertions( ), 13 deletions(-)

 fix the check for suspect php files

 Before this patch,
 1. Any non-text file contents confuse the results of the grep if they match.
 2. Not file names are printed, but file contents.
 .
 This patch fixes '/usr/bin/find: head terminated by signal 13' errors and
 prints affected file names instead of their content.
 .
 This dates from 2017 or earlier, but was refreshed in 2013

Last-Updated: 2023-02-21
17_Suckitfalse.patch | (download)

chkrootkit | 9 8 1 - 0 !
1 file changed, 8 insertions( ), 1 deletion(-)

 chkroootkit: false positive for suckit under systemd or upstart

 Upstreamable.
  
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=740898
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=901557

Last-Updated: 2021-10-10
18_fix stack smash.patch | (download)

chkutmp.c | 2 1 1 - 0 !
1 file changed, 1 insertion( ), 1 deletion(-)

 chkutmp: change ut_linesize to ut_pidsize

 Dates from 2017 or earlier
 The previous description stated only 'fix good old stack smash'
 .
 Upstreamable
 
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=457828
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=457828

Last-Updated: 2021-10-10
19_openssh.patch | (download)

chkrootkit | 2 2 0 - 0 !
1 file changed, 2 insertions( )

 chkrootkit: fix windigo test

 Dates from 2017 or earlier
 Upstreamable

Last-Updated: 2021-10-10
20_Proper flags.patch | (download)

Makefile | 18 10 8 - 0 !
1 file changed, 10 insertions( ), 8 deletions(-)

 honor preprocesor and linker flags added at compile time by
 debhelper.

 Thanks to Lukas Schwaighofer for suggesting some improvements.
 Dates from 2017 or earlier
 .
 Upstreamable
 .
 Depends on patch 02
 .

Last-Updated: 2021-10-10
21_fix_loc_function.patch | (download)

chkrootkit | 2 1 1 - 0 !
1 file changed, 1 insertion( ), 1 deletion(-)

 output the results of the loc() function in test for loc rootkit

 Upstreamable

Last-Updated: 2021-10-10
22_fix_Makefile_target.patch | (download)

Makefile | 4 1 3 - 0 !
1 file changed, 1 insertion( ), 3 deletions(-)

 makefile: make "all" target depend on "sense"

 This removes the use of @exec and the message "stopping make sense".
 .
 Thanks to Lukas Schwaighofer.
 .
 Upstreamable but presumably they will prefer the original approach

Last-Updated: 2021-10-10
24_ser2net_exception_in_scalper.patch | (download)

chkrootkit | 4 3 1 - 0 !
1 file changed, 3 insertions( ), 1 deletion(-)

 add exception for ser2net in scalper()

 Upstreamable

Bug-Debian: https://bugs.debian.org/564147
Last-Updated: 2021-10-10
25_fix nfs legacy sniffers.patch | (download)

chkrootkit | 31 20 11 - 0 !
1 file changed, 20 insertions( ), 11 deletions(-)

 chkrootkit: add -s option to filter ifpromisc output

 Also do not search nfs filesystems
 .
 This patch does two things:
 1) exclude nfs filesystems from calls to find
 2) new option '-s' fot chkrootkit to allow excluding lines from ifpromisc output
 .
 This patch also (attempts to) fix #548582 by not outputting an empty list if -q is give.
 .
 HOWEVER, it does not seem to be correct if -q is not given
 .
 Needs to come after patch #09

Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=580491
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=548582

Last-Updated: 2021-10-10
25a_fix_patch_25.patch | (download)

chkrootkit | 43 22 21 - 0 !
1 file changed, 22 insertions( ), 21 deletions(-)

 chkrootkit: fix test 'suspicious files and directories' without -q

 (This should be merged with patch 25, and depends on that patch)
 Upstreamable (not forwarded)

26_improve info help display.patch | (download)

chkrootkit | 12 6 6 - 0 !
1 file changed, 6 insertions( ), 6 deletions(-)

 chkrootkit: improve information displayed with chkrootkit -h

 Needs to come after patch #25
 Upstreamable apart from the reference to a Debian-specific documentation file

Bug-Debian: https://bugs.debian.org/586897

Last-Updated: 2021-10-24
27_fix race condition ps proc.patch | (download)

chkproc.c | 325 190 135 - 0 !
1 file changed, 190 insertions( ), 135 deletions(-)

 chkproc: patch 27: avoid race condition

The previous description stated that this intends to fix a ""a really bad race condition in it where it compares ps
 and /proc." and " This patch fixes this by double checking to ensure the process hasn't exited."
 .
(Refreshed 2023-03-11 to correct an issue where some unrelated lines were being removed by mistake
 having looked at the BTS, it seems these were introduced when the patch was rebased for 0.48
 debian then corrected some of these in 2022 via separate patches (55,55a), and these have been
 squashed into patch 27 to simplify the patch queue.
 ... there is no change to the functionality that patch 27 introduces)

This depends on patches
- 12 (which sets pv to 3 by default - chkrootkit always sets this explicitly)
- 8
- 5

Bug-Debian: https://bugs.debian.org/538632
Last-Updated: 2023-03-11
28_chkdirs fix memory leak.patch | (download)

chkdirs.c | 1 1 0 - 0 !
1 file changed, 1 insertion( )

 chkdirs: fix memory leak

    chkdirs.c:126:2: error: Memory leak: curpath [memleak]
     return(-1);
     ^

Found by Cppcheck

Last-Updated: 2021-10-10
29_chkdirs fix dead code.patch | (download)

chkdirs.c | 2 1 1 - 0 !
1 file changed, 1 insertion( ), 1 deletion(-)

 chkdirs: fix dead code

In line 72 buffer is forced to be non-NULL, because it got dereferenced in line 71.

    chkdirs.c:71:10: warning: Either the condition 'if(buffer)' is redundant or there is possible null pointer dereference: buffer. [nullPointerRedundantCheck]
      if (!(*buffer) || (sizeof(*buffer) < pathname_len)) {
             ^
    chkdirs.c:72:8: note: Assuming that condition 'if(buffer)' is not redundant
        if (buffer) free((void *)*buffer);
           ^
    chkdirs.c:71:10: note: Null pointer dereference
      if (!(*buffer) || (sizeof(*buffer) < pathname_len)) {
             ^

Found by Cppcheck

Last-Updated: 2021-10-10
30_chklastlog fix out of bounds access.patch | (download)

chklastlog.c | 2 1 1 - 0 !
1 file changed, 1 insertion( ), 1 deletion(-)

 chklastlog: fix out of bounds access

 We dereference userid at *uid, so *uid must be strictly smaller than userid' size.

    chklastlog.c:184:14: warning: Either the condition '*uid>99999' is redundant or the array 'userid[99999]' is accessed at index 99999, which is out of bounds. [arrayIndexOutOfBoundsCond]
      if (!userid[*uid])
                 ^
    chklastlog.c:178:26: note: Assuming that condition '*uid>99999' is not redundant
                    if (*uid > MAX_ID)
                         ^
    chklastlog.c:184:14: note: Array index out of bounds
      if (!userid[*uid])
                 ^

Found by Cppcheck

Last-Updated: 2021-10-10
31_ifpromisc always null terminate interface names.patch | (download)

ifpromisc.c | 5 3 2 - 0 !
1 file changed, 3 insertions( ), 2 deletions(-)

 ifpromisc: always null-terminate interface names
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

In file included from /usr/include/string.h:495,
                 from ifpromisc.c:54:
In function strncpy,
    inlined from if_fetch at ifpromisc.c:311:3,
    inlined from if_print at ifpromisc.c:347:11:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: __builtin_strncpy specified bound 16 equals destination size [-Wstringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function strncpy,
    inlined from if_fetch at ifpromisc.c:313:3,
    inlined from if_print at ifpromisc.c:347:11:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: warning: __builtin_strncpy specified bound 16 equals destination size [-Wstringop-truncation]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Last-Updated: 2021-10-10
32_chkdirs use strdup to avoid stringop overflow warning.patch | (download)

chkdirs.c | 9 4 5 - 0 !
1 file changed, 4 insertions( ), 5 deletions(-)

 chkdirs: use strdup to avoid stringop-overflow warning
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

In file included from /usr/include/string.h:495,
                 from chkdirs.c:42:
In function strncpy,
    inlined from check_dir at chkdirs.c:136:5:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: __builtin_strncpy specified bound depends on the length of the source argument [-Werror=stringop-overflow=]
  106 |   return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chkdirs.c: In function check_dir:
chkdirs.c:111:25: note: length computed here
  111 |   if (!path || !(plen = strlen(path))) {
      |                         ^~~~~~~~~~~~

Last-Updated: 2021-10-10
33_chklastlog silence array bounds warning.patch | (download)

chklastlog.c | 4 2 2 - 0 !
1 file changed, 2 insertions( ), 2 deletions(-)

 chklastlog: silence array-bounds warning
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

In file included from /usr/include/string.h:495,
                 from chklastlog.c:45:
In function memcpy,
    inlined from main at chklastlog.c:114:9:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:34:10: error: __builtin_memcpy forming offset [14, 126] is out of the bounds [0, 14] [-Werror=array-bounds]
   34 |   return __builtin___memcpy_chk (__dest, __src, __len, __bos0 (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function memcpy,
    inlined from main at chklastlog.c:115:9:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:34:10: error: __builtin_memcpy forming offset [17, 126] is out of the bounds [0, 17] [-Werror=array-bounds]
   34 |   return __builtin___memcpy_chk (__dest, __src, __len, __bos0 (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Last-Updated: 2021-10-10
34_chkwtmp silence array bounds warning.patch | (download)

chkwtmp.c | 2 1 1 - 0 !
1 file changed, 1 insertion( ), 1 deletion(-)

 chkwtmp: silence array-bounds warning
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

In file included from /usr/include/string.h:495,
                 from chkwtmp.c:28:
In function memcpy,
    inlined from main at chkwtmp.c:74:8:
/usr/include/x86_64-linux-gnu/bits/string_fortified.h:34:10: error: __builtin_memcpy forming offset [14, 126] is out of the bounds [0, 14] [-Werror=array-bounds]
   34 |   return __builtin___memcpy_chk (__dest, __src, __len, __bos0 (__dest));
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Last-Updated: 2021-10-10
35_ifpromisc solve unused result warnings.patch | (download)

ifpromisc.c | 8 6 2 - 0 !
1 file changed, 6 insertions( ), 2 deletions(-)

 ifpromisc: solve unused result warnings
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

ifpromisc.c: In function read_proc_net_packet:
ifpromisc.c:112:5: error: ignoring return value of fgets declared with attribute warn_unused_result [-Werror=unused-result]
  112 |     fgets(buf, 80, proc);
      |     ^~~~~~~~~~~~~~~~~~~~
ifpromisc.c: In function walk_process:
ifpromisc.c:211:13: error: ignoring return value of readlink declared with attribute warn_unused_result [-Werror=unused-result]
  211 |             readlink(path, link, sizeof(link) - 1);
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Last-Updated: 2021-10-10
36_chkproc silence unused result warnings.patch | (download)

chkproc.c | 4 2 2 - 0 !
1 file changed, 2 insertions( ), 2 deletions(-)

 chkproc: silence unused result warnings
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

chkproc.c: In function readline:
chkproc.c:124:5: error: ignoring return value of fgets declared with attribute warn_unused_result [-Werror=unused-result]
  124 |     fgets(buf, MAX_BUF, stream);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
chkproc.c:127:7: error: ignoring return value of fgets declared with attribute warn_unused_result [-Werror=unused-result]
  127 |       fgets(buf, MAX_BUF, stream);
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Last-Updated: 2021-10-10
37_chkutmp silence unused result warnings.patch | (download)

chkutmp.c | 4 2 2 - 0 !
1 file changed, 2 insertions( ), 2 deletions(-)

 chkutmp: silence unused result warnings
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

chkutmp.c: In function fetchps:
chkutmp.c:90:2: error: ignoring return value of fgets declared with attribute warn_unused_result [-Werror=unused-result]
   90 |  fgets(line, MAXREAD, ps_fp); /* skip header */
      |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~
chkutmp.c:124:20: error: ignoring return value of fgets declared with attribute warn_unused_result [-Werror=unused-result]
  124 |                    fgets(line, MAXREAD, ps_fp);
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~

Last-Updated: 2021-10-10
38_chklastlog resolve signed comparison.patch | (download)

chklastlog.c | 4 2 2 - 0 !
1 file changed, 2 insertions( ), 2 deletions(-)

 chklastlog: resolve signed comparison
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

chklastlog.c: In function main:
39_chkproc resolve signed comparison.patch | (download)

chkproc.c | 44 29 15 - 0 !
1 file changed, 29 insertions( ), 15 deletions(-)

 chkproc: resolve signed comparison
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

chkproc.c: In function readline:
40_strings resolve signed comparison.patch | (download)

strings.c | 2 1 1 - 0 !
1 file changed, 1 insertion( ), 1 deletion(-)

 strings: resolve signed comparison
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

strings.c: In function strings:
41_chkutmp silence unused parameter warnings.patch | (download)

chkutmp.c | 2 1 1 - 0 !
1 file changed, 1 insertion( ), 1 deletion(-)

 chkutmp: silence unused parameter warnings
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

chkutmp.c: In function main:
chkutmp.c:180:14: error: unused parameter argc [-Werror=unused-parameter]
  180 | int main(int argc, char *argv[])
      |          ~~~~^~~~
chkutmp.c:180:26: error: unused parameter argv [-Werror=unused-parameter]
  180 | int main(int argc, char *argv[])
      |                    ~~~~~~^~~~~~

Last-Updated: 2021-10-10
42_chkdirs annotate usage with noreturn.patch | (download)

chkdirs.c | 4 3 1 - 0 !
1 file changed, 3 insertions( ), 1 deletion(-)

 chkdirs: annotate usage with noreturn
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

chkdirs.c: In function usage:
chkdirs.c:56:6: error: function might be candidate for attribute noreturn [-Werror=suggest-attribute=noreturn]
   56 | void usage ()
      |      ^~~~~

Last-Updated: 2021-10-10
43_chklastlog remove unused and shadowing variable.patch | (download)

chklastlog.c | 1 0 1 - 0 !
1 file changed, 1 deletion(-)

 chklastlog: remove unused and shadowing variable
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

chklastlog.c: In function main:
chklastlog.c:109:10: error: declaration of uid shadows a global declaration [-Werror=shadow]
  109 |  uid_t  *uid;
      |          ^~~
chklastlog.c:79:8: note: shadowed declaration is here
   79 | uid_t *uid;
      |        ^~~
chklastlog.c: In function getslot:
chklastlog.c:295:48: error: declaration of uid shadows a global declaration [-Werror=shadow]
  295 | int getslot(struct s_localpwd *localpwd, uid_t uid)
      |                                          ~~~~~~^~~
chklastlog.c:79:8: note: shadowed declaration is here
   79 | uid_t *uid;
      |        ^~~

Last-Updated: 2021-10-10
44_ifpromisc do not discard const qualifier.patch | (download)

ifpromisc.c | 4 2 2 - 0 !
1 file changed, 2 insertions( ), 2 deletions(-)

 ifpromisc: do not discard const qualifier
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

ifpromisc.c:69:17: error: initialization discards const qualifier from pointer target type [-Werror=discarded-qualifiers]
   69 | char *Release = "chkrootkit package",
      |                 ^~~~~~~~~~~~~~~~~~~~
ifpromisc.c:70:17: error: initialization discards const qualifier from pointer target type [-Werror=discarded-qualifiers]
   70 |      *Version = "@(#) ifpromisc 0.9 (2007/06/15)";
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Last-Updated: 2021-10-10
45_chkproc do not discard const qualifier.patch | (download)

chkproc.c | 4 2 2 - 0 !
1 file changed, 2 insertions( ), 2 deletions(-)

 chkproc: do not discard const qualifier
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

chkproc.c:92:6: error: initialization discards const qualifier from pointer target type [-Werror=discarded-qualifiers]
   92 |      "ps -edf",
      |      ^~~~~~~~~
chkproc.c:93:6: error: initialization discards const qualifier from pointer target type [-Werror=discarded-qualifiers]
   93 |      "ps auxw",
      |      ^~~~~~~~~
chkproc.c:94:6: error: initialization discards const qualifier from pointer target type [-Werror=discarded-qualifiers]
   94 |      "ps mauxw 2>&1 ",
      |      ^~~~~~~~~~~~~~~~
chkproc.c:95:13: error: initialization discards const qualifier from pointer target type [-Werror=discarded-qualifiers]
   95 |             "ps auxw -T|tr -s ' '|cut -d' ' -f2-",
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Last-Updated: 2021-10-10
46_chkutmp do not discard const qualifier.patch | (download)

chkutmp.c | 2 1 1 - 0 !
1 file changed, 1 insertion( ), 1 deletion(-)

 chkutmp: do not discard const qualifier
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

chkutmp.c:73:5: error: initialization discards const qualifier from pointer target type [-Werror=discarded-qualifiers]
   73 |     "ps -ef -o \"tty,pid,ruser,args\"", /* solaris */
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
chkutmp.c:74:5: error: initialization discards const qualifier from pointer target type [-Werror=discarded-qualifiers]
   74 |     "ps axk \"tty,ruser,args\" -o \"tty,pid,ruser,args\"" /* linux */
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Last-Updated: 2021-10-10
47_chklastlog remove dead assignment.patch | (download)

chklastlog.c | 2 1 1 - 0 !
1 file changed, 1 insertion( ), 1 deletion(-)

 chklastlog: remove dead assignment

chklastlog.c:249:12: warning: Although the value stored to 'pwdent' is used in the enclosing expression, the value is never actually read from 'pwdent'
   while ((pwdent = getpwent())) {
           ^        ~~~~~~~~~~
1 warning generated.

Last-Updated: 2021-10-10
48_chkdirs free memory on failure.patch | (download)

chkdirs.c | 8 6 2 - 0 !
1 file changed, 6 insertions( ), 2 deletions(-)

 chkdirs: free memory on failure

chkdirs.c:182:7: warning: Potential leak of memory pointed to by 'dl'
      fprintf(stderr, "lstat(%s/%s): %s\n",
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/x86_64-linux-gnu/bits/stdio2.h:113:3: note: expanded from macro 'fprintf'
  __fprintf_chk (stream, __USE_FORTIFY_LEVEL - 1, __VA_ARGS__)
  ^~~~~~~~~~~~~

Last-Updated: 2021-10-10
49_chkdirs fix return logic.patch | (download)

chkdirs.c | 6 4 2 - 0 !
1 file changed, 4 insertions( ), 2 deletions(-)

 chkdirs: fix return logic

If called with multiple arguments, do fail if any directory fails,
not only the last one.

Last-Updated: 2021-10-10
50_strings drop dead assignment.patch | (download)

strings.c | 1 0 1 - 0 !
1 file changed, 1 deletion(-)

 strings: drop dead assignment

strings.c:94:5: warning: Value stored to 'printmeindex' is never read
    printmeindex = 0;
    ^              ~
1 warning generated.

Last-Updated: 2021-10-10
51_chkdirs resolve signed comparison.patch | (download)

chkdirs.c | 2 1 1 - 0 !
1 file changed, 1 insertion( ), 1 deletion(-)

 chkdirs: resolve signed comparison
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

chkdirs.c: In function make_pathname:
52_chkdirs fix spelling error and whitespace.patch | (download)

chkdirs.c | 12 6 6 - 0 !
1 file changed, 6 insertions( ), 6 deletions(-)

 chkdirs: fix spelling error
54_chkrootkit Remove trailing space in windigo not found message.patch | (download)

chkrootkit | 4 2 2 - 0 !
1 file changed, 2 insertions( ), 2 deletions(-)

 remove trailing space from output of ssh test
56_chkrootkit Fix logic so that sshd test runs.patch | (download)

chkrootkit | 2 1 1 - 0 !
1 file changed, 1 insertion( ), 1 deletion(-)

 chkrootkit: fix logic so that sshd test runs
57_chutmp improve message if processes without tty are found.patch | (download)

chkutmp.c | 27 12 15 - 0 !
1 file changed, 12 insertions( ), 15 deletions(-)

 chutmp: improve message if processes without tty are found
58_chkrootkit improve output.patch | (download)

chkrootkit | 19 14 5 - 0 !
1 file changed, 14 insertions( ), 5 deletions(-)

 chkrootkit: improve output
59_chkrootkit Remove duplicate entries from check of suspicious files.patch | (download)

chkrootkit | 15 4 11 - 0 !
1 file changed, 4 insertions( ), 11 deletions(-)

 chkrootkit: remove duplicate entries from check of suspicious files
60_chkrootkit Improve output of sniffer and make rexedcs give some output if infected.patch | (download)

chkrootkit | 13 10 3 - 0 !
1 file changed, 10 insertions( ), 3 deletions(-)

 chkrootkit: improve output of sniffer and rexedcs tests
61_chkrootkit Prevent hanging in an lxc container.patch | (download)

chkrootkit | 5 4 1 - 0 !
1 file changed, 4 insertions( ), 1 deletion(-)

 chkrootkit: prevent hanging in an lxc container
62_chkrootkit Prevent warnings when running in an lxc container.patch | (download)

chkrootkit | 2 1 1 - 0 !
1 file changed, 1 insertion( ), 1 deletion(-)

 chkrootkit: prevent warnings when running in lxc