Page MenuHomePhabricator

Fail in a more comprehensible way when a WorkingCopy lease omits or mangles "repositories.map"
ClosedPublic

Authored by epriestley on May 3 2022, 6:36 PM.
Tags
None
Referenced Files
F14738982: D21796.id51965.diff
Sun, Jan 19, 5:45 PM
Unknown Object (File)
Fri, Jan 17, 11:48 PM
Unknown Object (File)
Fri, Jan 17, 4:08 PM
Unknown Object (File)
Mon, Jan 13, 5:35 PM
Unknown Object (File)
Thu, Jan 2, 3:59 PM
Unknown Object (File)
Wed, Dec 25, 4:31 AM
Unknown Object (File)
Wed, Dec 25, 4:31 AM
Unknown Object (File)
Wed, Dec 25, 4:31 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T13676. When the required "repositories.map" attribute is omitted, bin/drydock lease currently fatals in an unhelpful way when trying to lease a working copy.

Test Plan

Ran bin/drydock lease --type working-copy with no attributes, after following steps in T13676.

<Allocation Failed> One or more blueprints promised a new resource, but failed when allocating: [PhutilAggregateException] All blueprints failed to allocate a suitable new resource when trying to allocate lease ("PHID-DRYL-orbtwtlinksm3xqpyhmw").
    - Exception: Working copy lease is missing required attribute "repositories.map".
      
      Attribute "repositories.map" should be a map of repository specifications.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable