Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[25.0] save: Remove platform from config descriptor #47695

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

cpuguy83
Copy link
Member

@cpuguy83 cpuguy83 commented Apr 8, 2024

Cherry-pick of #47661


This was brought up by bmitch that its not expected to have a platform object in the config descriptor.
Also checked with tianon who agreed, its not wrong but is unexpected and doesn"t necessarily make sense to have it there.

Also, while technically incorrect, ECR is throwing an error when it sees this.

- remove erroneous `platform` from image `config` OCI descriptor in `docker save` output

(cherry picked from commit 9160b9f)

This was brought up by bmitch that its not expected to have a platform
object in the config descriptor.
Also checked with tianon who agreed, its not _wrong_ but is unexpected
and doesn"t neccessarily make sense to have it there.

Also, while technically incorrect, ECR is throwing an error when it sees
this.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
(cherry picked from commit 9160b9f)
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit f42f65b into moby:25.0 Apr 9, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants