VisualEditorUmbrella
ActivePublic
Watch Project

Members (28)

Korra_II_Baskerville (Korra II Baskerville)
User
EAkinloose (Esther)
User
Snowie (snxwie)
Animal
ppelberg (Peter Pelberg)
Product Manager, Editing
Kaingeo (Kainourgiakis Giorgos)
User
matmarex (Bartosz Dziewoński)
Software Engineer
Mvolz (Marielle Volz)
User
Juanmi_1041 (Juan Manuel)
User
Zppix (Devin)
Volunteer Developer & Volunteer Support on IRC & MW
Fuzheado (Fuzheado)
en.wp administrator
View All

Watchers (20)

Egiorgis
User
Catie99 (Heather Eller)
User
Eragon_Shadeslayer
User
VPuffetMichel (Val)
User
ycrepeau (Yanik Crépeau)
User
Mohammadmalek554 (MoonEclipse)
User
OhKayeSierra (Sierra)
User
keithbrianpadilla (Keith Brian Tomo)
User
Revansx (Rich)
User
WikimeSteve (Steve Hotchkiss)
User
View All

Details

Source Repo: https://gerrit.wikimedia.org/g/mediawiki/extensions/VisualEditor

Description

VisualEditor is a project to create a reliable, full-featured rich-text or "visual" HTML editor for the Web. Though VisualEditor itself is an HTML editor, it is integrated into platforms for use there, primary in MediaWiki-General with the VisualEditor-MediaWiki integration, used in conjunction with the Parsoid parsing service to provide the HTML RDFa.

Our projects are arranged as follows:

VisualEditor – Anything related to VisualEditor, including related extensions.

VisualEditor-ContentEditable – Items related to the contentEditable technology at the core of VisualEditor, such as typing or selection issues.
VisualEditor-ContentLanguage – Items related to specific language issues, like interference with an Input Method Editor.
VisualEditor-CopyPaste – Items related to copying, cutting and pasting content.
VisualEditor-DataModel – Items related to the core data model code inside VisualEditor, like corruption issues.
VisualEditor-Edit Cards – Items related to the editing interface that shows additional details about, and actions related to, editable elements within articles.
VisualEditor-EditingTools – Items related to the main editing tools inside VisualEditor, like lists or text styling.
VisualEditor-Initialisation – Items related to the loading (and unloading) of VisualEditor itself.
VisualEditor-InterfaceLanguage – Items related to the i18n inside VisualEditor.
VisualEditor-Links – Items related to adding and editing links inside stand-alone VisualEditor. You probably want VisualEditor-MediaWiki-Links.
VisualEditor-Media – Items related to adding and editing media inside stand-alone VisualEditor. You probably want VisualEditor-MediaWiki-Media.
VisualEditor-Performance – Items related to the performance of VisualEditor.
VisualEditor-Tables – Items related to adding and editing tables inside VisualEditor.
VisualEditor-VisualDiffs – Items related to the visual diff system inside VisualEditor.

VisualEditor-MediaWiki – Items related to the use of VisualEditor inside MediaWiki.
VisualEditor-MediaWiki-Links – Items related to the adding and editing of links in VisualEditor inside MediaWiki.
VisualEditor-MediaWiki-Media – Items related to the adding and editing of media in VisualEditor inside MediaWiki.
VisualEditor-MediaWiki-Mobile – Items related to the use of VisualEditor inside MediaWiki on mobile devices.
VisualEditor-MediaWiki-Plugins – Items related to the creation of VisualEditor tools for MediaWiki extensions.
VisualEditor-MediaWiki-References – Items related to the adding and editing of MediaWiki Cite references in VisualEditor.
VisualEditor-MediaWiki-Templates – Items related to the adding and editing of MediaWiki templates in VisualEditor.

Recent Activity
View All

Today

MusikAnimal added a comment to T357482: 2017 wikitext editor integration in CodeMirror 6.

I have also seen different behaviour depending on screen size, whether or not you resize your screen while using the 2017 Editor, and probably lots of other factors (e.g. what happens when you actually make edits, zoom in and out, etc.). I have yet to spend time testing other browsers systematically.

Tue, Sep 3, 6:54 PM · Patch-For-Review, Community-Tech (Gray Fox (Aug 26 - Sept 6)), MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-extensions-CodeMirror

gerritbot added a project to T357482: 2017 wikitext editor integration in CodeMirror 6: Patch-For-Review.

Tue, Sep 3, 6:47 PM · Patch-For-Review, Community-Tech (Gray Fox (Aug 26 - Sept 6)), MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-extensions-CodeMirror

gerritbot added a comment to T357482: 2017 wikitext editor integration in CodeMirror 6.

Change #1070313 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] ve.ui.CodeMirror.v6: force a normal font-style

https://gerrit.wikimedia.org/r/1070313

Tue, Sep 3, 6:46 PM · Patch-For-Review, Community-Tech (Gray Fox (Aug 26 - Sept 6)), MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-extensions-CodeMirror

Trizek-WMF added a comment to T373690: Diffs are tagged as "Edit Check (references) activated" while users haven't added any footnote.

Thank you for investigating, David.
Yes, it is quite confusing. Shouldn't it be repurposed as a maintenance tag?

Tue, Sep 3, 4:47 PM · EditCheck, Editing-team, VisualEditor

Maintenance_bot removed a project from T365311: Syntax highlighter is broken on Dark Mode: Patch-For-Review.

Tue, Sep 3, 4:31 PM · User-notice, Community-Tech (Gray Fox (Aug 26 - Sept 6)), MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), dark-mode, Editing-team, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror

MusikAnimal added a project to T365311: Syntax highlighter is broken on Dark Mode: User-notice.

New colors (applies to all wikis) and a new search panel (mediawiki.org, hewiki, and soon to be all of group0) I think warrants a Tech News announcement. I'll add something for this, T371436, and the group0 deployment (T357795), all of which are aimed for next week.

Tue, Sep 3, 4:23 PM · User-notice, Community-Tech (Gray Fox (Aug 26 - Sept 6)), MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), dark-mode, Editing-team, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror

MusikAnimal moved T365311: Syntax highlighter is broken on Dark Mode from Feedback and review to QA on the Community-Tech (Gray Fox (Aug 26 - Sept 6)) board.

Probably doesn't need extensive QA given how many eyes have tested this, including against contrast checkers, but please do your thing :)

Tue, Sep 3, 4:17 PM · User-notice, Community-Tech (Gray Fox (Aug 26 - Sept 6)), MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), dark-mode, Editing-team, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror

gerritbot added a comment to T365311: Syntax highlighter is broken on Dark Mode.

Change #1059166 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Implement dark mode styles and use Codex CSS components in search panel

https://gerrit.wikimedia.org/r/1059166

Tue, Sep 3, 3:59 PM · User-notice, Community-Tech (Gray Fox (Aug 26 - Sept 6)), MW-1.43-notes (1.43.0-wmf.16; 2024-07-30), dark-mode, Editing-team, VisualEditor, VisualEditor-MediaWiki-2017WikitextEditor, MediaWiki-extensions-CodeMirror

dancy removed a parent task for T373661: "Cannot read properties of null (reading 'keyedNodes')" opening Basic citation in 2017 Source Editor: T373640: 1.43.0-wmf.21 deployment blockers.

Tue, Sep 3, 3:58 PM · MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), WMDE-TechWish-Sprint-2024-08-21, Cite-Extends, WMDE-TechWish, WMDE-References-FocusArea, VisualEditor-MediaWiki-References, Cite, VisualEditor, Beta-Cluster-reproducible

thiemowmde added a comment to T373661: "Cannot read properties of null (reading 'keyedNodes')" opening Basic citation in 2017 Source Editor.

To my knowledge, no, this is not a blocker any more. https://gerrit.wikimedia.org/r/1069236 fixed it before the branch cut.

Tue, Sep 3, 3:57 PM · MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), WMDE-TechWish-Sprint-2024-08-21, Cite-Extends, WMDE-TechWish, WMDE-References-FocusArea, VisualEditor-MediaWiki-References, Cite, VisualEditor, Beta-Cluster-reproducible

dancy added a comment to T373661: "Cannot read properties of null (reading 'keyedNodes')" opening Basic citation in 2017 Source Editor.

Thanks @thiemowmde. So this issue is no longer a train blocker?

Tue, Sep 3, 3:51 PM · MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), WMDE-TechWish-Sprint-2024-08-21, Cite-Extends, WMDE-TechWish, WMDE-References-FocusArea, VisualEditor-MediaWiki-References, Cite, VisualEditor, Beta-Cluster-reproducible

thiemowmde added a comment to T373661: "Cannot read properties of null (reading 'keyedNodes')" opening Basic citation in 2017 Source Editor.

https://gerrit.wikimedia.org/r/1070232 is essentially just ongoing code cleanup. We are not aware of a way a user could trigger an error in the spots touched by https://gerrit.wikimedia.org/r/1070232. Therefor we don't think this needs backporting.

Esanders added a comment to T373875: New default font size for logged out user causes issues with VE UI.

There's misalignment in the 2010 wiktiext editor toolbar too, possibly due to the embeeded OOUI buttons on the right:

Tue, Sep 3, 3:32 PM · FY2023-24-WE 2.1 Typography and palette customizations, VisualEditor

dancy added a comment to T373661: "Cannot read properties of null (reading 'keyedNodes')" opening Basic citation in 2017 Source Editor.

Will someone be backporting https://gerrit.wikimedia.org/r/1070232 to wmf/1.43.0-wmf.21 ?

Tue, Sep 3, 3:10 PM · MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), WMDE-TechWish-Sprint-2024-08-21, Cite-Extends, WMDE-TechWish, WMDE-References-FocusArea, VisualEditor-MediaWiki-References, Cite, VisualEditor, Beta-Cluster-reproducible

• Lucas_Werkmeister_WMDE added a comment to T239796: Provide URL parameter(s) to always load a wikitext editor.

Cool, thanks! (Regarding the mention of T235753 in the task description, I think in the meantime that task changed enough that we don’t need a follow-up to use the new URL parameter there – it looks like we rephrased the interface message from “in the wikitext” to “using the article editor”, so if it ends up opening VE, that’s probably fine.)

Tue, Sep 3, 1:37 PM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor-MediaWiki, VisualEditor

Maintenance_bot removed a project from T373661: "Cannot read properties of null (reading 'keyedNodes')" opening Basic citation in 2017 Source Editor: Patch-For-Review.

Tue, Sep 3, 1:30 PM · MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), WMDE-TechWish-Sprint-2024-08-21, Cite-Extends, WMDE-TechWish, WMDE-References-FocusArea, VisualEditor-MediaWiki-References, Cite, VisualEditor, Beta-Cluster-reproducible

Esanders created T373875: New default font size for logged out user causes issues with VE UI.

Tue, Sep 3, 1:16 PM · FY2023-24-WE 2.1 Typography and palette customizations, VisualEditor

ReleaseTaggerBot edited projects for T373661: "Cannot read properties of null (reading 'keyedNodes')" opening Basic citation in 2017 Source Editor, added: MW-1.43-notes (1.43.0-wmf.22; 2024-09-10); removed MW-1.43-notes (1.43.0-wmf.21; 2024-09-03).

Tue, Sep 3, 1:01 PM · MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), WMDE-TechWish-Sprint-2024-08-21, Cite-Extends, WMDE-TechWish, WMDE-References-FocusArea, VisualEditor-MediaWiki-References, Cite, VisualEditor, Beta-Cluster-reproducible

gerritbot added a comment to T373661: "Cannot read properties of null (reading 'keyedNodes')" opening Basic citation in 2017 Source Editor.

Change #1070232 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Finish safety fallback for missing groups

https://gerrit.wikimedia.org/r/1070232

Tue, Sep 3, 12:52 PM · MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), WMDE-TechWish-Sprint-2024-08-21, Cite-Extends, WMDE-TechWish, WMDE-References-FocusArea, VisualEditor-MediaWiki-References, Cite, VisualEditor, Beta-Cluster-reproducible

Bhsd added a comment to T357482: 2017 wikitext editor integration in CodeMirror 6.

I am surprised to see that white-space: pre-wrap is performing better than white-space: break-spaces in certain conditions. By the way, I notice that the misalignment also appears when switching between LTR and RTL.

Tue, Sep 3, 12:52 PM · Patch-For-Review, Community-Tech (Gray Fox (Aug 26 - Sept 6)), MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-extensions-CodeMirror

Esanders renamed T373868: Link nails are visible when text around them is selected from Link nails are visible when text around them are selected to Link nails are visible when text around them is selected.

Tue, Sep 3, 12:41 PM · Patch-For-Review, VisualEditor-ContentEditable, VisualEditor

gerritbot added a project to T373868: Link nails are visible when text around them is selected: Patch-For-Review.

Tue, Sep 3, 12:37 PM · Patch-For-Review, VisualEditor-ContentEditable, VisualEditor

gerritbot added a comment to T373868: Link nails are visible when text around them is selected.

Change #1070240 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Keep nails transparent when selected

https://gerrit.wikimedia.org/r/1070240

Tue, Sep 3, 12:37 PM · Patch-For-Review, VisualEditor-ContentEditable, VisualEditor

Esanders created T373868: Link nails are visible when text around them is selected.

Tue, Sep 3, 12:33 PM · Patch-For-Review, VisualEditor-ContentEditable, VisualEditor

awight added a comment to T373661: "Cannot read properties of null (reading 'keyedNodes')" opening Basic citation in 2017 Source Editor.

One small breadcrumb about this weird bug: the difference between the 2017 (VE) source editor and visual editing seems to be that it doesn't add a placeholder reference node to the empty document fragment before opening the dialog, so no default reference group gets implicitly created.

Tue, Sep 3, 11:49 AM · MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), WMDE-TechWish-Sprint-2024-08-21, Cite-Extends, WMDE-TechWish, WMDE-References-FocusArea, VisualEditor-MediaWiki-References, Cite, VisualEditor, Beta-Cluster-reproducible

gerritbot added a project to T373661: "Cannot read properties of null (reading 'keyedNodes')" opening Basic citation in 2017 Source Editor: Patch-For-Review.

Tue, Sep 3, 11:41 AM · MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), WMDE-TechWish-Sprint-2024-08-21, Cite-Extends, WMDE-TechWish, WMDE-References-FocusArea, VisualEditor-MediaWiki-References, Cite, VisualEditor, Beta-Cluster-reproducible

gerritbot added a comment to T373661: "Cannot read properties of null (reading 'keyedNodes')" opening Basic citation in 2017 Source Editor.

Change #1070232 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Finish safety fallback for missing groups

https://gerrit.wikimedia.org/r/1070232

dom_walden added a comment to T357482: 2017 wikitext editor integration in CodeMirror 6.

I have found examples of misalignment on Safari 17 and 16 as well. So far, nothing as bad as Chrome.

Tue, Sep 3, 10:52 AM · Patch-For-Review, Community-Tech (Gray Fox (Aug 26 - Sept 6)), MW-1.43-notes (1.43.0-wmf.19; 2024-08-20), VisualEditor-MediaWiki-2017WikitextEditor, VisualEditor, MediaWiki-extensions-CodeMirror

WMDE-Fisch moved T373661: "Cannot read properties of null (reading 'keyedNodes')" opening Basic citation in 2017 Source Editor from In progress to Done on the WMDE-References-FocusArea board.

Tue, Sep 3, 9:43 AM · MW-1.43-notes (1.43.0-wmf.22; 2024-09-10), WMDE-TechWish-Sprint-2024-08-21, Cite-Extends, WMDE-TechWish, WMDE-References-FocusArea, VisualEditor-MediaWiki-References, Cite, VisualEditor, Beta-Cluster-reproducible

dom_walden added a comment to T357482: 2017 wikitext editor integration in CodeMirror 6.

In T357482#10107235, @MusikAnimal wrote:

In T357482#10105280, @Bhsd wrote:

Were you able to reproduce the same issue Dom found above? You both are reporting to use Windows, so maybe that's why I can't reproduce it.

Yes, and it is fixed by styling the CM6 editor font-style: normal !important, similar to the font weight.

Awesome! So that's a CSS rule that needs to be added? Would you mind submitting a patch? If both you and Dom can verify the fix, I am happy to 2, as I have no means of testing it.