Page MenuHomePhabricator

Anti-Harassment (AHT Sprint 6)Milestone
ArchivedPublic

Watchers

  • This project does not have any watchers.
  • View All

Recent Activity

Sep 13 2018

aezell edited a custom field on Anti-Harassment (AHT Sprint 6).
Sep 13 2018, 4:53 PM

Oct 20 2017

dbarratt added a parent task for T174197: Split off AntiSpoof equivset generation and string normalization into its own library: T178537: Add wikimedia/equivset for AbuseFilter & AntiSpoof.
Oct 20 2017, 11:47 PM · Anti-Harassment (AHT Sprint 6), Patch-For-Review, Librarization, AntiSpoof
dbarratt added a parent task for T174197: Split off AntiSpoof equivset generation and string normalization into its own library: T174195: More extensive unit testing for AntiSpoof.
Oct 20 2017, 11:42 PM · Anti-Harassment (AHT Sprint 6), Patch-For-Review, Librarization, AntiSpoof
dbarratt added a parent task for T174197: Split off AntiSpoof equivset generation and string normalization into its own library: T177983: Update AntiSpoof to use new Equivset library.
Oct 20 2017, 11:40 PM · Anti-Harassment (AHT Sprint 6), Patch-For-Review, Librarization, AntiSpoof
dbarratt removed a subtask for T174197: Split off AntiSpoof equivset generation and string normalization into its own library: T177983: Update AntiSpoof to use new Equivset library.
Oct 20 2017, 11:40 PM · Anti-Harassment (AHT Sprint 6), Patch-For-Review, Librarization, AntiSpoof
dbarratt added a parent task for T174197: Split off AntiSpoof equivset generation and string normalization into its own library: T175413: Update AbuseFilter to use new AntiSpoof library.
Oct 20 2017, 11:39 PM · Anti-Harassment (AHT Sprint 6), Patch-For-Review, Librarization, AntiSpoof
dbarratt removed a subtask for T174197: Split off AntiSpoof equivset generation and string normalization into its own library: T175413: Update AbuseFilter to use new AntiSpoof library.
Oct 20 2017, 11:39 PM · Anti-Harassment (AHT Sprint 6), Patch-For-Review, Librarization, AntiSpoof
dbarratt added a parent task for T174197: Split off AntiSpoof equivset generation and string normalization into its own library: T177667: Get Equivset Test Coverage to 100%.
Oct 20 2017, 11:36 PM · Anti-Harassment (AHT Sprint 6), Patch-For-Review, Librarization, AntiSpoof
dbarratt removed a subtask for T174197: Split off AntiSpoof equivset generation and string normalization into its own library: T177667: Get Equivset Test Coverage to 100%.
Oct 20 2017, 11:36 PM · Anti-Harassment (AHT Sprint 6), Patch-For-Review, Librarization, AntiSpoof

Oct 16 2017

TBolliger closed T177711: Notify users about ccnorm_contains_any and update abuse filter documentation, a subtask of T65242: ccnorm revamp: add a more sensible interface for normalised comparison, as Resolved.
Oct 16 2017, 6:43 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, AbuseFilter, I18n, AntiSpoof

Oct 14 2017

Catrope added a comment to T177437: Update Echo and Run Maintenance Script.

This script inserted zeroes (the user ID zero, suggesting a CU lookup failure) into the blacklists of a few thousand users, and possibly broke all notifications for them. See T177825#3685628.

Oct 14 2017, 10:50 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Collaboration-Team-Triage, Notifications, Patch-For-Review, Anti-Harassment (AHT Sprint 6)
dmaza added a comment to T65242: ccnorm revamp: add a more sensible interface for normalised comparison.

@He7d3r I don't think ccnorm_contains_any solves anything for https://pt.wikipedia.org/wiki/Special:AbuseFilter/18.
It literally translates to contains_any(ccnorm(param1), ccnorm(param2), ...) so you still have the boundaries issue.

Oct 14 2017, 1:59 AM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, AbuseFilter, I18n, AntiSpoof

Oct 11 2017

kaldari added a comment to T65242: ccnorm revamp: add a more sensible interface for normalised comparison.

@He7d3r: Combining normalization and regexes is tricky, but it might be worth experimenting further. Regarding #3, I created T178010.

Oct 11 2017, 10:52 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, AbuseFilter, I18n, AntiSpoof
TBolliger changed the status of T175413: Update AbuseFilter to use new AntiSpoof library, a subtask of T174197: Split off AntiSpoof equivset generation and string normalization into its own library, from Stalled to Open.
Oct 11 2017, 7:05 PM · Anti-Harassment (AHT Sprint 6), Patch-For-Review, Librarization, AntiSpoof
dbarratt added a subtask for T174197: Split off AntiSpoof equivset generation and string normalization into its own library: T177983: Update AntiSpoof to use new Equivset library.
Oct 11 2017, 7:03 PM · Anti-Harassment (AHT Sprint 6), Patch-For-Review, Librarization, AntiSpoof
TBolliger archived Anti-Harassment (AHT Sprint 6).
Oct 11 2017, 6:35 PM
He7d3r added a comment to T65242: ccnorm revamp: add a more sensible interface for normalised comparison.

We want to detect edits which add any expression from a given list of "words". We need to use regexes in order to specify this list, because:

  1. We need to check for word boundaries to avoid false positives (e.g.: "VIADO" vs "AVIADOR")
  2. Each word has many variations (e.g. BANDID(?:AO|ONA|INH[AO]) matches 4 specific variations of a single word while not matching variants which would increase the number of false positives)
  3. Some characters are not normalized as we want (e.g. ccnorm('ÈÉÊẼÌÍÏÓÒÔÕ∅Q̃ÚŰÜŨ') == 'EEEEIIIOOOOOQUUUU' should be true), so we use character classes inside the regexes to deal with these cases.
Oct 11 2017, 1:20 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, AbuseFilter, I18n, AntiSpoof

Oct 10 2017

kaldari added a comment to T65242: ccnorm revamp: add a more sensible interface for normalised comparison.

@He7d3r: I can't parse what https://pt.wikipedia.org/wiki/Special:AbuseFilter/18 is trying to do. Can you give us a simplified use case here? The use case that ccnorm_contains_any() was written to address is the one in the description:
ccnorm_contains_any( added_lines, "testing", "vandalizing" )

Oct 10 2017, 10:13 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, AbuseFilter, I18n, AntiSpoof
ReleaseTaggerBot added a project to T177437: Update Echo and Run Maintenance Script: MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).
Oct 10 2017, 7:00 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Collaboration-Team-Triage, Notifications, Patch-For-Review, Anti-Harassment (AHT Sprint 6)
gerritbot added a comment to T177437: Update Echo and Run Maintenance Script.

Change 383183 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] updatePerUserBlacklist wfWaitForSlaves()

Oct 10 2017, 6:51 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Collaboration-Team-Triage, Notifications, Patch-For-Review, Anti-Harassment (AHT Sprint 6)
gerritbot added a comment to T173475: Echo Notification Mute (Block List) can be bypassed by changing username.

Change 383183 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] updatePerUserBlacklist wfWaitForSlaves()

Oct 10 2017, 6:51 PM · Security, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, Collaboration-Team-Triage, Notifications
TBolliger updated the task description for T177711: Notify users about ccnorm_contains_any and update abuse filter documentation.
Oct 10 2017, 5:39 PM · User-notice-archive, Anti-Harassment (AHT Sprint 7), AbuseFilter, I18n, AntiSpoof
dmaza claimed T168736: AbuseFilter is reading variables incorrectly and tripping the wrong edits.
Oct 10 2017, 4:30 PM · MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), AbuseFilter
dmaza moved T168736: AbuseFilter is reading variables incorrectly and tripping the wrong edits from Ready to In progress on the Anti-Harassment (AHT Sprint 6) board.
Oct 10 2017, 4:30 PM · MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), AbuseFilter

Oct 9 2017

Aklapper added a project to T177437: Update Echo and Run Maintenance Script: Notifications.

General reminder: Please add codebase projects like Notifications so such tasks can be found when searching for tasks in that codebase project. Thanks.

Oct 9 2017, 9:38 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Collaboration-Team-Triage, Notifications, Patch-For-Review, Anti-Harassment (AHT Sprint 6)
dbarratt moved T173475: Echo Notification Mute (Block List) can be bypassed by changing username from Code Review to Done on the Anti-Harassment (AHT Sprint 6) board.
Oct 9 2017, 8:15 PM · Security, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, Collaboration-Team-Triage, Notifications
hashar added a comment to T177437: Update Echo and Run Maintenance Script.

The updatePerUserBlacklist script required a live hack. I did a commit for the wmf branch but that needs to be ported to the master branch https://gerrit.wikimedia.org/r/383182 updatePerUserBlacklist wfWaitForSlaves()

Oct 9 2017, 8:10 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Collaboration-Team-Triage, Notifications, Patch-For-Review, Anti-Harassment (AHT Sprint 6)
gerritbot added a project to T177437: Update Echo and Run Maintenance Script: Patch-For-Review.
Oct 9 2017, 8:09 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Collaboration-Team-Triage, Notifications, Patch-For-Review, Anti-Harassment (AHT Sprint 6)
gerritbot added a comment to T177437: Update Echo and Run Maintenance Script.

Change 383183 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/Echo@master] updatePerUserBlacklist wfWaitForSlaves()

Oct 9 2017, 8:09 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Collaboration-Team-Triage, Notifications, Patch-For-Review, Anti-Harassment (AHT Sprint 6)
hashar closed T173475: Echo Notification Mute (Block List) can be bypassed by changing username as Resolved.

The updatePerUserBlacklist script required a live hack. I did a commit for the wmf branch but that needs to be ported to the master branch https://gerrit.wikimedia.org/r/383182 updatePerUserBlacklist wfWaitForSlaves()

Oct 9 2017, 8:09 PM · Security, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, Collaboration-Team-Triage, Notifications
ReleaseTaggerBot edited projects for T173475: Echo Notification Mute (Block List) can be bypassed by changing username, added: MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)); removed MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)).
Oct 9 2017, 8:00 PM · Security, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, Collaboration-Team-Triage, Notifications
dbarratt closed T177437: Update Echo and Run Maintenance Script as Resolved.

@hashar is a boss man and fixed the bug and ran the script. This is done!

Oct 9 2017, 7:56 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Collaboration-Team-Triage, Notifications, Patch-For-Review, Anti-Harassment (AHT Sprint 6)
dbarratt closed T177437: Update Echo and Run Maintenance Script, a subtask of T173475: Echo Notification Mute (Block List) can be bypassed by changing username, as Resolved.
Oct 9 2017, 7:56 PM · Security, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, Collaboration-Team-Triage, Notifications
dbarratt moved T173475: Echo Notification Mute (Block List) can be bypassed by changing username from Done to Code Review on the Anti-Harassment (AHT Sprint 6) board.
Oct 9 2017, 7:54 PM · Security, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, Collaboration-Team-Triage, Notifications
gerritbot added a comment to T173475: Echo Notification Mute (Block List) can be bypassed by changing username.

Change 383183 had a related patch set uploaded (by Dbarratt; owner: Hashar):
[mediawiki/extensions/Echo@master] updatePerUserBlacklist wfWaitForSlaves()

Oct 9 2017, 7:52 PM · Security, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, Collaboration-Team-Triage, Notifications
gerritbot added a comment to T173475: Echo Notification Mute (Block List) can be bypassed by changing username.

Change 383182 merged by jenkins-bot:
[mediawiki/extensions/Echo@wmf/1.31.0-wmf.2] updatePerUserBlacklist wfWaitForSlaves()

Oct 9 2017, 7:50 PM · Security, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, Collaboration-Team-Triage, Notifications
Stashbot added a comment to T173475: Echo Notification Mute (Block List) can be bypassed by changing username.

Mentioned in SAL (#wikimedia-operations) [2017-10-09T19:50:42Z] <hashar@tin> Synchronized php-1.31.0-wmf.2/extensions/Echo/maintenance/updatePerUserBlacklist.php: Sync a live hack in Echo updatePerUserBlacklist https://gerrit.wikimedia.org/r/#/c/383182/ - T173475 (duration: 00m 47s)

Oct 9 2017, 7:50 PM · Security, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, Collaboration-Team-Triage, Notifications
hashar reopened T173475: Echo Notification Mute (Block List) can be bypassed by changing username as "Open".

The updatePerUserBlacklist script required a live hack. I did a commit for the wmf branch but that needs to be ported to the master branch https://gerrit.wikimedia.org/r/383182 updatePerUserBlacklist wfWaitForSlaves()

Oct 9 2017, 7:44 PM · Security, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, Collaboration-Team-Triage, Notifications
gerritbot added a comment to T173475: Echo Notification Mute (Block List) can be bypassed by changing username.

Change 383182 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/Echo@wmf/1.31.0-wmf.2] updatePerUserBlacklist wfWaitForSlaves()

Oct 9 2017, 7:40 PM · Security, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, Collaboration-Team-Triage, Notifications
dbarratt added a comment to T177437: Update Echo and Run Maintenance Script.

The deploy failed (again)

1$ mwscript extensions/Echo/maintenance/updatePerUserBlacklist.php --wiki=zhwiki
2Updating Echo Notification Blacklist...
3Updated 0 Users
4PHP Notice: Undefined variable: dbFactory in /srv/mediawiki/php-1.31.0-wmf.2/extensions/Echo/maintenance/updatePerUserBlacklist.php on line 82
5Notice: Undefined variable: dbFactory in /srv/mediawiki/php-1.31.0-wmf.2/extensions/Echo/maintenance/updatePerUserBlacklist.php on line 82
6PHP Fatal error: Call to a member function waitForSlaves() on null in /srv/mediawiki/php-1.31.0-wmf.2/extensions/Echo/maintenance/updatePerUserBlacklist.php on line 82
7Fatal error: Call to a member function waitForSlaves() on null in /srv/mediawiki/php-1.31.0-wmf.2/extensions/Echo/maintenance/updatePerUserBlacklist.php on line 82
8

Oct 9 2017, 7:33 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Collaboration-Team-Triage, Notifications, Patch-For-Review, Anti-Harassment (AHT Sprint 6)
Stashbot added a comment to T173475: Echo Notification Mute (Block List) can be bypassed by changing username.

Mentioned in SAL (#wikimedia-operations) [2017-10-09T19:17:52Z] <hashar@tin> Synchronized php-1.31.0-wmf.2/extensions/Echo: Reapply "Use User Ids instead of User Names for Echo Mute"" - T173475 (duration: 00m 52s)

Oct 9 2017, 7:17 PM · Security, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, Collaboration-Team-Triage, Notifications
gerritbot added a comment to T173475: Echo Notification Mute (Block List) can be bypassed by changing username.

Change 383173 merged by jenkins-bot:
[mediawiki/extensions/Echo@wmf/1.31.0-wmf.2] Reapply "Use User Ids instead of User Names for Echo Mute""

Oct 9 2017, 7:10 PM · Security, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, Collaboration-Team-Triage, Notifications
gerritbot added a comment to T173475: Echo Notification Mute (Block List) can be bypassed by changing username.

Change 383173 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/Echo@wmf/1.31.0-wmf.2] Reapply "Use User Ids instead of User Names for Echo Mute""

Oct 9 2017, 6:55 PM · Security, MW-1.31-release-notes (WMF-deploy-2017-10-03 (1.31.0-wmf.2)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, Collaboration-Team-Triage, Notifications
He7d3r added a comment to T177711: Notify users about ccnorm_contains_any and update abuse filter documentation.

Could you also add examples which applicable to T65242#3669911 (T29987#324746), if possible?

Oct 9 2017, 4:58 PM · User-notice-archive, Anti-Harassment (AHT Sprint 7), AbuseFilter, I18n, AntiSpoof
He7d3r added a comment to T65242: ccnorm revamp: add a more sensible interface for normalised comparison.

I'm having a hard time trying to see if/how this can be used to deal with the original use case mentioned at T29987#324746. Our regexes are less readable then ever:
https://pt.wikipedia.org/wiki/Special:AbuseFilter/18
Tim's proposal would still help (since the special character "|" of the regexes would not be normalized), but I'm not sure if we can use this new function to improve things a little...

Oct 9 2017, 4:33 PM · MW-1.31-release-notes (WMF-deploy-2017-10-10 (1.31.0-wmf.3)), Anti-Harassment (AHT Sprint 6), Patch-For-Review, AbuseFilter, I18n, AntiSpoof
matej_suchanek edited projects for T177711: Notify users about ccnorm_contains_any and update abuse filter documentation, added: User-notice; removed Notice.
Oct 9 2017, 7:24 AM · User-notice-archive, Anti-Harassment (AHT Sprint 7), AbuseFilter, I18n, AntiSpoof
dbarratt closed T169883: Deploy new Takedown Tools to Prod as Resolved.
Oct 9 2017, 3:20 AM · Anti-Harassment (AHT Sprint 6), Wikimedia-Takedown-Tools
dbarratt moved T169883: Deploy new Takedown Tools to Prod from Ready to Done on the Anti-Harassment (AHT Sprint 6) board.
Oct 9 2017, 3:20 AM · Anti-Harassment (AHT Sprint 6), Wikimedia-Takedown-Tools
dbarratt closed T173881: Import Old Takedown Tools DB into New Takedown Tools DB as Resolved.
Oct 9 2017, 3:20 AM · Anti-Harassment (AHT Sprint 6), Wikimedia-Takedown-Tools

Oct 8 2017

dmaza moved T174205: Log cases where abusefilter filters take over a certain amount of time to run from In progress to Code Review on the Anti-Harassment (AHT Sprint 6) board.
Oct 8 2017, 6:07 AM · MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), Anti-Harassment (AHT Sprint 7), Patch-For-Review, AbuseFilter