Nice catch, I'll look into this ASaP

Cannot reproduce anymore on mediawiki.org, closing this for now.

I'm not seeing this happen anymore (graphs are regenerated by Graphoid fine on a VE save on mediawiki.org), so closing this.

This is due to the graph extension stylesheet not being loaded the first time a graph is created on a page, resulting in VE wrongly displaying them as blocks. According to the stylesheet graphs should always be displayed as an inline-block.

Thinking of digging into this, is this up for grabs?

@Esanders I get those as well

Just checked, this happens on enwiki as well, so it's probably been out there for a while now

I'm not able to reproduce this issue on my end, but treemap not being in the Vega2 mark documentation gives me the impression that this stopped being supported in Vega2.

Looking for review on this: @Esanders @Jdforrester-WMF ?

dammit, found the problem. Dumb dumb me wasn't pulling the right repo (I was pulling /mediawiki instead of the mw-vagrant root).

Nope, still no go. I effectively had a /: on line 7, but still after removing it and running vagrant reload and vagrant provision the same 503 error happens upon VE load.

It's not running, I'm getting curl: (7) Failed to connect to localhost port 7231: Connection refused

That's what I did, but it didn't fix it.

Looks like this issue is back :/ I'm getting 503's again in console as well as this warning in Chrome when trying to open up VisualEditor:

I can confirm it works. Thanks a lot!

Hmm still no go for me. I can't make out anything out of my logs, maybe you could take a look:

I am not getting a prompt to choose either VE or wikitext... I only have an "Edit Source" button which takes me to the wikitext editor.

Closing this as it doesn't happen anymore in local as well as on mediawiki.org

How is this possible? Doesn't jenkins run the tests before trying to merge?

@Krenair I was talking about a graph edit specifically. If the user opens the graph dialog of a graph made with Vega 1, the tool should automagically convert it to Vega 2.

This is weird, I'm able to reproduce this. Graphs in read mode aren't being rendered, though if I go save some edit through wikitext editor, everything works well again. This is surely related to the new vega2 support ext.graph is doing

The current 60x60 limit was completely arbitrary, it's trivial to fix and probably a good idea ;)

Yeah me and @Esanders noticed that as well, that's because OO.ui.DimensionsWidget doesn't account for resizable nodes when it probably should.

If so, we should probably update the Graphoid documentation to reflect that

Update: This is due to a clash between assumptions that both VE and the Graph extension makes on what the page data is. On a save from VE, the HTML presented to the user is not actually rerendered from the server, but rather served by VE through Parsoid.

This file is part of Ace Editor and not MW, so in theory this should happen anywhere ve.ui.MWAceEditorWidget is being used

Is this happening with bar graphs? We pushed a fix this morning that fixes this kind of issue
T109645: Bar charts are not displaying properly directly after a save in VisualEditor

Okay good, keep us posted :)

Figured out what was causing this: Once you apply changes to a page, any boolean values in a spec set to true will show up as either "" or null in mw.config.wgGraphSpecs, causing the graph to not render properly (bar graphs have a band property set to true, which is why they fail but not area and line graphs). Once you refresh the page though, booleans are fine.

I checked it again today and that graph works now. Maybe it indeed was an issue in Parsoid and *something* solved this issue?

Any word on that?