Page MenuHomePhabricator

Turnstep (Greg Sabino Mullane)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 25 2014, 1:07 PM (527 w, 4 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Turnstep [ Global Accounts ]

Recent Activity

Aug 17 2017

Turnstep added a watcher for PostgreSQL: Turnstep.
Aug 17 2017, 4:57 PM
Turnstep added a comment to T164898: PostgreSQL schema change for consistency with MySQL.

Rename tables mwuser to user, and pagecontent to text. Table names are always quoted, so
it doesn't matter if they are keywords. A table prefix can be used if desired to avoid having
table names that are keywords.

Aug 17 2017, 4:40 PM · MW-1.37-notes (1.37.0-wmf.7; 2021-05-25), MW-1.36-notes, MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), User-Ladsgroup, Platform Engineering, TechCom-RFC (TechCom-RFC-Closed), Technical-Debt, PostgreSQL
Turnstep added a comment to T164898: PostgreSQL schema change for consistency with MySQL.

Not sure how I missed this task until now. I'm mostly okay with this, but the timestamp change in particular seems a step in the wrong direction.

Aug 17 2017, 4:37 PM · MW-1.37-notes (1.37.0-wmf.7; 2021-05-25), MW-1.36-notes, MW-1.35-notes (1.35.0-wmf.41; 2020-07-14), User-Ladsgroup, Platform Engineering, TechCom-RFC (TechCom-RFC-Closed), Technical-Debt, PostgreSQL

Aug 9 2017

Turnstep added a comment to T172845: What makes a high quality MediaWiki extension? - Hackathon session.

A good extension name, that explains intuitively what it does and avoids generic words

Aug 9 2017, 1:36 PM · MediaWiki-extensions-General, Wikimania-Hackathon-2017

Oct 16 2016

Turnstep added a comment to T147599: Cannot install 1.28 alpha with PostgreSQL database.

Ok, well it was just a quick idea. If I get some time I will test this out but most of my test boxes cannot handle 1.28 at the moment due to the recent PHP requirement.

Oct 16 2016, 3:44 PM · PostgreSQL, MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), Patch-For-Review, MW-1.28-release, Regression, MediaWiki-libs-Rdbms, MediaWiki-Installer
Turnstep added a comment to T147599: Cannot install 1.28 alpha with PostgreSQL database.

@Turnstep hi, I carn't seem to find $conn->query("createdb") in PostgresInstaller.php.

Oct 16 2016, 3:18 PM · PostgreSQL, MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), Patch-For-Review, MW-1.28-release, Regression, MediaWiki-libs-Rdbms, MediaWiki-Installer
Turnstep added a comment to T147599: Cannot install 1.28 alpha with PostgreSQL database.

What about simply changing the $conn->query("createdb") to $conn->doQuery in PostgresInstaller.php? We lose some random sanity checks and profiling, but this is a one-time create database call so those are not really important.

Oct 16 2016, 12:44 PM · PostgreSQL, MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-10-25_(1.28.0-wmf.23)), Patch-For-Review, MW-1.28-release, Regression, MediaWiki-libs-Rdbms, MediaWiki-Installer

Sep 28 2016

Turnstep added a comment to T6323: Send a diff in email on page changes in addition to URL.

This extension is at mediawiki.org as EmailDiff

Sep 28 2016, 12:26 PM · MediaWiki-Email

Sep 6 2016

Turnstep added a comment to T134200: [RFC] RESTBase: Drop support for node 0.10 (and 0.12?).

A basic first step for questions like this is to see what the major distros (especially the LTS ones) are providing for node versions. As a point of data, looks like CentOS 7 is providing 0.10.46. On the other hand, we usually end up installing a local node anyway, so it won't affect us very much.

Sep 6 2016, 3:59 PM · Proposal, Services, RESTBase

Mar 24 2016

Turnstep added a comment to T129435: RFC: drop support for running without mbstring.

As a heavy "third-party MediaWiki operator", I am fine with requiring mbstring. It's standard, in all packaging systems, easy to enable, and seems a low cost for a high payoff.

Mar 24 2016, 2:15 PM · TechCom-RFC (TechCom-RFC-Closed), MW-1.27-release-notes, Technical-Debt

Mar 13 2016

Turnstep added a comment to T6323: Send a diff in email on page changes in addition to URL.
In T6323#2114893, @scfc wrote:

The extension looks great, but AFAIU the notification paradigm, MediaWiki only sends one notification for each page until the user visits that page again. So you get the diff for the first page and then nothing. IMHO that makes no sense.

Mar 13 2016, 8:16 PM · MediaWiki-Email

Feb 22 2016

Turnstep added a comment to T6323: Send a diff in email on page changes in addition to URL.

FWIW, this is now a full-blown extension:

Feb 22 2016, 7:28 PM · MediaWiki-Email

Jan 31 2016

Turnstep updated the task description for T125322: Change ParserFunctions license to GPL-2.0 .
Jan 31 2016, 3:30 PM · MW-1.29-release (WMF-deploy-2017-01-17_(1.29.0-wmf.8)), Software-Licensing, ParserFunctions

Jan 6 2016

Turnstep added a comment to T70320: MediaViewer ignores EXIF rotation for original size image.

Are there any temporary workarounds? Willing to monkeypatch as heavy as needed....

Jan 6 2016, 6:56 PM · Multimedia, MediaViewer

Dec 3 2015

Turnstep added a comment to T118932: RfC: Raise MediaWiki's PHP version requirement to 5.5 and update coding standards.

"If one other person (any pre-existing Phabricator user) wants to put their name down as being unequivocally opposed to releasing 1.27.0 with a PHP 5.5 requirement" Barring better arguments for 5.5 than "has some neat stuff we would like to maybe use", and as someone who has hacked production code to get MW installed on machines with a too-low-but-still-works PHP versions :), I'm opposed for now.

Dec 3 2015, 7:36 PM · TechCom-RFC (TechCom-RFC-Closed), Proposal, MW-1.27-release

Nov 12 2015

Turnstep added a comment to T76566: Search is not functional after upgrade to MW 1.24.

Time for a new release!

Nov 12 2015, 5:42 PM · MediaWiki-extensions-SphinxSearch
Turnstep added a comment to T76566: Search is not functional after upgrade to MW 1.24.

Looks like this was fixed in acd40b8fa82c04e80d390f650ee368bbdd4628cd

Nov 12 2015, 5:42 PM · MediaWiki-extensions-SphinxSearch

Oct 29 2015

Turnstep added a comment to T68485: runJobs not following redirect.

Worked around this with a cronjob executing runJobs and turning off all async calls, but this is a very nasty bug.

Oct 29 2015, 2:54 PM · MW-1.28-release-notes, MW-1.28-release (WMF-deploy-2016-08-30_(1.28.0-wmf.17)), Patch-For-Review, MediaWiki-Core-JobQueue