Page MenuHomePhabricator

Ofbeaton (Finlay Beaton)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Apr 12 2016, 10:51 PM (453 w, 6 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Ofbeaton [ Global Accounts ]

Recent Activity

Feb 19 2019

Ofbeaton created T216556: preserve redirects on pageform save.
Feb 19 2019, 8:59 PM · MediaWiki-extensions-Page_Forms
Ofbeaton added a comment to T216443: cargo query error with list storage type and table aliases.

Thank you! Looking at the code there, I'm glad I wasn't going crazy and this was a legit bug.

Feb 19 2019, 6:49 AM · MediaWiki-extensions-Cargo

Feb 18 2019

Ofbeaton added a comment to T216443: cargo query error with list storage type and table aliases.

here's the full SQL generated by the above query:

SELECT `_pagename` AS `_pageName`,`Role__full` AS `Role`
FROM `cargo__Contacts` `c`
WHERE c.`Username` = 'Ofbeaton' ORDER BY `_pageName`,`cargo__Contacts`.`Role__full` LIMIT 100
Feb 18 2019, 8:21 PM · MediaWiki-extensions-Cargo
Ofbeaton added a comment to T216443: cargo query error with list storage type and table aliases.

This error doesn't seem consistent, some of my queries with the list work, but the above one does not.

Feb 18 2019, 8:12 PM · MediaWiki-extensions-Cargo
Ofbeaton updated the task description for T216443: cargo query error with list storage type and table aliases.
Feb 18 2019, 8:00 PM · MediaWiki-extensions-Cargo
Ofbeaton created T216443: cargo query error with list storage type and table aliases.
Feb 18 2019, 7:58 PM · MediaWiki-extensions-Cargo
Ofbeaton added a comment to T216421: cargoRecreateData line 150 getcontent() on null.

Fixing the DB to remove the namespace from the title, and setting the namespace column to the proper number in the pages table fixed my problem page.

Feb 18 2019, 5:12 PM · MediaWiki-extensions-Cargo
Ofbeaton added a comment to T216421: cargoRecreateData line 150 getcontent() on null.

I started trying to debug where my bad data is coming from, by inserting echo statements.

Feb 18 2019, 5:01 PM · MediaWiki-extensions-Cargo
Ofbeaton updated subscribers of T216301: Support full conditional joins in ExternalData extension.
Feb 18 2019, 4:41 PM · MediaWiki-extensions-ExternalData
Ofbeaton updated the task description for T216421: cargoRecreateData line 150 getcontent() on null.
Feb 18 2019, 4:39 PM · MediaWiki-extensions-Cargo
Ofbeaton created T216421: cargoRecreateData line 150 getcontent() on null.
Feb 18 2019, 4:36 PM · MediaWiki-extensions-Cargo

Feb 15 2019

Ofbeaton created T216301: Support full conditional joins in ExternalData extension.
Feb 15 2019, 11:49 PM · MediaWiki-extensions-ExternalData

Feb 12 2019

Ofbeaton closed T215901: Cargo surfacing API errors/timeouts as Invalid.

OK then, thank you for taking a look. I just tried to reintroduce the problem with my API and I can't recreate it simply. I'll close this for now.

Feb 12 2019, 6:55 PM · MediaWiki-extensions-Cargo
Ofbeaton added a comment to T215901: Cargo surfacing API errors/timeouts.

Yup, then I got tons of output. ie Recreating data for Cargo table... But when api was borked I got nothing.

Feb 12 2019, 6:16 PM · MediaWiki-extensions-Cargo
Ofbeaton added a comment to T215901: Cargo surfacing API errors/timeouts.

I tried the Recreate data tab and after I hit OK I got infinite spinner. I tried php extensions/Cargo/maintenance/cargoRecreateData.php and got no output even with debug on.

Feb 12 2019, 5:09 PM · MediaWiki-extensions-Cargo
Ofbeaton added a comment to T215857: api.php PATH_INFO check infinite recursion.

How frustrating. The problem I am trying to communicate is that the API PATH_INFO redirect shenanigans means that even a small misconfiguration on the server kills it. This is the only entry point that does this.

Feb 12 2019, 5:05 PM · MediaWiki-Action-API
Ofbeaton added a comment to T215857: api.php PATH_INFO check infinite recursion.

if I reintroduce fastcgi_param PATH_INFO $fastcgi_script_name; then when I call api.php my $_SERVER['PATH_INFO'] is /api.php

Feb 12 2019, 2:59 PM · MediaWiki-Action-API
Ofbeaton created T215901: Cargo surfacing API errors/timeouts.
Feb 12 2019, 2:15 PM · MediaWiki-extensions-Cargo
Ofbeaton added a comment to T215822: Timeless skin Your account dropdown username not modifiable.

I guess to be safe in case the userpage array is not in there... you could do something like this instead:

                $userName = $user->getName();
                // Re-label some messages
		if ( isset( $personalTools['userpage'] ) ) {
                        $userName = $personalTools['userpage']['links'][0]['text'];
			$personalTools['userpage']['links'][0]['text'] = $this->getMsg( 'timeless-userpage' )->text();
		}
		if ( isset( $personalTools['mytalk'] ) ) {
			$personalTools['mytalk']['links'][0]['text'] = $this->getMsg( 'timeless-talkpage' )->text();
		}
Feb 12 2019, 2:04 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Timeless
Ofbeaton added a comment to T215822: Timeless skin Your account dropdown username not modifiable.

Yes please. This is how it is done in Vector and MonoBook.

Feb 12 2019, 1:30 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Timeless
Ofbeaton added a project to T215857: api.php PATH_INFO check infinite recursion: Wikimedia-production-error.
Feb 12 2019, 3:49 AM · MediaWiki-Action-API
Ofbeaton created T215857: api.php PATH_INFO check infinite recursion.
Feb 12 2019, 3:48 AM · MediaWiki-Action-API

Feb 11 2019

Ofbeaton updated the task description for T215822: Timeless skin Your account dropdown username not modifiable.
Feb 11 2019, 8:47 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Timeless
Ofbeaton updated the task description for T215822: Timeless skin Your account dropdown username not modifiable.
Feb 11 2019, 8:46 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Timeless
Ofbeaton updated the task description for T215822: Timeless skin Your account dropdown username not modifiable.
Feb 11 2019, 8:46 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Timeless
Ofbeaton added a comment to T215822: Timeless skin Your account dropdown username not modifiable.

this line should likely also be changed
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/skins/Timeless/ /master/includes/TimelessTemplate.php#473

$headerMsg = [ 'timeless-loggedinas', $user->getName() ];
Feb 11 2019, 6:21 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Timeless
Ofbeaton updated the task description for T215822: Timeless skin Your account dropdown username not modifiable.
Feb 11 2019, 5:16 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Timeless
Ofbeaton updated the task description for T215822: Timeless skin Your account dropdown username not modifiable.
Feb 11 2019, 5:02 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Timeless
Ofbeaton updated the task description for T215822: Timeless skin Your account dropdown username not modifiable.
Feb 11 2019, 4:51 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Timeless
Ofbeaton created T215822: Timeless skin Your account dropdown username not modifiable.
Feb 11 2019, 4:49 PM · MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), Patch-For-Review, Timeless

Jul 17 2016

Ofbeaton created T140587: web configuration does not properly detect apcu.
Jul 17 2016, 11:29 PM · MW-1.31-release-notes (WMF-deploy-2018-04-03 (1.31.0-wmf.28)), MW-1.28-release-notes, MW-1.28-release, MW-1.27-release, Patch-For-Review, [DO NOT USE] NewPHP, MediaWiki-libs-BagOStuff, MediaWiki-Documentation, Documentation, MediaWiki-Installer
Ofbeaton created T140586: icu warning links to unhelpful page.
Jul 17 2016, 11:18 PM · Documentation, MediaWiki-Documentation, MediaWiki-Installer