Page MenuHomePhabricator

Menner
SVG rendering

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Jan 18 2015, 9:06 AM (502 w, 3 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
Menner [ Global Accounts ]

My presence on Phabricator relates to issues with SVG rendering on Wikipedia.

Recent Activity

Nov 5 2018

Menner added a comment to T193352: Update librsvg to ≥2.42.3 (2.44.10).

I don't see the blocker there. The buildd page says that rustc compiles on every officially supported Debian architecture, the only ones that don't compile are a few of the unofficial ports. Maybe it has changed since the mailing list discussion?

Nov 5 2018, 8:37 PM · Technical-Debt, Epic, Thumbor, Wikimedia-SVG-rendering

Jul 28 2018

Menner added a comment to T193352: Update librsvg to ≥2.42.3 (2.44.10).

Finally I tried myself in backporting current librsvg. The problem is not the core package Rust but the submodule Cargo. It's only available in upcoming Debian 10 or later...

Jul 28 2018, 2:36 PM · Technical-Debt, Epic, Thumbor, Wikimedia-SVG-rendering
Menner added a comment to T193352: Update librsvg to ≥2.42.3 (2.44.10).

@JoKalliauer
Ok haven't looked at the details that much.

Jul 28 2018, 1:48 PM · Technical-Debt, Epic, Thumbor, Wikimedia-SVG-rendering
Menner added a comment to T193352: Update librsvg to ≥2.42.3 (2.44.10).

We cannot easily upgrade librsvg on our Debian servers from 2.40 to 2.42 as 2.42.x requires Rust. See https://buildd.debian.org/status/package.php?p=rustc&suite=unstable and the discussion in https://mail.gnome.org/archives/desktop-devel-list/2017-December/msg00072.html

Jul 28 2018, 8:25 AM · Technical-Debt, Epic, Thumbor, Wikimedia-SVG-rendering

Mar 23 2017

Menner added a comment to T152437: % of content read by % of people.

The updated (archived) version of the links I posted above:
dewiki chart
enwiki chart
writeup (in German)

Mar 23 2017, 8:44 PM · Product-Analytics, New-Readers, Reading-analysis

Aug 16 2016

Menner added a comment to T143086: SVG thumbnailing: radialGradient get ruined (striped).

The bug seems already present in 2.40.2. Commons SVG Checker shows the same and runs on older tool servers.

Aug 16 2016, 6:46 PM · Upstream, Thumbor, Wikimedia-SVG-rendering

Jul 18 2016

Menner added a comment to T139543: Some fonts not anti-aliasing in SVG thumbnails after upgrade of scaling servers.

Looks good from here. The only thing I'm curious now is that Times is not substitued by DejaVu Serif as on my Debian system last friday (not at my hands yet). On Wikimedia it is obviously not:
https://commons.wikimedia.org/wiki/File:Test_T139543.svg

Jul 18 2016, 7:18 PM · Patch-For-Review, SRE-swift-storage, Commons, SRE
Menner added a comment to T139543: Some fonts not anti-aliasing in SVG thumbnails after upgrade of scaling servers.

One more thing. Did you reboot? Otherwise try:

Jul 18 2016, 5:42 PM · Patch-For-Review, SRE-swift-storage, Commons, SRE
Menner added a comment to T139543: Some fonts not anti-aliasing in SVG thumbnails after upgrade of scaling servers.

What is the result of fc-match?

Jul 18 2016, 5:18 PM · Patch-For-Review, SRE-swift-storage, Commons, SRE

Jul 15 2016

Menner added a comment to T139543: Some fonts not anti-aliasing in SVG thumbnails after upgrade of scaling servers.

I've added such a file locally to one of the new jessie-based scalers and that seems to fix it, result is at:
https://people.wikimedia.org/~jmm/svg/alias-jessie-new.png

I'll puppetise the config file next.

Jul 15 2016, 11:50 AM · Patch-For-Review, SRE-swift-storage, Commons, SRE
Menner added a comment to T139543: Some fonts not anti-aliasing in SVG thumbnails after upgrade of scaling servers.

And so the problem starts. Librsvg expects these decisions on global level not per application/desktop environment.

Jul 15 2016, 11:39 AM · Patch-For-Review, SRE-swift-storage, Commons, SRE
Menner added a comment to T139543: Some fonts not anti-aliasing in SVG thumbnails after upgrade of scaling servers.

BTW: How do you invoke rsvg-convert / librsvg on image scalers?

Jul 15 2016, 9:49 AM · Patch-For-Review, SRE-swift-storage, Commons, SRE
Menner added a comment to T139543: Some fonts not anti-aliasing in SVG thumbnails after upgrade of scaling servers.

I've install a Debian Jessie from netinstall on a local virtual machine and added Wikimedia repositories for backport: https://wikitech.wikimedia.org/wiki/APT_repository

Jul 15 2016, 9:43 AM · Patch-For-Review, SRE-swift-storage, Commons, SRE
Menner added a comment to T139543: Some fonts not anti-aliasing in SVG thumbnails after upgrade of scaling servers.

From outside it is difficult to estimate when fallback fonts are use. Maybe this is something to look at since fallback fonts seem to be affected only: https://wiki.archlinux.org/index.php/Font_configuration#EmbeddedBitmap

Jul 15 2016, 8:00 AM · Patch-For-Review, SRE-swift-storage, Commons, SRE
Menner added a comment to T139543: Some fonts not anti-aliasing in SVG thumbnails after upgrade of scaling servers.

Besides Pango the library Harfbuzz is mention in the librsvg bugreport on Gnome, too.

Jul 15 2016, 6:44 AM · Patch-For-Review, SRE-swift-storage, Commons, SRE

Jul 11 2016

Menner added a comment to T120746: Improve SVG rendering.

It's heuristic to identify important tasks. One topic is minimize issues with fonts since their handling is diffcult even in a world without bugs. Another source are the archives of graphics village pump on Wikimedia. The last critiria is thinking about what issue would annoy beginners most.

Jul 11 2016, 6:19 PM · Wikimedia-SVG-rendering, Wikimania-Hackathon-2016, Community-Wishlist-Survey-2015

Jul 9 2016

Menner added a comment to T139543: Some fonts not anti-aliasing in SVG thumbnails after upgrade of scaling servers.

@MoritzMuehlenhoff: Please consider remarks about Pango in T40010 as well. To me they sound more plausible.

Jul 9 2016, 4:02 PM · Patch-For-Review, SRE-swift-storage, Commons, SRE

Jul 7 2016

Menner added a comment to T139543: Some fonts not anti-aliasing in SVG thumbnails after upgrade of scaling servers.

Please keep in mind that Linux implements font-substitution and has many fonts not installed. There is a fc-list, but not sure if it is valid now. Font-substitution is configuration dependant.

Jul 7 2016, 8:39 PM · Patch-For-Review, SRE-swift-storage, Commons, SRE
Menner added a comment to T117530: SVG marker-mid with orient auto don't work (stops rendering subsequent elements).

@MoritzMuehlenhoff: Look at the file history both have work arounds applied. You may test old version on

Jul 7 2016, 4:31 PM · SRE, Wikimedia-SVG-rendering

Jul 6 2016

Menner added a comment to T65703: Incorrect text positioning in SVG rasterization (any extreme down scale) (fixed in upstream 2.40.13).

Please be patient and see T112421 in the meantime.

Jul 6 2016, 8:13 PM · SRE, Upstream, Wikimedia-SVG-rendering
Menner added a comment to T112421: Update rsvg on the image scalers to 2.40.16 (to solve several SVG rendering issues).

Ping @MoritzMuehlenhoff : Noticed my last comment?

Jul 6 2016, 5:08 PM · User-notice-archive, SRE-swift-storage, Commons, SRE

Jul 4 2016

Menner added a comment to T112421: Update rsvg on the image scalers to 2.40.16 (to solve several SVG rendering issues).

&action=purge produces random results. Once with showing known bugs and the other time without. Try out on:
File:Rsvg_marker_element_bug.svg

Jul 4 2016, 7:46 PM · User-notice-archive, SRE-swift-storage, Commons, SRE
Menner added a comment to T97758: SVG rendering with marker-element is different between librsvg and Inkscape.

@Tgr: be patient. Now [[File:Rsvg marker element bug.svg]] is borken again too. Although it work fine recently.

Jul 4 2016, 7:35 PM · SRE, Upstream, Wikimedia-SVG-rendering

Jun 20 2016

Menner added a comment to T112421: Update rsvg on the image scalers to 2.40.16 (to solve several SVG rendering issues).

Recent Debain has librsvg 2.40.16 ready for backport too. https://packages.debian.org/source/stretch/librsvg

Jun 20 2016, 6:28 PM · User-notice-archive, SRE-swift-storage, Commons, SRE
Menner added a comment to T137876: Frequent segfaults of rsvg-convert on image scalers.

I suspect this is not a recent issue and has always been present.

Jun 20 2016, 6:26 PM · SRE

Jun 18 2016

Menner added a comment to T112421: Update rsvg on the image scalers to 2.40.16 (to solve several SVG rendering issues).

Regression from 2.40.11 has been fixed in recent 2.40.16. I've compiled it on Ubuntu 14.04 and I've seen no issues on a short test.

Jun 18 2016, 8:38 AM · User-notice-archive, SRE-swift-storage, Commons, SRE

May 31 2016

Menner added a comment to T40010: RFC: Re-evaluate librsvg as SVG renderer on Wikimedia wikis.

Evaluating a SVG renderer is not a simple task. You need to consider all kind of side effects and find the real needs. I recommend to use this task to find out which are the metrics for such an evaluation.

May 31 2016, 6:10 PM · Proposal, Thumbor, MediaWiki-File-management, Commons, Wikimedia-SVG-rendering

May 30 2016

Menner added a comment to T120746: Improve SVG rendering.

T40010 is a request for evaluation. Since there hasn't been a evaluation between available options I wouldn't call it a blocker. In fact T40010 is a subset of this Task. Improving rendering may lead to evaluate alternative options.

May 30 2016, 5:48 PM · Wikimedia-SVG-rendering, Wikimania-Hackathon-2016, Community-Wishlist-Survey-2015
Menner updated the task description for T40010: RFC: Re-evaluate librsvg as SVG renderer on Wikimedia wikis.
May 30 2016, 5:40 PM · Proposal, Thumbor, MediaWiki-File-management, Commons, Wikimedia-SVG-rendering
Menner updated the task description for T120746: Improve SVG rendering.
May 30 2016, 5:39 PM · Wikimedia-SVG-rendering, Wikimania-Hackathon-2016, Community-Wishlist-Survey-2015

Jan 1 2016

Menner added a comment to T117530: SVG marker-mid with orient auto don't work (stops rendering subsequent elements).

Looks okay with my local build from main/latest of librsvg plus bugfix for a new bug. Marker code has been rewritten recently. But I still get a Null pointer assertion from GTK.

Jan 1 2016, 9:47 PM · SRE, Wikimedia-SVG-rendering

Nov 19 2015

Menner added a comment to T2738: Ability to watch section levels of pages.

The diff algorithm does already evaluate context information[1]. Why not collection context information about sections while creating a diff. It is not uncommon as gnu pages say[2]. In a second step this information can be used by the watchlist code to evaluated observed section. At best give the whole section context like: == H1 === H2 ==== H3

Nov 19 2015, 7:00 PM · Growth-Team-Filtering, Growth-Team, Community-Wishlist-Survey-2016, Community-Wishlist-Survey-2015, German-Community-Wishlist, Epic, MediaWiki-Watchlist

Nov 6 2015

Menner merged task T116824: SVG server-side rendering renders some arrowheads backwards. into T97758: SVG rendering with marker-element is different between librsvg and Inkscape.
Nov 6 2015, 12:14 PM · Wikimedia-SVG-rendering
Menner updated subscribers of T97758: SVG rendering with marker-element is different between librsvg and Inkscape.
Nov 6 2015, 12:14 PM · SRE, Upstream, Wikimedia-SVG-rendering
Menner added a comment to T116824: SVG server-side rendering renders some arrowheads backwards. .

T97758 sounds identical. If I don't forget it I'll double check this later as it has been fixed upstream.

Nov 6 2015, 8:32 AM · Wikimedia-SVG-rendering

Oct 17 2015

Menner removed a project from T46016: SVG fails to render properly due to several issues: Upstream.
Oct 17 2015, 10:33 AM · Thumbor, Upstream, Wikimedia-SVG-rendering
Menner added a comment to T46016: SVG fails to render properly due to several issues.

Oh, I think not but at least partly. Need to try out this, but won't have time until 31. October.

Oct 17 2015, 10:32 AM · Thumbor, Upstream, Wikimedia-SVG-rendering
Menner updated the task description for T65236: Han characters in SVG files misplaced and clustered.
Oct 17 2015, 7:12 AM · Vertical-Writing, Upstream, Chinese-Sites, I18n, Wikimedia-SVG-rendering
Menner added a comment to T65236: Han characters in SVG files misplaced and clustered.

Partly addressed by https://bugzilla.gnome.org/show_bug.cgi?id=664533

Oct 17 2015, 7:12 AM · Vertical-Writing, Upstream, Chinese-Sites, I18n, Wikimedia-SVG-rendering
Menner added a project to T46016: SVG fails to render properly due to several issues: Upstream.
Oct 17 2015, 6:36 AM · Thumbor, Upstream, Wikimedia-SVG-rendering
Menner added a comment to T46016: SVG fails to render properly due to several issues.

Fix included in version 2.40.10 which got released yet. Now need to backport or need to wait for the distribution used on Wikimedia servers to provide that version....

Oct 17 2015, 6:35 AM · Thumbor, Upstream, Wikimedia-SVG-rendering

Oct 15 2015

Menner updated the task description for T55899: SVG masks (opacity gradient / transparency) fail to render (or even display).
Oct 15 2015, 5:03 PM · Thumbor, Upstream, Wikimedia-SVG-rendering
Menner updated the task description for T55899: SVG masks (opacity gradient / transparency) fail to render (or even display).
Oct 15 2015, 5:02 PM · Thumbor, Upstream, Wikimedia-SVG-rendering

Sep 14 2015

Menner added a subtask for T44090: Filter effect Gaussian blur filter not rendered correctly for small to medium thumbnail sizes: T112421: Update rsvg on the image scalers to 2.40.16 (to solve several SVG rendering issues).
Sep 14 2015, 6:39 AM · SRE, Upstream, Wikimedia-SVG-rendering
Menner added a parent task for T112421: Update rsvg on the image scalers to 2.40.16 (to solve several SVG rendering issues): T44090: Filter effect Gaussian blur filter not rendered correctly for small to medium thumbnail sizes.
Sep 14 2015, 6:39 AM · User-notice-archive, SRE-swift-storage, Commons, SRE
Menner added a subtask for T64987: librsvg misinterpret quoted font family names that contain whitespaces: T112421: Update rsvg on the image scalers to 2.40.16 (to solve several SVG rendering issues).
Sep 14 2015, 6:37 AM · Thumbor, SRE, Upstream, Wikimedia-SVG-rendering
Menner added a parent task for T112421: Update rsvg on the image scalers to 2.40.16 (to solve several SVG rendering issues): T64987: librsvg misinterpret quoted font family names that contain whitespaces.
Sep 14 2015, 6:37 AM · User-notice-archive, SRE-swift-storage, Commons, SRE

Jun 20 2015

Menner added a comment to T51061: Lines missing in thumbnail of SVG diagram.

I cannot reproduce this with librsvg 2.36.4 or 2.40.9 but only on Wikipedia or https://tools.wmflabs.org/svgcheck/index.php with librsvg 2.36.1.

Jun 20 2015, 6:34 AM · Wikimedia-SVG-rendering
Menner added a comment to T51061: Lines missing in thumbnail of SVG diagram.

The original link to the broken SVG has been deleted.

Jun 20 2015, 6:28 AM · Wikimedia-SVG-rendering

Jun 19 2015

Menner added a comment to T37657: SVG: part of the image not rendered for large resolutions.

What is the max size limit?

Jun 19 2015, 5:56 PM · Wikimedia-SVG-rendering
Menner added a comment to T29525: SVG2PNG image has some parts shifted thus the image is wrong.

Is this really a bug of SVG rendering. Consider SVG is not a WYSIWYG tool. Used space by letters depends on font rendering. Wikimedia uses font hinting which results in rounding letter position to pixel scale.

Jun 19 2015, 5:31 PM · Wikimedia-SVG-rendering

May 29 2015

Menner added a project to T65703: Incorrect text positioning in SVG rasterization (any extreme down scale) (fixed in upstream 2.40.13): Upstream.
May 29 2015, 6:29 PM · SRE, Upstream, Wikimedia-SVG-rendering
Menner added a project to T64987: librsvg misinterpret quoted font family names that contain whitespaces: Upstream.
May 29 2015, 6:28 PM · Thumbor, SRE, Upstream, Wikimedia-SVG-rendering

May 15 2015

Menner updated the task description for T64987: librsvg misinterpret quoted font family names that contain whitespaces.
May 15 2015, 9:07 AM · Thumbor, SRE, Upstream, Wikimedia-SVG-rendering

May 9 2015

Perhelion awarded T97758: SVG rendering with marker-element is different between librsvg and Inkscape a Like token.
May 9 2015, 4:35 PM · SRE, Upstream, Wikimedia-SVG-rendering

May 8 2015

Menner added a comment to T70856: "ArialMT" as a synonym of "Arial".

Close this bug.

May 8 2015, 11:21 PM · Wikimedia-SVG-rendering
Menner added a comment to T91704: Prepare presentation on Wikimedia SVG usage for The Graphical Web 2015 conf.

Sounds like there is an evaluation to remove librsvg and replace it by browser side rastering of SVG? Please inform me if there is a schedule because I plan to fix some bugs of librsvg but on the other hand I could save my time for other tasks.

May 8 2015, 10:53 PM · Wikimedia-SVG-rendering
Menner added a comment to T65703: Incorrect text positioning in SVG rasterization (any extreme down scale) (fixed in upstream 2.40.13).

The result to text elements is equal to multiplying font-size with scaling of previous path elements which leads to font hinting and upscaling text again to the intended font-size.

May 8 2015, 10:14 PM · SRE, Upstream, Wikimedia-SVG-rendering

May 7 2015

Menner added a comment to T65703: Incorrect text positioning in SVG rasterization (any extreme down scale) (fixed in upstream 2.40.13).

This bug at gnome shows also an issue with a matrix element: https://bugzilla.gnome.org/show_bug.cgi?id=634324

May 7 2015, 10:31 PM · SRE, Upstream, Wikimedia-SVG-rendering
Menner added a comment to T65703: Incorrect text positioning in SVG rasterization (any extreme down scale) (fixed in upstream 2.40.13).

I can clearly reproduce when the reported issue takes place. It like comes from the two path elements between the two text elements containing main body. I suspect a wild pointer problem in the matrix attribute.

May 7 2015, 10:12 PM · SRE, Upstream, Wikimedia-SVG-rendering
Menner added a comment to T19845: DejaVu Sans font renders incorrectly in SVG thumbnails.

Forget this I misunderstood the initial description

May 7 2015, 8:52 PM · Wikimedia-SVG-rendering
Menner added a comment to T43424: flowRoot (defined only in deprecated SVG 1.2 draft) not supported by rsvg.

Remark: In SVG2 there will be a attribute called extend. It defines the width of a textline and support a similar feature.
see https://svgwg.org/svg2-draft/text.html#TextLayoutContentArea

May 7 2015, 4:40 PM · Upstream, Wikimedia-SVG-rendering
Menner added a member for Wikimedia-SVG-rendering: Menner.
May 7 2015, 4:12 PM

May 1 2015

Menner added a project to T97758: SVG rendering with marker-element is different between librsvg and Inkscape: Upstream.
May 1 2015, 5:43 PM · SRE, Upstream, Wikimedia-SVG-rendering
Menner added a comment to T97758: SVG rendering with marker-element is different between librsvg and Inkscape.

These libRSVG bugs are that simple to fix. I've patched it myself instead of pressuring someone and explaining me. See bugzilla above.

May 1 2015, 5:41 PM · SRE, Upstream, Wikimedia-SVG-rendering
Menner renamed T97758: SVG rendering with marker-element is different between librsvg and Inkscape from SVG rendering with marker-element different between librsvg and Inkscape to SVG rendering with marker-element is different between librsvg and Inkscape.
May 1 2015, 12:02 PM · SRE, Upstream, Wikimedia-SVG-rendering
Menner created T97758: SVG rendering with marker-element is different between librsvg and Inkscape.
May 1 2015, 12:02 PM · SRE, Upstream, Wikimedia-SVG-rendering

Apr 25 2015

Menner updated the task description for T36947: Incorrect text positioning in SVG rasterization (scale/transform; font-size; kerning).
Apr 25 2015, 8:01 AM · Upstream, Thumbor, Wikimedia-SVG-rendering

Apr 18 2015

Menner added a comment to T7792: rsvg does not render baseline-shift correctly (<percentage> and <length>).

See attachements of https://bugzilla.gnome.org/show_bug.cgi?id=340047#c3 on Gnome Bugzilla

Apr 18 2015, 10:53 AM · Thumbor, Upstream, Wikimedia-SVG-rendering
Menner added a comment to T7792: rsvg does not render baseline-shift correctly (<percentage> and <length>).

I've created a patch adding support for baseline-shift properties "sub/super/baseline". This would fix the issue as this are the important types of baseline shift.
(PS see gnome bugzilla for details. Its not in added to libRsvg yet)

Apr 18 2015, 9:06 AM · Thumbor, Upstream, Wikimedia-SVG-rendering

Jan 30 2015

Menner added a comment to T40010: RFC: Re-evaluate librsvg as SVG renderer on Wikimedia wikis.

This test suit is a good starting point to evaluate the quality of a SVG rasterer. One can easily write a small shell script to execute comparisons between different solutions.

Jan 30 2015, 7:35 PM · Proposal, Thumbor, MediaWiki-File-management, Commons, Wikimedia-SVG-rendering

Jan 18 2015

Menner added a comment to T40010: RFC: Re-evaluate librsvg as SVG renderer on Wikimedia wikis.

There had been an effort to support development of libRSVG which obviously fell asleep.
http://strategy.wikimedia.org/wiki/Proposal:Librsvg_development_funding

Jan 18 2015, 9:39 AM · Proposal, Thumbor, MediaWiki-File-management, Commons, Wikimedia-SVG-rendering
Menner added a comment to T5593: [Epic] SVG client side rendering.

I see unresolved security issues since SVG may contain JS script and references to external webpages. There must be some sort of filter for that kind of stuff otherwise it is a huge entry point for hackers.

Jan 18 2015, 9:24 AM · Community-Wishlist-Survey-2023, Epic, Wikimedia-SVG-rendering, Commons, Multimedia, Accessibility, MediaWiki-File-management