| • JKatzWMF | |
| Apr 15 2015, 5:51 PM |
| F152768: search-page-03.png | |
| Apr 27 2015, 7:14 PM |
| F152761: search-js-03.png | |
| Apr 27 2015, 7:14 PM |
| F157818: search-page-03.png | |
| Apr 27 2015, 7:00 PM |
| F157815: search-js-03.png | |
| Apr 27 2015, 6:59 PM |
Acceptance criteria
Tapping the search icon opens the js menu
No back button needed on the js menu
Same animation as menu in stable
Tapping search opens search as usual
Search background opaque white, not transparent as menu in stable
Design
Menu
Search
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • bmansurov | T96172 On alpha, clicking header launches hamburger menu and search without forcing a page load | |||
| Resolved | • bmansurov | T95332 Stop serving menu and styles in the page HTML | |||
| Resolved | Jdlrobson | T97431 Render main menu via a template |
Change 207005 had a related patch set uploaded (by Bmansurov):
Alpha: Show the main menu without a page reload when JavaScript is enabled
@Jdlrobson there are some patches of yours that are blocking this; can you let us know the status of these?
There seems to be some cross team communication issues here...
I added the blocking patch T95332 as a suggestion since it would make doing this a lot easier. It can be removed if @phuedx @bmansurov are keen to keep doing it this way. My patches for those cards just need someone to review and merge them.
I -1ed as there were issues in the patch... @bmansurov just needs to fix those on his end.
@Jdlrobson, I've reviewed your patch. Since your patches are close to be merged, I'll work on my patch after yours have been merged. This will allow you not to re-write your patches after mine gets merged before yours. Also, this will allow me not to re-write mine in case your patches get merged first.
There seems to be some cross team communication issues here...
Agreed. Given that we use the "Blocked By" and "Blocks" Phab features to actually mean "this is blocked by" and "this blocks" I suggest that we use comments to track suggestions.
Regardless, we could have ironed this out earlier had I followed up on this sooner.
@Jdlrobson, @bmansurov: Just how close are the dependent patches to being merged?
Change 207005 merged by jenkins-bot:
Alpha: Show the main menu without a page reload when JavaScript is enabled
@phuedx, to answer your question. It was very close at the time, just minor edits were needed.
@KHammerstein bump to you for signoff, if possible would like to get signed off ASAP, as our sprint officially ends in 1 hour ;-)