Page MenuHomePhabricator

Remove AjaxDispatcher use from Collection
Closed, ResolvedPublic

Description

Still being used as of 2015:
https://github.com/wikimedia/mediawiki-extensions-Collection/blob/110e53d9/Collection.php#L259

This has been deprecated for many years now.

This has many problems including making translation impossible.

Event Timeline

Krinkle raised the priority of this task from to High.
Krinkle updated the task description. (Show Details)
Krinkle added a subscriber: Aklapper.
cscott subscribed.

I'm adopting Krenair's patch to split it apart, get it reviewed, and push it over the finish line.

Change 183228 had a related patch set uploaded (by Cscott):
T94005: Clean up JS and change action=ajax stuff into API modules

https://gerrit.wikimedia.org/r/183228

Krenair renamed this task from Remove AjaxDispatcher from Collection to Remove AjaxDispatcher use from Collection.May 20 2015, 2:01 PM
Krenair set Security to None.

Change 183228 had a related patch set uploaded (by Reedy):
[WIP] Clean up JS and change action=ajax stuff into API modules

https://gerrit.wikimedia.org/r/183228

Change 183228 abandoned by Alex Monk:
[WIP] Clean up JS and change action=ajax stuff into API modules

https://gerrit.wikimedia.org/r/183228

Change 183228 restored by Alex Monk:
[WIP] Clean up JS and change action=ajax stuff into API modules

Reason:
There were problems I was running into due to some mistakes while rebasing, and I gave up for a while. I'll look into fixing it later

https://gerrit.wikimedia.org/r/183228

@Jdlrobson: Is Watching really the right place for this since you're trying to get the change merged?

Also, y'know, good luck!

@bmansurov @pmiazga and I have agreed to focus on the rendering code and drop work on this since it doesn't help our cause so this patch is probably as far as it will go now sadly unless @cscott or someone else has bandwidth to help. We will watch it until that happens. There is a lot of work here to be done.

Removing task assignee due to inactivity, as this open task has been assigned to the same person for more than two years (see the emails sent to the task assignee on Oct27 and Nov23). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.
(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)

Change 730621 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/extensions/Collection@master] Replace old ajax interface & use new api modules in client code

https://gerrit.wikimedia.org/r/730621

xSavitar changed the task status from Open to In Progress.Oct 27 2021, 10:44 AM
xSavitar assigned this task to DAlangi_WMF.

Change 730621 merged by jenkins-bot:

[mediawiki/extensions/Collection@master] Replace old ajax interface & use new api modules in client code

https://gerrit.wikimedia.org/r/730621

Change 183228 abandoned by Jdlrobson:

[mediawiki/extensions/Collection@master] Clean up JS and change action=ajax stuff into API modules

Reason:

I don't remember, but given its age, I think we can just abandon this.

https://gerrit.wikimedia.org/r/183228