Page MenuHomePhabricator
Create Task
Maniphest T92991

Use jquery.spinner instead of injectSpinner/removeSpinner in CodeReview
Closed, ResolvedPublic
Actions

Description

The extension is using deprecated code:

Details

SubjectRepoBranchLines /-
Replace injectSpinner/removeSpinner with jquery.spinnermediawiki/extensions/CodeReviewmaster 5 -4
Customize query in gerrit

Event Timeline

He7d3r created this task.Mar 17 2015, 7:11 PM
He7d3r raised the priority of this task from to Needs Triage.
He7d3r updated the task description. (Show Details)
He7d3r added projects: MediaWiki-extensions-CodeReview, JavaScript, good first task.
He7d3r subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2015, 7:11 PM
Aklapper triaged this task as Lowest priority.Mar 18 2015, 11:15 AM
Aklapper added a project: Technical-Debt.
Aklapper set Security to None.
He7d3r renamed this task from Do not use injectSpinner/removeSpinner in CodeReview to Use jquery.spinner instead of injectSpinner/removeSpinner in CodeReview.Jun 24 2015, 3:24 PM
• matmarex added a project: Google-Code-In-2015.Oct 27 2015, 9:51 PM
• matmarex subscribed.

I'm going to propose (and mentor) this as a task for Google-Code-In-2015.

gerritbot subscribed.Nov 19 2015, 7:17 PM

Change 254177 had a related patch set uploaded (by Paladox):
Replace injectSpinner/removeSpinner with jquery.spinner

https://gerrit.wikimedia.org/r/254177

gerritbot added a project: Patch-For-Review.Nov 19 2015, 7:17 PM
gerritbot added a comment.Dec 4 2015, 2:07 PM

Change 254177 merged by jenkins-bot:
Replace injectSpinner/removeSpinner with jquery.spinner

https://gerrit.wikimedia.org/r/254177

• matmarex assigned this task to Paladox.Dec 4 2015, 2:08 PM
• matmarex removed projects: Patch-For-Review, Google-Code-In-2015.
ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)).Dec 4 2015, 3:00 PM
Paladox added a comment.Dec 4 2015, 3:12 PM

Should this be closed as resolved since patch was merged.

• matmarex closed this task as Resolved.Dec 7 2015, 12:00 AM

Whoops, yes, I forgot to do that.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits