Page MenuHomePhabricator
Create Task
Maniphest T89384

Add error id generation to mw.errorLogging
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

To make it easy for users to report errors / developers to know which error is being reported, we should show the user an error id so they include it in the bug report.

  • generate an id from the error when it is caught (Sentry just created a random UUID so we should go with that)
  • log it to the console for automatically caught exceptions
  • for manually caught exceptions, provide a method in mw.errorLogging by which developers can send the exception to Sentry and get back an error id. While the reporting itself is async, return the error id should not be.

This will also help with tracking down whether Sentry properly collects all errors.

Details

SubjectRepoBranchLines /-
[HOLD] Log error id to consolemediawiki/extensions/Sentrymaster 20 -0
mediawiki.errorLogger: Add error id and manual reportingmediawiki/coremaster 99 -9
Add error id and manual reporting to mw.errorLoggingmediawiki/coremaster 68 -2
Test module for manual error reportingmediawiki/extensions/Buggymaster 33 -24
Report error id and contextmediawiki/extensions/Sentrymaster 77 -7
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclinedNoneT382 RfC: Server-side Javascript error logging
 ResolvedTgrT524 Interface to display JS error logs
 Resolved• GillesT525 Review existing JS error logging solutions
 DeclinedNoneT106913 Use Sentry on non-production Wikimedia wikis, Toolforge and other sites/tools
 DeclinedNoneT106915 Use Sentry in production
 DeclinedTgrT91649 Deploy Sentry (JavaScript error logging) to production, configured to log only a limited subset of users/pages
 ResolvedTgrT1345 Set up and test Sentry on Labs for JS error logging
 ResolvedTgrT89384 Add error id generation to mw.errorLogging
 ResolvedTgrT105374 Investigate if the XSS vulnerability addressed in Sentry 7.6.1 affects us
 Resolved• jlinehanT88399 Improve Javascript error logging coverage
 ResolvedTgrT78809 Implement module wrapping for Sentry
 DeclinedTgrT85262 Add startup script to automatically wrap asynchronous functions in try..catch
 DeclinedTgrT86058 Find out whether any browser supported by MediaWiki needs TraceKit's "rethrow to window.onerror" logic for stack traces
 DeclinedTgrT92247 Wrap jQuery AJAX callbacks in try..catch via mw.errorLogging
 ResolvedTgrT92701 Test the impact of Javascript error logging on performance
 DeclinedTgrT93392 Make sure async wrapping for Javascript error logging only happens when the call is truly async
 ResolvedTgrT85263 Track module initialization errors in ResourceLoader
 ResolvedTgrT88874 Catch uncaught exceptions with Sentry
 ResolvedKrinkleT93986 mw.track subscribers cannot unsubscribe
 DeclinedNoneT90524 Use source urls in mw.loader.store
 OpenNoneT508 Use CORS-enabled fetch of scripts to avoid same-domain limitations in JS error logging
 ResolvedTgrT507 Measure how many users have CORS-hostile proxies
 DeclinedNoneT88078 Automated tests for Javascript error logging
 DeclinedNoneT526 Add sampling and throttling support to JS error logging
 InvalidNoneT89732 Investigate production and/or beta requirements for Sentry
 DeclinedTgrT93138 Procure hardware for Sentry
 ResolvedTgrT84956 Create basic puppet role for Sentry
 Resolved• jcrespoT112228 Need to run postgresql::user twice to set the password
 ResolvedTgrT94428 Log Javascript errors in UploadWizard funnel flow

Event Timeline

Tgr created this task.Feb 12 2015, 8:40 PM
Tgr claimed this task.
Tgr raised the priority of this task from to Needs Triage.
Tgr updated the task description. (Show Details)
Tgr added projects: Sentry, JavaScript.
Tgr subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptFeb 12 2015, 8:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr added a subtask: T1345: Set up and test Sentry on Labs for JS error logging.Feb 12 2015, 8:40 PM
Tgr removed a subtask: T1345: Set up and test Sentry on Labs for JS error logging.
Tgr added a parent task: T1345: Set up and test Sentry on Labs for JS error logging.
Tgr moved this task from Untriaged to Next up on the Multimedia board.Feb 12 2015, 9:06 PM
Tgr added a project: Multimedia-Sprint-2015-02-18.Feb 18 2015, 1:08 AM
Tgr set Security to None.
Tgr edited a custom field.
gerritbot subscribed.Feb 24 2015, 9:23 PM

Change 192695 had a related patch set uploaded (by Gergő Tisza):
Add error id and manual reporting to mw.errorLogging

https://gerrit.wikimedia.org/r/192695

gerritbot added a project: Patch-For-Review.Feb 24 2015, 9:23 PM

Change 192696 had a related patch set uploaded (by Gergő Tisza):
Test module for manual error reporting

https://gerrit.wikimedia.org/r/192696

gerritbot added a comment.Feb 24 2015, 9:24 PM

Change 192697 had a related patch set uploaded (by Gergő Tisza):
Report error id and context

https://gerrit.wikimedia.org/r/192697

Tgr moved this task from Backlog to Needs code review on the Multimedia-Sprint-2015-02-18 board.Feb 24 2015, 9:43 PM
Tgr edited a custom field.
gerritbot added a comment.Feb 25 2015, 8:48 AM

Change 192697 merged by jenkins-bot:
Report error id and context

https://gerrit.wikimedia.org/r/192697

• Gilles moved this task from Needs code review to Ready for testing on the Multimedia-Sprint-2015-02-18 board.Feb 25 2015, 8:50 AM
• Gilles added a project: Multimedia-Sprint-2015-02-25.Feb 25 2015, 10:56 AM
• Gilles moved this task from Backlog to Ready for testing on the Multimedia-Sprint-2015-02-25 board.
• Gilles subscribed.
• Gilles removed a project: Multimedia-Sprint-2015-02-18.Feb 25 2015, 8:54 PM
Liuxinyu970226 subscribed.Feb 26 2015, 3:01 AM
• Gilles closed this task as Resolved.Mar 2 2015, 9:17 AM

Soft-depends on https://gerrit.wikimedia.org/r/#/c/192695/

Liuxinyu970226 unsubscribed.Mar 2 2015, 11:30 PM
Jdforrester-WMF removed a project: Patch-For-Review.Mar 3 2015, 5:27 PM
Tgr mentioned this in rMEXT7dbcaa9e0351: Updated mediawiki/extensions Project: mediawiki/extensions/Sentry….Mar 11 2015, 6:27 AM
gerritbot added a comment.Mar 25 2015, 3:11 AM

Change 192696 merged by jenkins-bot:
Test module for manual error reporting

https://gerrit.wikimedia.org/r/192696

Tgr mentioned this in rMEXT50b38fa08aa9: Updated mediawiki/extensions Project: mediawiki/extensions/Buggy….Mar 25 2015, 3:12 AM
gerritbot added a comment.Mar 25 2015, 10:47 PM

Change 192695 abandoned by Gergő Tisza:
Add error id and manual reporting to mw.errorLogging

Reason:
Will be redone on top of https://gerrit.wikimedia.org/r/#/c/199557/

https://gerrit.wikimedia.org/r/192695

gerritbot added a comment.Mar 25 2015, 11:30 PM

Change 199789 had a related patch set uploaded (by Gergő Tisza):
Add error id and manual reporting to mw.errorLogging

https://gerrit.wikimedia.org/r/199789

gerritbot added a project: Patch-For-Review.Mar 25 2015, 11:30 PM
gerritbot added a comment.Mar 28 2015, 9:02 AM

Change 200293 had a related patch set uploaded (by Gergő Tisza):
[HOLD] Log error id to console

https://gerrit.wikimedia.org/r/200293

Tgr mentioned this in rEBUGf06596eaa6b9: Test module for manual error reporting.Apr 8 2015, 6:13 PM
Tgr mentioned this in rESNTa6ea4d57ae0f: Report error id and context.Apr 8 2015, 6:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits