FlaggablePageView.php should use CSS instead of obsolete HTML attributes such as "align", "border", "width", "cellpadding" and "cellspacing".
Description
Description
Details
Details
| Subject | Repo | Branch | Lines /- | |
|---|---|---|---|---|
| Replace obsolete HTML attributes with CSS. | mediawiki/extensions/FlaggedRevs | master | 14 -14 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 266047 had a related patch set uploaded (by IoannisKydonis):
Replace obsolete HTML attributes with CSS.
Comment Actions
Change 266047 abandoned by Thiemo Kreuz (WMDE):
[mediawiki/extensions/FlaggedRevs@master] Replace obsolete HTML attributes with CSS.
Reason:
Sorry, but all this patch does is replacing one style with another one, without actually improving the situation. The issue is not really which syntax is used. The old one works just fine. Browsers will never stop supporting it. The issue is that this stuff is hard-coded in the middle of the HTML.
Comment Actions
Removing Patch-Needs-Improvement since the patch was abandoned and good first task since it isn't one, the styles need to be moved to some RL module, not sure which or if it needs a new one, which does not meet "well-described with pointers to help an absolute newcomer".
Comment Actions
The attributes have been
- removed in rEFLR7e90ea4dd0fcd3a991411235acd950f636d25389;
- replaced with inline CSS in rEFLR744832cc5ed51796186bf3b4f9906595cffe48b7 and rEFLR62233b000156e60f9fa0793c89adf9d27fda7d29 (long before @thiemowmde abandoned the patch in T86578#6415477 for switching to inline CSS instead of using stylesheets).
Should we
- close this task as resolved, given that the HTML attributes have been removed,
- or re-scope it to ask for migration to stylesheets?
Comment Actions
I'll close. Eyeballing the extension seems to indicate there is some HTML modernization to be done given the wide use of tables as well. One of which is for the diff view (which in core uses divs and CSS grid these days), and at least one other table use looks like it's presentational. A separate task identifying those issues seems more apropos.