Page MenuHomePhabricator
Create Task
Maniphest T86058

Find out whether any browser supported by MediaWiki needs TraceKit's "rethrow to window.onerror" logic for stack traces
Closed, DeclinedPublic
Actions

Description

[[ https://github.com/getsentry/raven-js/blob/master/vendor/TraceKit/tracekit.js#L38 | TraceKit.report() ]] contains logic that re-throws the exception and catches it via window.onerror; supposedly, this improves error reporting in some IE version, but they don't mention which. This logic might be problematic for ResourceLoader integration; find out whether it's actually needed for any IE version supported by MediaWiki.

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclinedNoneT106913 Use Sentry on non-production Wikimedia wikis, Toolforge and other sites/tools
 DeclinedNoneT106915 Use Sentry in production
 DeclinedTgrT91649 Deploy Sentry (JavaScript error logging) to production, configured to log only a limited subset of users/pages
 Resolved• jlinehanT88399 Improve Javascript error logging coverage
 DeclinedNoneT382 RfC: Server-side Javascript error logging
 DeclinedNoneT513 Wrap scripts with exception handling for automatic JS error logging
 ResolvedTgrT524 Interface to display JS error logs
 Resolved• GillesT525 Review existing JS error logging solutions
 ResolvedTgrT1345 Set up and test Sentry on Labs for JS error logging
 ResolvedTgrT78807 Deploy Sentry extension on beta cluster
 Resolved• csteippT86677 Quick/short security review of Extension:Sentry
 ResolvedTgrT78809 Implement module wrapping for Sentry
 DeclinedTgrT85262 Add startup script to automatically wrap asynchronous functions in try..catch
 DeclinedTgrT86058 Find out whether any browser supported by MediaWiki needs TraceKit's "rethrow to window.onerror" logic for stack traces
 ResolvedTgrT85263 Track module initialization errors in ResourceLoader
 ResolvedTgrT84957 Vagrantize Sentry
 ResolvedTgrT90773 Fix log directory permissions in Sentry vagrant role
 ResolvedTgrT84956 Create basic puppet role for Sentry
 Resolved• jcrespoT112228 Need to run postgresql::user twice to set the password
 ResolvedAklapperT84955 Create MediaWiki-extensions-Sentry project
 ResolvedTgrT89384 Add error id generation to mw.errorLogging
 ResolvedTgrT105374 Investigate if the XSS vulnerability addressed in Sentry 7.6.1 affects us

Event Timeline

Tgr created this task.Jan 7 2015, 8:32 PM
Tgr claimed this task.
Tgr raised the priority of this task from to High.
Tgr updated the task description. (Show Details)
Tgr added projects: MediaWiki-ResourceLoader, Multimedia, Sentry.
Tgr added subscribers: Aklapper, Legoktm, Tgr, Krinkle.
Tgr lowered the priority of this task from High to Lowest.Apr 3 2015, 6:26 AM

Raven actually surpresses this behavior since it catches again the exception that TraceKit tries to rethrow. So no practical significance.

Tgr closed this task as Declined.Apr 3 2015, 6:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits