The search results here include files from Wikimedia Commons. This is kind of weird. It might be helpful if the Commons search results are of media that's actively used/referenced on the local wiki, but otherwise it's just kind of strange and unexpected to include a foreign wiki's search results alongside the local wiki's, especially without a clear opt-out mechanism.
See also: T94856: Please disable Commons search on OfficeWiki
We can now use "file:local:cat" for searching local files. See https://gerrit.wikimedia.org/r/#/c/204536/
Getting community consensus on foundationwiki sounds interesting. Who needs to approve this?
Well, Discovery owns search across all of our sites, and I'm the PM for Discovery, so why don't we say me? :-)
Change 234040 had a related patch set uploaded (by Deskana):
Remove files from Commons from search results on wikimediafoundation.org
Inserting images from Commons using VisualEditor seems to work just fine on officewiki, and officewiki already had this config change applied to it. Given that, I find it unlikely that this will affect VisualEditor on foundationwiki.
No, what VE does is look up the actual file repositories set up on the local wiki and searches each one separately, I don't think it relies on local search to include foreign file repository results.
Change 234040 merged by jenkins-bot:
Remove files from Commons from search results on wikimediafoundation.org
Oh, interesting. When? This probably explains the complete breakage of media inserting on officewiki we had to fix a few weeks ago…