Use the consistent gear icon from T52843 in Echo.
Description
Details
Subject | Repo | Branch | Lines /- | |
---|---|---|---|---|
Fixed preferences icons to be consistent and be svg. | mediawiki/extensions/Echo | master | 81 -10 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Open | None | T55733 Use the same icons to represent the same things (tracking) | |||
Resolved | • Catrope | T52843 Use consistent preferences icon | |||
Open | None | T113560 Standardize MediaWiki components (tracking) | |||
Resolved | Mlawnik | T76513 Use consistent preferences icon in Echo |
Event Timeline
This will have to be uploaded in Gerrit and Melange as well (code actually does not need to be uploaded here, just the other two places).
Tested it works, will clean up and upload patch tomorrow. Couldn't use background-image-svg as it caused duplication of icons.
Final effect:
I saw that Melange has a URL option. So you don't actually need to upload to there. Just add the Gerrit URL to Melange.
Can you explain this problem? What browser did you test in?
Final effect:
As noted in Melange and T52843: Use consistent preferences icon, there are two different gears. The other one is at Special:Notifications.
The background-image-svg mixin does not have the attributes specified for this icon, such as no-repeat, which causes something like this:
I will upload a full photo with correct icons in a moment. I was testing on chrome but had cache issues while editing. Screenshot taken in firefox, will take final screenshots in both browsers.
Also, removed Preferences.png in /modules/special. The iconsnow reside in /modules/icons as:
Settings.svg
Settings14px.png
Settings19px.png
Change 177269 had a related patch set uploaded (by Nemo bis):
Fixed preferences icons to be consistent and be svg.
Citing @Mooeypoo from PS 7
Code-Review-1
I am not sure this is the right thing to do anymore. We are migrating the system to oojs-ui which has its own icons (that are supported and designed by the UI standardization team) and these should be the consistent icons we use everywhere.
Change 177269 abandoned by Catrope:
Fixed preferences icons to be consistent and be svg.
Reason:
This has since been fixed, see e.g. 0271cdd52dcc3d2f51f67cca2e942e95b4c3c859