Hello @D3r1ck01, I took a look at https://www.mediawiki.org/wiki/Thread:Project:Support_desk/Odd_occurrence_when_viewing_Special:Version and the issue seems to have been fixed if I am not wrong. If this is the case I'll try to pick another featured task from our list.

Hi @samuelguebo

I've tested it and it's still current in MediaWiki 1.29-rc.0, but maybe not so easy to reproduce, because apparently it only attempts to check for the git bin when there are extensions installed downloaded directly from git. Special:ExtensionDistribution on mediawiki.org already include some git metadata files with all the information, and MediaWiki doesn't need to retrieve this information from git.

I'm going to update the task description with clear steps to reproduce.

In T74445#3403973, @Ciencia_Al_Poder wrote:

Hi @samuelguebo

I've tested it and it's still current in MediaWiki 1.29-rc.0, but maybe not so easy to reproduce, because apparently it only attempts to check for the git bin when there are extensions installed downloaded directly from git. Special:ExtensionDistribution on mediawiki.org already include some git metadata files with all the information, and MediaWiki doesn't need to retrieve this information from git.

I'm going to update the task description with clear steps to reproduce.

@samuelguebo, you now have the steps to reproduce, you can work on this right? Thanks @Ciencia_Al_Poder :)

Hello @D3r1ck01,

Indeed the description is more clear now. I will work on it. Thanks @Ciencia_Al_Poder

Sure, you may go on and work on it.

Le 20 janv. 2018 20:16, "rosalieper" <[email protected]> a
écrit :

rosalieper added a comment.

@samuelguebo https://phabricator.wikimedia.org/p/samuelguebo/ I wish to
work on this if you are no more on it. Thanks :)

*TASK DETAIL*
https://phabricator.wikimedia.org/T74445

*EMAIL PREFERENCES*
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

*To: *rosalieper
*Cc: *samuelguebo, D3r1ck01, TerraCodes, Ciencia_Al_Poder, Asad_Ali_Palijo,
JamieTubers, Lsherwinforone, Soteriaspace, RazeSoldier, Jayprakash12345,
JakeTheDeveloper, Eugene233, Ptolusque, Zoranzoki21, Sethakill, Zppix,
rosalieper, MuhammadShuaib, Wong128hk, Flixtey, SimmeD, Jdlrobson

Change 405725 had a related patch set uploaded (by Rosalieper; owner: Rosalieper):
[mediawiki/core@master] Version produces warning when checking for $wgGitBin

https://gerrit.wikimedia.org/r/405725

Le 20 janv. 2018 20:16, "rosalieper" <[email protected]> a
écrit :

@samuelguebo, maybe next time you can reply on the phab ticket itself to avoid email content (when replying via email) to be attached? Thanks :)

My bad, thanks @D3r1ck01 for notifying me.

Change 405725 abandoned by Rosalieper:
Version produces warning when checking for $wgGitBin

https://gerrit.wikimedia.org/r/405725

@rosalieper Are you still work it? If not, and if I can reproduce this error, I can work it.

@RazeSoldier You can go ahead

I follow step of the reproduce (except download an extension and load it step), only open_basedir set to MediaWiki install directory in LocalSettings.php, then my wiki was destroyed. I got two error messages:

1. Warning: is_dir(): open_basedir restriction in effect. File(/tmp) is not within the allowed path(s): (w/) in w/includes/libs/filebackend/fsfile/TempFSFile.php on line 90
2. Fatal error: Uncaught Error: Call to a member function getIP() on null in w/includes/user/User.php:2398 Stack trace: #0 w/includes/session/SessionBackend.php(712): User->getName() #1 w/includes/session/SessionBackend.php(596): MediaWiki\Session\SessionBackend->save() #2 [internal function]: MediaWiki\Session\SessionBackend->MediaWiki\Session\{closure}() #3 w/vendor/wikimedia/scoped-callback/src/ScopedCallback.php(76): call_user_func_array(Object(Closure), Array) #4 w/vendor/wikimedia/scoped-callback/src/ScopedCallback.php(56): Wikimedia\ScopedCallback->__destruct() #5 w/includes/session/SessionManager.php(886): Wikimedia\ScopedCallback::consume(NULL) #6 w/includes/session/SessionManager.php(310): MediaWiki\Session\SessionManager->getSessionFromInfo(Object(MediaWiki\Session\SessionInfo), Object(WebRequest)) #7 w/includes/session/SessionManager.php(244): MediaWiki\Session\SessionManager->getEmptySe in w/includes/user/User.php on line 2398

I am not sure this task describe these errors, they seem to affect the entire wiki, not just Special:Version.

In T74445#4020665, @RazeSoldier wrote:

I follow step of the reproduce (except download an extension and load it step), only open_basedir set to MediaWiki install directory in LocalSettings.php, then my wiki was destroyed. I got two error messages:

1. Warning: is_dir(): open_basedir restriction in effect. File(/tmp) is not within the allowed path(s): (w/) in w/includes/libs/filebackend/fsfile/TempFSFile.php on line 90

The temp directory should be inside the open_basedir allowed paths. Or try to define $wgTmpDirectory to a path withing the allowed paths.

I reproduce the error, but it looks like also caused when not load any extensions and skins.

Warning: is_file(): open_basedir restriction in effect. File(/usr/bin/git) is not within the allowed path(s): (/devmw/w:/tmp) in w/includes/GitInfo.php on line 228

I push a patch. https://gerrit.wikimedia.org/r/#/c/416234/

Can someone review this simple patch?

Change 416234 had a related patch set uploaded (by Aklapper; owner: 星耀晨曦):
[mediawiki/core@master] Checks if open_basedir include $wgGitBin before is_file()

https://gerrit.wikimedia.org/r/416234

Manually adding Platform Engineering as there is still a 30 line patch waiting for review

All right, we've intaken it for code review, thanks.

Change 416234 merged by jenkins-bot:
[mediawiki/core@master] GitInfo: Suppress is_file() warnings when checking $wgGitBin

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /416234