Page MenuHomePhabricator
Create Task
Maniphest T68743

Preview step of "firstedit" tour is displaying incorrectly after save
Closed, ResolvedPublic
Actions

Description

Author: swalling

Description:
Beta Labs screenshot

Steps to reproduce:

  1. Go to an article on Beta Labs with the firstedit tour enabled, like http://en.wikipedia.beta.wmflabs.org/wiki/Corgi?tour=firstedit
  1. Edit and save the page without previewing
  1. You should see the preview instructions again, unattached

Version: unspecified
Severity: normal

Attached:

Screen_Shot_2014-06-17_at_2.19.38_PM.png (1×2 px, 1 MB)

Details

Reference
bz66743

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:19 AM
• bzimport added a project: MediaWiki-extensions-GuidedTour.
• bzimport set Reference to bz66743.
• bzimport created this task.Jun 17 2014, 9:20 PM
• bzimport added a comment.Jun 17 2014, 9:21 PM

swalling wrote:

This does not appear to happen with the Save step.

• bzimport added a comment.Jun 17 2014, 9:28 PM

swalling wrote:

Also tested on English Wikipedia proper, and I do not get this.

gerritbot added a comment.Jul 2 2014, 8:59 AM

Change 143170 had a related patch set uploaded by Robmoen:
Add automatic next button step specification.

https://gerrit.wikimedia.org/r/143170

• rmoen added a comment.Jul 7 2014, 4:59 PM

(In reply to Gerrit Notification Bot from comment #3)

Change 143170 had a related patch set uploaded by Robmoen:
Add automatic next button step specification.

https://gerrit.wikimedia.org/r/143170

This patch was mistakenly marked with the bug and is unrelated.

• bzimport added a comment.Jul 7 2014, 5:37 PM

swalling wrote:

enwiki screenshot

Attached:

Screen_Shot_2014-07-07_at_10.35.24_AM.png (1×2 px, 1 MB)

• bzimport added a comment.Jul 7 2014, 6:18 PM

swalling wrote:

This is now appearing in production on enwiki.

You can replicate by:

  1. viewing a page with either ?tour=firstedit or the GettingStarted CTA, and then choosing "Edit this page"
  2. click Edit
  3. Go back to read mode
gerritbot added a comment.Jul 10 2014, 11:23 PM

Change 145464 had a related patch set uploaded by Robmoen:
End tour if saving before preview

https://gerrit.wikimedia.org/r/145464

gerritbot added a comment.Jul 14 2014, 6:31 PM

Change 145464 merged by jenkins-bot:
End tour if saving before preview

https://gerrit.wikimedia.org/r/145464

• bzimport added a comment.Aug 28 2014, 8:40 PM

swalling wrote:

English Wikipedia screenshot

Attached:

Screen_Shot_2014-08-28_at_1.36.41_PM.png (839×1 px, 362 KB)

• bzimport added a comment.Aug 28 2014, 8:43 PM

swalling wrote:

This same issue is happening on production for the gettingstartedtasktoolbar tour. See new screenshot.

• Mattflaschen-WMF added a comment.Sep 4 2014, 9:04 PM

Please file a new bug against the GettingStarted extension.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits