Page MenuHomePhabricator
Create Task
Maniphest T50888

Improve data value validation and error handling in api
Closed, ResolvedPublic
Actions

Description

In the SetQualifier module, I gave it invalid data value input (and it was being handled incorrectly in the api). I got back an exception with full stack trace in the api result.

Generally speaking, in a number of places, the api is also doing insufficient validation and error handling of the data values. The api user should *not* see an exception in the api error output. Any exceptions due to invalid value input should be caught and translated into a proper api error message and code.

(See also related bug 48864 and bug 48473)

Version: master
Severity: normal

Details

Reference
bz48888

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT87764 Bugs related to time datatype (tracking)
 ResolvedLydia_PintscherT50962 localize display of time values
 ResolvedNoneT47046 Normalizing file names for display
 ResolvedNoneT50860 [ui] First version of geocoordinate datatype support
 ResolvedNoneT50965 time data values are not validated when saved via api
 ResolvedNoneT63254 Item values are not linked when Javascript is disabled
 ResolvedNoneT51014 Use value formatters for displaying values on Entity pages (non-JavaScript view)
 Resolved• adrianheineT63738 Spaces in commons file names are replaced by plus signs instead of underscores
 ResolvedNoneT50888 Improve data value validation and error handling in api
 ResolvedNoneT40675 Review Wikibase API error handling
 Resolved• adrianheineT51186 Property value parsing, formatting and validation should be done (only?) in the backend
 ResolvedNoneT48365 Need generic string value formatter
 ResolvedNoneT55745 Implement a factory/registry infrastructure for snak and value formatters
 ResolvedNoneT51265 Spec out registry/factory for formatters and parsers in the backend
 ResolvedNoneT51263 Apply data type specific validators to snak values received by the API
 ResolvedNoneT51264 Apply strict validation when constructing DataValue objects
 ResolvedNoneT58716 UI for quantities should use the backend for formatting
 ResolvedNoneT53111 design and spec API modules for value validation and formatting
 ResolvedNoneT58263 Implement "ApiBasedValueFormatter" in the fashion of "ApiBasedValueParser"
 ResolvedNoneT58261 Implementation of basic value formatters in JavaScript
 ResolvedNoneT58765 create an api module for formatting data values
 ResolvedNoneT59014 Create a FormatValue API module for formatting data values
 ResolvedNoneT64185 Use backend formatter and parser for time
 ResolvedNoneT64184 Create PHP Time Parsers for wbparsevalue
 Resolved• adrianheineT64377 Add calendar hint to backend time formatter
 DeclinedNoneT64189 Create PHP URL Parsers for wbparsevalue
 DeclinedNoneT64190 Create PHP Commons Parsers for wbparsevalue

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 1:36 AM
• bzimport added a project: MediaWiki-extensions-WikibaseRepository.
• bzimport set Reference to bz48888.
• bzimport added a subscriber: Unknown Object (MLST).
aude created this task.May 28 2013, 10:59 AM
daniel added a comment.Jul 1 2013, 12:26 PM

Making this as depending on 49264. Input validation has improved since this was filed, but it's still possible to trigger a fatal error by submitting a structurally invalid data value.

Lydia_Pintscher added a comment.Oct 8 2013, 9:53 PM

Closing as this is too general to be useful and we have other bugs for it.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits