Page MenuHomePhabricator

Figure out what to do with the 'expandablesearch' component of Vector extension
Closed, ResolvedPublic

Description

(Split from bug 45051.)

I have no idea what this is, but it's probably disabled entirely and unknown
of for a reason.

Quoting from bug 45051:

By its name, it looks like this could be code to automatically
expand the search box when clicked or when the search sting
exceeds a certain length. Just guessing, though.

When focused. It's important for search usability for the search
input to be large enough to accommodate practically anything the
user would input into there.


Version: unspecified
Severity: normal

Details

Reference
bz46515

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 1:15 AM
bzimport set Reference to bz46515.

According to bug 27647, this feature is currently broken.

rahul14m93 wrote:

So what should be ideally done?Delete the expandablesearch.css and .js files?Can you shed some light on it ?

I honestly don't know what to do here. CC-ing Waldir and Dantman (whose comments I cited in comment 0) for input :)

Ideally it would be good to fix it. Good amounts of space in the search input is usually an important usability point.

Change 84195 had a related patch set uploaded by Bartosz Dziewoński:
Delete the ext.vector.expandableSearch module

https://gerrit.wikimedia.org/r/84195

Change 84195 merged by jenkins-bot:
Delete the ext.vector.expandableSearch module

https://gerrit.wikimedia.org/r/84195

The component has been removed, so I'm closing this. There's no reason it can't be reimplemented properly in core in the future, though.