Page MenuHomePhabricator
Create Task
Maniphest T381842

SpecialContributions and SpecialDeletedContributions tests fail if $wgDefaultSkin is 'vector'
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

I had to set $wgDefaultSkin = 'vector-2022' to avoid these failures:

1) SpecialContributionsTest::testExecuteNoResultsForIPTarget with data set "Temporary accounts not enabled" (false, 'contributions-title')
Attempt to read property "nodeValue" on null

/home/aaron/PhpstormProjects/mediawiki/core/tests/phpunit/includes/specials/SpecialContributionsTest.php:160

2) SpecialContributionsTest::testExecuteNoResultsForIPTarget with data set "Temporary accounts enabled" (true, 'contributions-title-for-ip-wh...nabled')
Attempt to read property "nodeValue" on null

/home/aaron/PhpstormProjects/mediawiki/core/tests/phpunit/includes/specials/SpecialContributionsTest.php:160

3) SpecialDeletedContributionsTest::testExecuteNoResultsForIPTarget with data set "Temporary accounts not enabled" (false, 'deletedcontributions-title')
Attempt to read property "nodeValue" on null

/home/aaron/PhpstormProjects/mediawiki/core/tests/phpunit/includes/specials/SpecialDeletedContributionsTest.php:77

4) SpecialDeletedContributionsTest::testExecuteNoResultsForIPTarget with data set "Temporary accounts enabled" (true, 'deletedcontributions-title-fo...nabled')
Attempt to read property "nodeValue" on null

Details

SubjectRepoBranchLines /-
Fix core contributions special page tests for legacy Vectormediawiki/coremaster 2 -2
Customize query in gerrit

Event Timeline

aaron created this task.Tue, Dec 10, 2:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Dec 10, 2:00 AM
Dreamy_Jazz claimed this task.Tue, Dec 10, 11:57 AM
Dreamy_Jazz added projects: Trust and Safety Product Team, Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)).
Dreamy_Jazz set the point value for this task to 1.
gerritbot added a comment.Tue, Dec 10, 1:14 PM

Change #1101855 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@master] Fix core contributions special page tests for legacy Vector

https://gerrit.wikimedia.org/r/1101855

gerritbot added a project: Patch-For-Review.Tue, Dec 10, 1:14 PM
Dreamy_Jazz moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)) board.Tue, Dec 10, 1:15 PM
gerritbot added a comment.Tue, Dec 10, 4:00 PM

Change #1101855 merged by jenkins-bot:

[mediawiki/core@master] Fix core contributions special page tests for legacy Vector

https://gerrit.wikimedia.org/r/1101855

Maintenance_bot removed a project: Patch-For-Review.Tue, Dec 10, 4:30 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.8; 2024-12-17).Tue, Dec 10, 5:00 PM
Dreamy_Jazz closed this task as Resolved.Tue, Dec 10, 5:17 PM
Dreamy_Jazz moved this task from Needs Review to Done on the Trust and Safety Product Sprint (Sprint Chimes (Dec. 9 - Jan. 17)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits