Page MenuHomePhabricator

Surfacing Popups missing thumbnail image
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Go to a page where an add-a-link task is being surfaced
  • click on one of the highlighted words

What happens?:
The popup opens but is showing neither an image from the article nor the placeholder image:

image.png (232×336 px, 20 KB)

What should have happened instead?:
It should show the image from the article, if available:

image.png (235×344 px, 29 KB)

Other information (browser name/version, screenshots, etc.):
This is very likely caused by forgetting to declare the CdxThumbnail styles in the ResourceLoader module definition in extension.json (see https://www.mediawiki.org/wiki/Codex#Usage_without_JavaScript_(CSS-only_Codex_components)).

Open questions:

  • Why did this problem not occur when testing locally? Something else must be requesting the codex styles (or all of codex) that is not present in production.

Event Timeline

Michael updated the task description. (Show Details)
Michael moved this task from Inbox to Current Sprint on the Growth-Team board.
Michael edited projects, added Growth-Team (Current Sprint); removed Growth-Team.
Michael moved this task from Incoming to Doing on the Growth-Team (Current Sprint) board.

Change #1100046 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] fix: show thumbnails in surfacing popups

https://gerrit.wikimedia.org/r/1100046

While this change should just work™, I'm not sure how to test it myself, given that locally those missing styles are already being loaded by something else.

While this change should just work™, I'm not sure how to test it myself, given that locally those missing styles are already being loaded by something else.

I'm able to reproduce the issue on my local setup. Fortunately, the fix fixes it. Moving to QA.

Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Current Sprint) board.

Change #1100046 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix: show thumbnails in surfacing popups

https://gerrit.wikimedia.org/r/1100046

Change #1100102 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.5] fix: show thumbnails in surfacing popups

https://gerrit.wikimedia.org/r/1100102

Change #1100103 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.6] fix: show thumbnails in surfacing popups

https://gerrit.wikimedia.org/r/1100103

Change #1100102 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.5] fix: show thumbnails in surfacing popups

https://gerrit.wikimedia.org/r/1100102

Change #1100103 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.6] fix: show thumbnails in surfacing popups

https://gerrit.wikimedia.org/r/1100103

Mentioned in SAL (#wikimedia-operations) [2024-12-03T14:25:06Z] <urbanecm@deploy2002> Started scap sync-world: Backport for [[gerrit:1100103|fix: show thumbnails in surfacing popups (T381364)]], [[gerrit:1100102|fix: show thumbnails in surfacing popups (T381364)]]

Mentioned in SAL (#wikimedia-operations) [2024-12-03T14:30:46Z] <urbanecm@deploy2002> migr, urbanecm: Backport for [[gerrit:1100103|fix: show thumbnails in surfacing popups (T381364)]], [[gerrit:1100102|fix: show thumbnails in surfacing popups (T381364)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-12-03T14:44:30Z] <urbanecm@deploy2002> Finished scap sync-world: Backport for [[gerrit:1100103|fix: show thumbnails in surfacing popups (T381364)]], [[gerrit:1100102|fix: show thumbnails in surfacing popups (T381364)]] (duration: 19m 24s)