DiscussionToolsPageInfo: RuntimeException: The revision x belongs to a deleted page.
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Ammarpad
	Wed, Nov 20, 11:07 AM

Description

Error

service.version: 1.44.0-wmf.3
trace.id: bd0b2b76-9f16-44b7-9553-4729249b496f
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   RuntimeException: The revision #250513713 belongs to a deleted page. You can [//de.wikipedia.org/w/index.php?title=Spezial:Wiederherstellen&target=Benutzer_Diskussion:2003:D7:1F25:1D00:4064:9088:67B7:8482&timestamp=202411200946

Frame	Location	Call
from	/srv/mediawiki/php-1.44.0-wmf.3/extensions/DiscussionTools/includes/Hooks/HookUtils.php(162)
#0	/srv/mediawiki/php-1.44.0-wmf.3/extensions/DiscussionTools/includes/ApiDiscussionToolsPageInfo.php(116)	MediaWiki\Extension\DiscussionTools\Hooks\HookUtils::parseRevisionParsoidHtml(MediaWiki\Revision\RevisionStoreRecord, string)
#1	/srv/mediawiki/php-1.44.0-wmf.3/extensions/DiscussionTools/includes/ApiDiscussionToolsPageInfo.php(48)	MediaWiki\Extension\DiscussionTools\ApiDiscussionToolsPageInfo->getThreadItemSet(array)
#2	/srv/mediawiki/php-1.44.0-wmf.3/includes/api/ApiMain.php(1975)	MediaWiki\Extension\DiscussionTools\ApiDiscussionToolsPageInfo->execute()
#3	/srv/mediawiki/php-1.44.0-wmf.3/includes/api/ApiMain.php(943)	MediaWiki\Api\ApiMain->executeAction()
#4	/srv/mediawiki/php-1.44.0-wmf.3/includes/api/ApiMain.php(914)	MediaWiki\Api\ApiMain->executeActionWithErrorHandling()
#5	/srv/mediawiki/php-1.44.0-wmf.3/includes/api/ApiEntryPoint.php(153)	MediaWiki\Api\ApiMain->execute()
#6	/srv/mediawiki/php-1.44.0-wmf.3/includes/MediaWikiEntryPoint.php(200)	MediaWiki\Api\ApiEntryPoint->execute()
#7	/srv/mediawiki/php-1.44.0-wmf.3/api.php(44)	MediaWiki\MediaWikiEntryPoint->run()
#8	/srv/mediawiki/w/api.php(3)	require(string)
#9	{main}

Impact

Notes

The special page does not accept revision id, but the underlying API does and it fails with runtime exception if the revision was deleted.

The message is also wrong as it claims the user can view the revision even if they cannot.

Previously the Compare api module was patched for the same issue: T362814

Details

	Subject	Repo	Branch	Lines /-
	ApiDiscussionToolsPageInfo: Show nice error for deleted revisions	mediawiki/extensions/DiscussionTools	master	5 -0

Customize query in gerrit

Related Objects

Mentioned In: T362814: RuntimeException: The revision #1218831252 belongs to a deleted page.
Mentioned Here: T362814: RuntimeException: The revision #1218831252 belongs to a deleted page.

Event Timeline

Ammarpad created this task.Wed, Nov 20, 11:07 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Nov 20, 11:07 AM

Ammarpad mentioned this in T362814: RuntimeException: The revision #1218831252 belongs to a deleted page. .Wed, Nov 20, 11:07 AM

Ammarpad added a project: Wikimedia-production-error.Wed, Nov 20, 11:09 AM

Ammarpad updated the task description. (Show Details)

Change #1093303 had a related patch set uploaded (by Ammarpad; author: Ammarpad):

[mediawiki/extensions/DiscussionTools@master] ApiDiscussionToolsPageInfo: Show nice error for deleted revisions

https://gerrit.wikimedia.org/r/1093303

gerritbot added a project: Patch-For-Review.Wed, Nov 20, 11:21 AM

Ammarpad changed the subtype of this task from "Bug Report" to "Production Error".Wed, Nov 20, 11:22 AM

The message is also wrong as it claims the user can view the revision even if they cannot.

The wrong message is used here: https://gerrit.wikimedia.org/g/mediawiki/core/ /b4b00589da1a497e311b8d8712fbebb21a1e1f89/includes/page/ParserOutputAccess.php#528

If you change that, it seems that this needs to be changed too: https://gerrit.wikimedia.org/g/mediawiki/core/ /b4b00589da1a497e311b8d8712fbebb21a1e1f89/includes/Rest/Handler/Helper/HtmlOutputRendererHelper.php#658

Change #1093303 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] ApiDiscussionToolsPageInfo: Show nice error for deleted revisions

https://gerrit.wikimedia.org/r/1093303

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.5; 2024-11-25).Wed, Nov 20, 8:00 PM

matmarex closed this task as Resolved.Wed, Nov 20, 8:06 PM

matmarex assigned this task to Ammarpad.

Maintenance_bot removed a project: Patch-For-Review.Wed, Nov 20, 8:30 PM

DiscussionToolsPageInfo: RuntimeException: The revision x belongs to a deleted page.Closed, ResolvedPublicPRODUCTION ERRORActions