Page MenuHomePhabricator
Create Task
Maniphest T377578

Fix incorrect JSON pointers to root element in error responses
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Description

The JSON pointer to the root path is an empty string "", not "/". The REST API is currently doing this wrong in missing-field responses when validating that required top-level fields are present.

Technical notes:

  • the only piece of production code with this issue appears to be repo/rest-api/src/RouteHandlers/AssertValidTopLevelFields.php
  • the affected e2e tests can be found via grep -r "path: '/'" repo/rest-api/tests/mocha/ executed inside the wikibase dir. affected test files at the time of writing:
    • repo/rest-api/tests/mocha/api-testing/AddItemAliasesInLanguageTest.js
    • repo/rest-api/tests/mocha/api-testing/AddItemStatementTest.js
    • repo/rest-api/tests/mocha/api-testing/AddPropertyAliasesInLanguageTest.js
    • repo/rest-api/tests/mocha/api-testing/AddPropertyStatementTest.js
    • repo/rest-api/tests/mocha/api-testing/CreateItemTest.js
    • repo/rest-api/tests/mocha/api-testing/ReplaceItemStatementTest.js
    • repo/rest-api/tests/mocha/api-testing/ReplacePropertyStatementTest.js
    • repo/rest-api/tests/mocha/api-testing/SetItemDescriptionTest.js
    • repo/rest-api/tests/mocha/api-testing/SetItemLabelTest.js
    • repo/rest-api/tests/mocha/api-testing/SetPropertyDescriptionTest.js
    • repo/rest-api/tests/mocha/api-testing/SetPropertyLabelTest.js
    • repo/rest-api/tests/mocha/api-testing/SetSitelinkTest.js
    • repo/rest-api/tests/mocha/helpers/testValidatesPatch.js

Details

SubjectRepoBranchLines /-
REST: Fix incorrect JSON pointersmediawiki/extensions/WikibaseREL1_43 15 -15
REST: Fix incorrect JSON pointersmediawiki/extensions/Wikibasemaster 15 -15
Customize query in gerrit

Related Objects

Event Timeline

Jakob_WMDE created this task.Oct 18 2024, 12:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 18 2024, 12:40 PM
Jakob_WMDE renamed this task from Fix incorrect JSON pointers to root path in error responses to Fix incorrect JSON pointers to root element in error responses.Oct 18 2024, 12:46 PM
Ollie.Shotton_WMDE changed the subtype of this task from "Task" to "Bug Report".Oct 21 2024, 9:22 AM
Ollie.Shotton_WMDE subscribed.
Jakob_WMDE updated the task description. (Show Details)Oct 24 2024, 11:00 AM
Ifrahkhanyaree_WMDE moved this task from To polish to Polished on the Wikibase Product Platform Team WPP board.Oct 24 2024, 12:02 PM
WMDE-leszek set the point value for this task to 3.Mon, Oct 28, 3:26 PM
WMDE-leszek moved this task from Polished to Ready for planning on the Wikibase Product Platform Team WPP board.
Ifrahkhanyaree_WMDE moved this task from Backlog to Next on the Wikibase REST API (WPP) board.Tue, Oct 29, 8:50 AM
Muhammad_Yasser_Jazirahly_WMDE moved this task from Ready for planning to Sprint 32 on the Wikibase Product Platform Team WPP board.Tue, Oct 29, 10:43 AM
Muhammad_Yasser_Jazirahly_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 32); removed Wikibase Product Platform Team WPP.
Muhammad_Yasser_Jazirahly_WMDE claimed this task.Tue, Oct 29, 1:36 PM
Muhammad_Yasser_Jazirahly_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 32) board.
gerritbot added a comment.Tue, Oct 29, 2:47 PM

Change #1084126 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Fix incorrect JSON pointers

https://gerrit.wikimedia.org/r/1084126

gerritbot added a project: Patch-For-Review.Tue, Oct 29, 2:47 PM
Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 32) board.Tue, Oct 29, 5:08 PM
Ollie.Shotton_WMDE mentioned this in T378370: Backport latest REST API changes to REL1_43.Wed, Oct 30, 10:34 AM
gerritbot added a comment.Wed, Oct 30, 11:31 AM

Change #1084126 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Fix incorrect JSON pointers

https://gerrit.wikimedia.org/r/1084126

Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 32) board.Wed, Oct 30, 11:58 AM
Maintenance_bot removed a project: Patch-For-Review.Wed, Oct 30, 12:31 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.2; 2024-11-05).Wed, Oct 30, 1:00 PM
gerritbot added a comment.Mon, Nov 11, 2:43 PM

Change #1089785 had a related patch set uploaded (by Ollie Shotton; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@REL1_43] REST: Fix incorrect JSON pointers

https://gerrit.wikimedia.org/r/1089785

gerritbot added a project: Patch-For-Review.Mon, Nov 11, 2:43 PM
Ifrahkhanyaree_WMDE closed this task as Resolved.Tue, Nov 12, 10:21 AM
Ifrahkhanyaree_WMDE moved this task from Next to Done on the Wikibase REST API (WPP) board.Tue, Nov 12, 11:47 AM
gerritbot added a comment.Tue, Nov 12, 5:52 PM

Change #1089785 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@REL1_43] REST: Fix incorrect JSON pointers

https://gerrit.wikimedia.org/r/1089785

Maintenance_bot removed a project: Patch-For-Review.Tue, Nov 12, 6:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits