Page MenuHomePhabricator

[Minerva] Links in category boxes appear unstyled (AMC mode)
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce

  1. Log in to the beta cluster on mobile: https://en.m.wikipedia.beta.wmflabs.org
  2. Enable AMC mode from the Special:MobileOptions page
  3. Visit an article that has categories, e.g: https://en.m.wikipedia.beta.wmflabs.org/wiki/E._J._Scovell

Expected results

The links in the category box should use the color toke @color-progressive, i.e. #3366cc

Screenshot 2024-10-01 at 9.55.25 AM.png (1×1 px, 252 KB)

Actual results

The links have browser default styling.

Screenshot 2024-10-01 at 9.55.37 AM.png (1×1 px, 298 KB)

Environments observed

  • Any device using the Minerva skin.
  • Only with advanced contributions mode enabled, since Minerva disabled the category boxes otherwise.

Check any additional observations

Stack trace

Screenshot 2024-10-01 at 9.57.08 AM.png (1×2 px, 489 KB)

The link color seems to depend on the following ruleset, which was recently changed due to other issues.

a:not([role="button"]):not(.minerva__tab-text) {
  color: var(--color-progressive,#36c);
  border-radius: 2px;
  text-decoration: none;
}

Requirement

Ensure that links in category boxes in the Minerva skin, when AMC (Advanced Contributions Mode) is enabled, are styled using the color token @color-progressive (#3366cc) instead of the default browser styling.

BDD

Feature: Style links in category boxes with AMC enabled in Minerva skin

  Scenario: Correctly style links in category boxes
    Given the user has enabled AMC mode in the Minerva skin
    When the user visits an article with categories
    Then the links in the category box should be styled with @color-progressive (#3366cc)

Test Steps

Test Case 1: Verify Link Styling in Category Boxes with AMC Mode

  1. Log in to the beta cluster on mobile: https://en.m.wikipedia.beta.wmflabs.org
  2. Navigate to the Special:MobileOptions page and enable AMC mode.
  3. Visit an article with categories, such as E.J. Scovell.
  4. AC1: Confirm the links in the category box use the @color-progressive token (#3366cc).

QA Results - Beta

ACStatusDetails
1T376146#10223780

Event Timeline

Edtadros removed Edtadros as the assignee of this task.EditedOct 13 2024, 2:16 AM
Edtadros updated the task description. (Show Details)
Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: Beta
OS: macOS
Browser: Chrome
Device: MS MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Link Styling in Category Boxes with AMC Mode

  1. Log in to the beta cluster on mobile: https://en.m.wikipedia.beta.wmflabs.org.
  2. Navigate to the Special:MobileOptions page and enable AMC mode.
  3. Visit an article with categories, such as E.J. Scovell.
  4. AC1: Confirm the links in the category box use the @color-progressive token (#3366cc).

screenshot 75.png (1×1 px, 504 KB)

ovasileva claimed this task.