Page MenuHomePhabricator

Gerrit emails do not include comments on files that were not modified in the change
Closed, DuplicatePublic

Description

On Parallelize Cypress tests, I left several review comments, including one on a file that the change didn’t touch yet (by hand-editing the URL to change the file path). @AudreyPenven_WMDE reports that the comment on the unmodified file wasn’t included in Gerrit’s notification email; likewise, when she responded, the email I got was missing one of her three comments (the one on cypress/e2e/special/recentChanges.cy.ts, the unmodified file – that’s the middle comment in the left screenshot):

image.png (863×1 px, 235 KB) image.png (740×1 px, 100 KB)

I’m guessing this is an Upstream issue related to the fact that commenting on unchanged files is at best a niche feature (or at worst, not meant to be supported at all – though I occasionally find it useful, so I’d be sad to see it go away).