Page MenuHomePhabricator

Test failure: MediaWiki\Skins\Vector\Tests\Structure\PerformanceBudgetTest::testTotalModulesSize
Closed, DuplicatePublic

Description

13:12:58 1) MediaWiki\Skins\Vector\Tests\Structure\PerformanceBudgetTest::testTotalModulesSize with data set "vector-2022" ('vector-2022', array('50KB', '23KB'))
13:12:58 T346813: Performance budget for styles in skin vector-2022 on main article namespace has been exceeded. Total size of styles modules is 27.6 Kbs is greater than the current budget size of 27.2 Kbs (see Vector/bundlesize.config.json).
13:12:58 If you are adding code on page load, please reduce styles that you are loading on page load or talk to the web team about increasing the budget.
13:12:58 If you are not adding code, and this seems to be an error, it is possible that something running without CI has bypassed this check and we can address this separately.Please reach out to the web team to discuss this via Phabricator or #talk-to-web.[PLEASE DO NOT SKIP THIS TEST. If this is blocking a deploy this might signal a potential performance regression with the desktop site.Instead of skipping the test you can increase the value in bundlesize.config.json and create a ticket to investigate this error. If the error is > 1kb please tag this as a train blocker.Please tag the ticket #Web-Team-Backlog.
13:12:58 
13:12:58 The following modules are enabled on page load:
13:12:58 skins.vector.search.codex.styles
13:12:58 skins.vector.styles
13:12:58 skins.vector.icons
13:12:58 ext.flaggedRevs.basic
13:12:58 mediawiki.codex.messagebox.styles
13:12:58 ext.uls.pt
13:12:58 ext.visualEditor.desktopArticleTarget.noscript
13:12:58 wikibase.client.init
13:12:58 wikibase.client.data-bridge.externalModifiers
13:12:58 ext.wikimediaBadges
13:12:58 ext.wikimediamessages.styles
13:12:58 site.styles
13:12:58 noscript
13:12:58 user.styles
13:12:58 Failed asserting that 28192 is equal to 27752.0 or is less than 27752.0.
13:12:58 
13:12:58 /workspace/src/skins/Vector/tests/phpunit/structure/PerformanceBudgetTest.php:210

Seen on https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php82-noselenium/14808/console from Do not construct CommunityUpdates when CommunityConfiguration is unavailable

Event Timeline

I'm not sure if this is a duplicate of T373017 - The list of modules there is:

00:33:13.608 The following modules are enabled on page load:
00:33:13.608 skins.vector.search.codex.styles
00:33:13.609 skins.vector.styles
00:33:13.609 skins.vector.icons
00:33:13.609 ext.flaggedRevs.basic
00:33:13.609 ext.uls.pt
00:33:13.609 ext.visualEditor.desktopArticleTarget.noscript
00:33:13.609 wikibase.client.init
00:33:13.609 wikibase.client.data-bridge.externalModifiers
00:33:13.609 ext.wikimediaBadges
00:33:13.609 ext.wikimediamessages.styles
00:33:13.609 site.styles
00:33:13.609 noscript
00:33:13.609 user.styles

and the list of modules here is:

13:12:58 skins.vector.search.codex.styles
13:12:58 skins.vector.styles
13:12:58 skins.vector.icons
13:12:58 ext.flaggedRevs.basic
13:12:58 mediawiki.codex.messagebox.styles
13:12:58 ext.uls.pt
13:12:58 ext.visualEditor.desktopArticleTarget.noscript
13:12:58 wikibase.client.init
13:12:58 wikibase.client.data-bridge.externalModifiers
13:12:58 ext.wikimediaBadges
13:12:58 ext.wikimediamessages.styles
13:12:58 site.styles
13:12:58 noscript
13:12:58 user.styles

Tellingly, mediawiki.codex.messagebox.styles is new, and was introduced in If3c2d26de3faa9f85025ea8643d97242cad27574 (T373602, T375246) on September 20th. I wonder if the issue here is that the bundle actually got bigger (in the case that cdx-message appears in the output), and maybe this is triggered in one particular CI setup but not in others.