Apply a default to gbw_address in the global_block_whitelist table
Closed, ResolvedPublic
Actions

Description

To implement T374937: Drop gbw_address and gbw_target_central_id from the global_block_whitelist table, we first need to assign a default value to gbw_address. Once deployed, then we can stop writing to the column and then in a later schema change remove the column. Removal of the column is necessary due to the issues described in T374855#10152646.

ALTERs to run: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/GlobalBlocking/ /711c68587b37b5beb969817f5d56141fb2b5a027/sql/mysql/patch-global_block_whitelist-default-gbw_address.sql
Where to run those changes: all.dblist
When to run those changes: As soon as it is possible
If the schema change is backwards compatible: Yes
If the schema change has been tested already on some of the test/beta wikis: Applied to the beta cluster, as GlobalBlocking is installed there
If the data should be made available on the labs replicas and/or dumps: Table is fully public, and this should not change as part of this schema change

Status	Assigned	Task
		Restricted Task
Resolved	kostajh	T294511 2021 Security Team wikireplicas audit
Declined	None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
In Progress	Niharika	T324492 Temporary accounts - MVP
Open	None	T326816 [Epic] Update features for temporary accounts
Open	Dreamy_Jazz	T355286 [Epic] Globally blocking a temporary account should prevent further account creations
Resolved	Dreamy_Jazz	T368949 [Epic] Implement global autoblocks from global user blocks
Resolved	Dreamy_Jazz	T374937 Drop gbw_address and gbw_target_central_id from the global_block_whitelist table
Resolved	Dreamy_Jazz	T374945 Stop writing to gbw_address and gbw_target_central_id
Resolved	Ladsgroup	T375184 Apply a default to gbw_address in the global_block_whitelist table

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

kostajh subscribed.

ABran-WMF triaged this task as Medium priority.Sep 23 2024, 7:53 AM

(we don't think this will affect any data pipeline - the new default / not null constraints would look like the data already does)

I'm going to try to do this ASAP.

Running on master of each wiki with replication. It's empty basically everywhere and one or two rows in around ten wikis.

Done. Nothing seems to be on fire (beside the burning passion in my heart about mediawiki)