Page MenuHomePhabricator

Migrate GrowthExperiments.NewcomerTask Module to statslib
Open, HighPublic3 Estimated Story Points

Description

The Stats library (added in MW 1.41) attempts to better define the interface for generating metrics in MediaWiki. See Manual

As part of ensuring the whole of GrowthExperiments is using the Stats Library(Statslib) we should migrate the highlighted areas in GrowthExperiments.NewcomerTask

Please follow the guidelines and standards outlined in the provided documentation:

Acceptance Criteria
Update Affected Areas

  • MediaWiki.$wiki.GrowthExperiments.NewcomerTask.$tasktype.Click.sum
  • MediaWiki.$wiki.GrowthExperiments.NewcomerTask.$tasktype.Save.sum
  • MediaWiki.$wiki.GrowthExperiments.NewcomerTask.Reverted.$tasktype.sum
  • MediaWiki.*.GrowthExperiments.NewcomerTask.*

Deploy and Verify changes

  • Deploy the changes to production.
  • Update the relevant dashboard(s) by replacing the old Graphite metric(s) with the new Prometheus metric(s).
  • Verify that the changes have been successfully implemented(This is nothing complex besides normal functionality and metrics captured are sent to Prometheus are queried from in-use dashboards.)

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

Change #1089761 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] maint: fix stats-collection flakyness by migrating to statslib

https://gerrit.wikimedia.org/r/1089761

Change #1089761 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] maint: fix stats-collection flakyness by migrating to statslib

https://gerrit.wikimedia.org/r/1089761

Sgs triaged this task as High priority.Nov 18 2024, 3:16 PM
Sgs set the point value for this task to 3.Tue, Nov 26, 5:52 PM
Sgs moved this task from Maintenance to Current Sprint on the Growth-Team board.

Change #1100416 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] statslib: migrate GrowthExperiments.NewcomerTask counters to StatsFactory

https://gerrit.wikimedia.org/r/1100416

Change #1100416 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] statslib: migrate GrowthExperiments.NewcomerTask counters

https://gerrit.wikimedia.org/r/1100416

Change #1102916 had a related patch set uploaded (by Cwhite; author: Cwhite):

[mediawiki/extensions/GrowthExperiments@master] change metric types back to counters

https://gerrit.wikimedia.org/r/1102916

Change #1102916 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] change metric types back to counters

https://gerrit.wikimedia.org/r/1102916

Change #1102959 had a related patch set uploaded (by Cwhite; author: Cwhite):

[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.6] change metric types back to counters

https://gerrit.wikimedia.org/r/1102959

Change #1102959 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.44.0-wmf.6] change metric types back to counters

https://gerrit.wikimedia.org/r/1102959

Mentioned in SAL (#wikimedia-operations) [2024-12-12T22:16:27Z] <tgr@deploy2002> Started scap sync-world: Backport for [[gerrit:1102959|change metric types back to counters (T374050)]]

Mentioned in SAL (#wikimedia-operations) [2024-12-12T22:20:26Z] <tgr@deploy2002> tgr, cwhite: Backport for [[gerrit:1102959|change metric types back to counters (T374050)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-12-12T22:35:37Z] <tgr@deploy2002> Finished scap sync-world: Backport for [[gerrit:1102959|change metric types back to counters (T374050)]] (duration: 19m 10s)