Update the GlobalBlockLookup service to read the value of gb_create_account
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The GlobalBlockLookup service needs to read the value of gb_create_account and then apply this to the GlobalBlock instances that it returns. This so that the block can be optionally set to apply to account creation.

This is safe to do so now because the column exists on WMF wikis (T371415) and a default is set for this column of 1 which will ensure that the current behaviour (all global blocks prevent account creation) continues to apply.

Acceptance criteria

Update GlobalBlockLookup to read the value from the gb_create_account column and use it / return it where necessary.

Details

	Subject	Repo	Branch	Lines /-
	Update GlobalBlockLookup to read gb_create_account	mediawiki/extensions/GlobalBlocking	master	88 -22

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
			Restricted Task
Resolved		kostajh	T294511 2021 Security Team wikireplicas audit
Declined		None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
In Progress		Niharika	T324492 Temporary accounts - MVP
Open		None	T326816 [Epic] Update features for temporary accounts
Open		Dreamy_Jazz	T355286 [Epic] Globally blocking a temporary account should prevent further account creations
Resolved		Dreamy_Jazz	T368949 [Epic] Implement global autoblocks from global user blocks
Resolved		None	T40648 Wiki Loves Monuments 2012 (tracking)
Duplicate		None	T42190 Anonymous only global block prevents account creation
Resolved	Feature	Dreamy_Jazz	T17273 Add "Prevent account creation" checkbox to allow global blocks which do not prevent account creation
Resolved		Dreamy_Jazz	T371685 Update Special:GlobalBlockList to display whether the active global block prevents account creation
Resolved		Dreamy_Jazz	T371625 Update the GlobalBlockLogFormatter to indicate whether a block disallows account creation
Resolved		Dreamy_Jazz	T371693 Update Special:GlobalBlock to indicate whether a block should disallow account creation
Resolved		Dreamy_Jazz	T371718 Update the globalblock API to support specifying if account creation should be blocked
Resolved		Dreamy_Jazz	T371619 Update the GlobalBlockingManager to write to the gb_create_account column
Resolved		Dreamy_Jazz	T371721 Update the 'globalblocks' query API to read the value of gb_create_account
Resolved		Dreamy_Jazz	T371604 Update the GlobalBlockLookup service to read the value of gb_create_account
Resolved		Dreamy_Jazz	T371601 Test the GlobalBlock class
Resolved		Ladsgroup	T371415 Add gb_autoblock_parent_id, gb_autoblock_enabled, and gb_create_account to the globalblocks table
Resolved		Dreamy_Jazz	T371248 Add gb_create_account column to the globalblocks table

Event Timeline

Dreamy_Jazz created this task.Aug 1 2024, 12:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 1 2024, 12:58 PM

Dreamy_Jazz added a subtask: T371601: Test the GlobalBlock class.Aug 1 2024, 12:59 PM

Dreamy_Jazz added a subtask: T371415: Add gb_autoblock_parent_id, gb_autoblock_enabled, and gb_create_account to the globalblocks table.

Change #1059087 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Update GlobalBlockLookup to read gb_create_account from globalblocks

https://gerrit.wikimedia.org/r/1059087

gerritbot added a project: Patch-For-Review.Aug 1 2024, 1:55 PM

Dreamy_Jazz moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Koto (July 15 - July 26)) board.Aug 1 2024, 2:06 PM

Dreamy_Jazz set the point value for this task to 1.

Dreamy_Jazz added a parent task: T371619: Update the GlobalBlockingManager to write to the gb_create_account column.Aug 1 2024, 3:29 PM

Dreamy_Jazz removed a parent task: T17273: Add "Prevent account creation" checkbox to allow global blocks which do not prevent account creation.Aug 1 2024, 4:49 PM

Change #1059087 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Update GlobalBlockLookup to read gb_create_account

https://gerrit.wikimedia.org/r/1059087

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Aug 2 2024, 9:00 AM

Maintenance_bot removed a project: Patch-For-Review.Aug 2 2024, 9:30 AM

I would recommend for QA testing that global blocks still disable account creation. You can test this on the beta wikis, patch demo, or a local wiki.

Dreamy_Jazz closed subtask T371601: Test the GlobalBlock class as Resolved.Aug 2 2024, 10:57 AM

Dreamy_Jazz mentioned this in T371601: Test the GlobalBlock class.

Dreamy_Jazz added a parent task: T371685: Update Special:GlobalBlockList to display whether the active global block prevents account creation.Aug 2 2024, 11:31 AM

Dreamy_Jazz added a parent task: T371721: Update the 'globalblocks' query API to read the value of gb_create_account.Aug 2 2024, 7:06 PM

Testing for Global Blocks has been completed, no issues discovered with the implementation of the new code (GlobalBlock still disables account creation).

Tchanders closed this task as Resolved.Aug 5 2024, 9:29 AM

Update the GlobalBlockLookup service to read the value of gb_create_accountClosed, ResolvedPublic1 Estimated Story PointsActions