Maniphest T371048

phpcs is unable to sort class constant keys properly
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Steps to replicate the issue (include links if applicable):

Add /** @phpcs-require-sorted-array */ at the beginning of an array that contains PHP class consts as keys. e.g. The EXPECTED_CONTEXT_KEYS array in github link
Run mw dev mw composer phpcs-modified

What happens?:
We get the following warning: Found duplicate key "self" on array required sorting (MediaWiki.Arrays.AlphabeticArraySort.Duplicate).

What should have happened instead?:
sort the consts alphabetically

Details

	Subject	Repo	Branch	Lines /-
	REST: Add PHP constant sorting support	mediawiki/extensions/Wikibase	master	126 -126
	HISTORY: Tag as v46.0.0	mediawiki/tools/codesniffer	master	6 -0
	Support sorting PHP symbols in arrays	mediawiki/tools/codesniffer	master	136 -26

Customize query in gerrit

Event Timeline

Muhammad_Yasser_Jazirahly_WMDE created this task.Jul 25 2024, 6:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 25 2024, 6:24 PM

WMDE-leszek set the point value for this task to 8.Nov 21 2024, 11:36 AM

Jakob_WMDE moved this task from Tech backlog to Ready for planning on the Wikibase Product Platform Team WPP board.Mon, Nov 25, 2:31 PM

Ifrahkhanyaree_WMDE moved this task from Ready for planning to Sprint 34 on the Wikibase Product Platform Team WPP board.Tue, Nov 26, 10:49 AM

Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 34); removed Wikibase Product Platform Team WPP.

Muhammad_Yasser_Jazirahly_WMDE claimed this task.Tue, Nov 26, 1:08 PM

Muhammad_Yasser_Jazirahly_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 34) board.

Change #1098138 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Muhammad Jaziraly):

[mediawiki/tools/codesniffer@master] Support sorting PHP constants in arrays

https://gerrit.wikimedia.org/r/1098138

gerritbot added a project: Patch-For-Review.Wed, Nov 27, 1:44 PM

Change #1098136 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Add PHP constant sorting support via temporary fork

https://gerrit.wikimedia.org/r/1098136

Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 34) board.Wed, Nov 27, 7:53 PM

Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Doing on the Wikibase Product Platform Team WPP (Sprint 34) board.Wed, Nov 27, 7:56 PM

Change #1099193 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/tools/codesniffer@master] HISTORY: Tag as v45.0.0

https://gerrit.wikimedia.org/r/1099193

Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 34) board.Sat, Nov 30, 6:33 PM

Change #1098138 merged by jenkins-bot:

[mediawiki/tools/codesniffer@master] Support sorting PHP symbols in arrays

https://gerrit.wikimedia.org/r/1098138

Change #1099193 abandoned by Jakob:

[mediawiki/tools/codesniffer@master] HISTORY: Tag as v46.0.0

Reason:

Will wait for the regular release.

https://gerrit.wikimedia.org/r/1099193

Change #1098136 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add PHP constant sorting support

https://gerrit.wikimedia.org/r/1098136

Maintenance_bot removed a project: Patch-For-Review.Fri, Dec 6, 10:30 AM

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.8; 2024-12-17).Fri, Dec 6, 11:00 AM

Muhammad_Yasser_Jazirahly_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 34) board.Sun, Dec 8, 9:27 AM

WMDE-leszek closed this task as Resolved.Tue, Dec 10, 7:56 PM