Page MenuHomePhabricator

tokens: Make planned updates in the Red color palette in Codex
Closed, ResolvedPublic1 Estimated Story Points

Assigned To
Authored By
DTorsani-WMF
Jul 18 2024, 5:56 PM
Referenced Files
F57620331: image.png
Wed, Oct 16, 9:24 PM
F57620337: image.png
Wed, Oct 16, 9:24 PM
F57619691: image.png
Wed, Oct 16, 3:48 PM
F57619698: image.png
Wed, Oct 16, 3:48 PM
Tokens
"Like" token, awarded by ToBeFree.

Description

Background

During the expansion of the Codex color palette, as a part of T360494, we decided to keep the current destructive/error text color, which uses #d73333, known as red600. This means that while we updated all other text application tokens (other than gray) to use the 700 color values, we are still using red600 as the destructive and error text in light mode, which does not meet the 4.5:1 contrast required for text elements in all scenarios (T341485).

Before/After

#d73333 (top) vs. #d74032 (bottom)

image.png (164×756 px, 31 KB)

#d73333 (top) vs. #bf3c2c (bottom) -- E.g. Red links, in light mode

image.png (206×752 px, 32 KB)

Acceptance criteria

  • red600 is updated to #d74032 as planned during the color expansion to find equal brightness, saturation and contrast with the 600 value of all other colors [excluding gray]
  • Application tokens which were using red600 are updated to use red700 (#bf3c2c) with the exclusion of error tokens being updated in T376641
  • Make the same updates in Figma

Event Timeline

bmartinezcalvo renamed this task from Make planned updates in the Red color palette to Token clean-up: Make planned updates in the Red color palette.Jul 22 2024, 3:38 PM
CCiufo-WMF renamed this task from Token clean-up: Make planned updates in the Red color palette to Make planned updates in the Red color palette.Oct 1 2024, 5:24 PM
CCiufo-WMF renamed this task from Make planned updates in the Red color palette to tokens: Make planned updates in the Red color palette.
CCiufo-WMF renamed this task from tokens: Make planned updates in the Red color palette to tokens: Make planned updates in the Red color palette in Codex.Wed, Oct 16, 4:27 PM

Change #1080839 had a related patch set uploaded (by Dtorsani; author: Dtorsani):

[design/codex@main] tokens: Update red600 value and replace red600 application tokens with red700

https://gerrit.wikimedia.org/r/1080839

Change #1080839 merged by jenkins-bot:

[design/codex@main] tokens: Update red600 value and replace red600 application tokens with red700

https://gerrit.wikimedia.org/r/1080839

Test wiki created on Patch demo by ATomasevich (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/a5d0a31f72/w/

Test wiki on Patch demo by ATomasevich (WMF) using patch(es) linked to this task was deleted:

http://patchdemo.wmcloud.org/wikis/a5d0a31f72/w/