Page MenuHomePhabricator

MPIC: Replace multi-value lookup component with Codex's MultiselectLookup
Closed, ResolvedPublic3 Estimated Story Points

Description

T360731 T360707

Description

In T368183, we built a component for the 3 fields that use this in MPIC: Location (need for replacement of this field is also captured in T374957), Contextual attributes, Compliance requirements.

Codex recently released a LookupMultiselect component that could replace our homegrown component (it may or may not work with the more complex Location/Sample Rates field).

Replace our homegrown component with the Codex one where applicable.

Acceptance Criteria

  • Data is saved correctly
  • API outputs response correctly
  • MPIC forms show the options and prepopulated values correctly

Required

  • Unit/Integration tests?
  • Documentation?
  • Passed QA?

Event Timeline

Sarai-WMF renamed this task from MPIC: Replace multi-value lookup component with Codex to MPIC: Replace multi-value lookup component with Codex's MultiselectLookup.Oct 18 2024, 6:13 PM

Fixed up my dev instance and tested, all looked great so I merged. I left an idea for the future and I'll drop a small MR to make this work with my Linux install of docker which has docker compose instead of docker-compose for some crazy reason.

@Milimetric Thanks for that small MR to fix docker compose for Linux systems. It's already merged.

Regarding your idea for the future, it's really interesting. I think we can consider to included it in a following MR while working on the remaining UI fixes

Change #1088261 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] MPIC: Deploying v0.3.0 on staging environment

https://gerrit.wikimedia.org/r/1088261

Change #1088262 had a related patch set uploaded (by Santiago Faci; author: Santiago Faci):

[operations/deployment-charts@master] MPIC: Deploying v0.3.0 on production environment

https://gerrit.wikimedia.org/r/1088262

Change #1088261 merged by jenkins-bot:

[operations/deployment-charts@master] MPIC: Deploying v0.3.0 on staging environment

https://gerrit.wikimedia.org/r/1088261

Change #1088262 merged by jenkins-bot:

[operations/deployment-charts@master] MPIC: Deploying v0.3.0 on production environment

https://gerrit.wikimedia.org/r/1088262