Special:GlobalBlockList shows "IP address" as label for target field when global account blocks are enabled
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Jul 11 2024, 9:12 AM

Description

Found by @Djackson-ctr during QA, the target field on Special:GlobalBlockList has not been updated to indicate that the field can now take usernames.

Steps to replicate the issue

Open Special:GlobalBlockList

What happens?:
The first form field (for the target) is labelled as IP address

What should have happened instead?:
This form field should be labelled as for both IP addresses and accounts.

Details

	Subject	Repo	Branch	Lines /-
	Use correct label for targets field on Special:GlobalBlockList	mediawiki/extensions/GlobalBlocking	master	3 -2

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
			Restricted Task
Resolved		kostajh	T294511 2021 Security Team wikireplicas audit
Declined		None	T284948 Raw IPs of logged-out users disclosed in wiki-replicas
In Progress		Niharika	T324492 Temporary accounts - MVP
Open		None	T326816 [Epic] Update features for temporary accounts
Open		Dreamy_Jazz	T355286 [Epic] Globally blocking a temporary account should prevent further account creations
Open		Dreamy_Jazz	T368949 [Epic] Implement global autoblocks from global user blocks
Declined		None	T19929 CentralAuth account locks should trigger global autoblocks
Duplicate		None	T340275 Allow GlobalBlocking to block temporary accounts
Resolved	Feature	Dreamy_Jazz	T17294 Allow globally blocking of accounts
Resolved		Dreamy_Jazz	T358777 Rename messages with the '-new' suffix to remove this suffix
Resolved		Dreamy_Jazz	T358776 Remove old versions of GlobalBlocking i18n messages
Resolved		Dreamy_Jazz	T358773 Remove the global accounts block configuration flag
Resolved		Dreamy_Jazz	T356924 Deploy global account blocks to WMF wikis
Resolved	BUG REPORT	Dreamy_Jazz	T369799 Special:GlobalBlockList shows "IP address" as label for target field when global account blocks are enabled

Event Timeline

Dreamy_Jazz created this task.Jul 11 2024, 9:12 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 11 2024, 9:12 AM

Dreamy_Jazz updated the task description. (Show Details)Jul 11 2024, 9:12 AM

Change #1053627 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] Use correct label for targets field on Special:GlobalBlockList

https://gerrit.wikimedia.org/r/1053627

gerritbot added a project: Patch-For-Review.Jul 11 2024, 9:21 AM

Dreamy_Jazz claimed this task.Jul 11 2024, 9:21 AM

Dreamy_Jazz set the point value for this task to 1.

Dreamy_Jazz moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.

Dreamy_Jazz added a parent task: T356924: Deploy global account blocks to WMF wikis.

kostajh moved this task from Needs Review to Needs QA on the Trust and Safety Product Sprint (Sprint Cajon (Jun 24 - July 5)) board.Jul 11 2024, 12:53 PM

Change #1053627 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Use correct label for targets field on Special:GlobalBlockList

https://gerrit.wikimedia.org/r/1053627

Maintenance_bot removed a project: Patch-For-Review.Jul 11 2024, 1:30 PM

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.14; 2024-07-16).Jul 11 2024, 2:00 PM

I have verified the new code has been implemented and is functioning and displaying as expected.

Dreamy_Jazz closed this task as Resolved.Jul 12 2024, 5:01 AM

	F56360558: image.png
	Jul 12 2024, 2:26 AM

Special:GlobalBlockList shows "IP address" as label for target field when global account blocks are enabledClosed, ResolvedPublic1 Estimated Story PointsBUG REPORTActions