Make `haswbstatement:` work for the EntitySchema property
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Arian_Bozorg
	Jul 8 2024, 10:22 AM

Description

As a user I want to search what statements are being made using an EntitySchema value in order to see what class of Items are governed by an EntitySchema.

Problem:
Currently, users are unable to search for statements that made using the EntitySchema property P12861. When users search haswbstatement:P12861 it comes up with zero results.

We need to make sure this works so that users can see what statements are being made using this property so that they can see what class of Items are governed by EntitySchemas.

This can currently be done using the What links here on the property page, but ideally we would like to have both options available for people to make this search.

Acceptance criteria:

Search for satements using P12861 are able to be made with haswbstatement:

Notes

In T369149#9956317, @Lucas_Werkmeister_WMDE wrote:

While testing the deployment ^, I noticed that this doesn’t actually affect entities with EntitySchema-type statements (e.g. Q5); it only affects entities with other statements (e.g. Item-type statements, though probably some other types too) that had an EntitySchema qualifier. Which in practice was probably only P12861 (until I reproduced the situation on the sandbox item to verify the fix).

I think this is actually a hint that we ought to add entity-schema to the $wgWBRepoSettings['searchIndexTypes'] in the production config, so that EntitySchema statements are indexed? @Lydia_Pintscher or @Arian_Bozorg: I assume we want users to be able to search for haswbstatement:P12861=E10?

Details

	Subject	Repo	Branch	Lines /-
	Add entity-schema to $wgWBRepoSettings['searchIndexTypes']	operations/mediawiki-config	master	1 -1

Customize query in gerrit

Related Objects

Mentioned In: T369149: Search has outdated label for P12861 (“Shape Expression for class” rather than “EntitySchema for class”)
Mentioned Here: P66482 Wikidata pages with P12861 or P12886 statements (T369495)
P12861 Command-Line Input
T369149: Search has outdated label for P12861 (“Shape Expression for class” rather than “EntitySchema for class”)

Event Timeline

Arian_Bozorg created this task.Jul 8 2024, 10:22 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 8 2024, 10:22 AM

Arian_Bozorg added a project: Wikidata.Jul 8 2024, 10:22 AM

Arian_Bozorg mentioned this in T369149: Search has outdated label for P12861 (“Shape Expression for class” rather than “EntitySchema for class”).

Lucas_Werkmeister_WMDE added a project: Discovery-Search.Jul 8 2024, 10:37 AM

Change #1052699 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/mediawiki-config@master] Add entity-schema to $wgWBRepoSettings['searchIndexTypes']

https://gerrit.wikimedia.org/r/1052699

gerritbot added a project: Patch-For-Review.Jul 8 2024, 10:38 AM

I think the above change should work, but I’d love for someone from Discovery-Search to take a look and see if it makes sense. I can only partially test it locally – I can see that EntitySchema IDs start to show up in the statement_keywords of action=query&prop=cirrusbuilddoc API output, but I don’t actually have ElasticSearch installed locally, so I don’t know if the search works.

Gehel moved this task from needs triage to Current work on the Discovery-Search board.Jul 8 2024, 1:15 PM

Gehel edited projects, added Discovery-Search (Current work); removed Discovery-Search.

EBernhardson subscribed.Jul 8 2024, 3:46 PM

The patch from @Lucas_Werkmeister_WMDE seems good, we'll merge it.

It will take ~8 weeks to reindex all entities, after that the result will be available. New edits will be available with the usual ~10 minutes delay after the edit. If needed, we could identify all entities having an EntitySchema property and reindex those manually, but this requires some work and instrumentation on our side. Let us know if that's important enough or if we can live with new edits being processed correctly and 8 week wait time for full coherence.

If needed, we could identify all entities having an EntitySchema property and reindex those manually, but this requires some work and instrumentation on our side.

The data type is brand new, so this should be a pretty small set of entities. There’s only one property with this data type at the moment (list), and there are currently fewer than 500 entities linking to it; so if the hard part is just identifying the entities, that hopefully helps :) but if the hard part is reindexing a list of specific entities, then my guess would be that we can wait for the 8 weeks to pick up any stragglers that aren’t being edited anyway (unless @Arian_Bozorg disagrees).

That sounds like a plan, thanks so much :)

EBernhardson moved this task from Ready for Dev -- SWE to To Be Deployed on the Discovery-Search (Current work) board.Jul 12 2024, 6:22 PM

Change #1052699 merged by jenkins-bot:

[operations/mediawiki-config@master] Add entity-schema to $wgWBRepoSettings['searchIndexTypes']

https://gerrit.wikimedia.org/r/1052699

Mentioned in SAL (#wikimedia-operations) [2024-07-15T13:02:33Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Started scap sync-world: Backport for [[gerrit:1052699|Add entity-schema to $wgWBRepoSettings['searchIndexTypes'] (T369495)]]

Mentioned in SAL (#wikimedia-operations) [2024-07-15T13:15:39Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 lucaswerkmeister-wmde: Backport for [[gerrit:1052699|Add entity-schema to $wgWBRepoSettings['searchIndexTypes'] (T369495)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-07-15T13:33:24Z] <logmsgbot> lucaswerkmeister-wmde@deploy1002 Finished scap: Backport for [[gerrit:1052699|Add entity-schema to $wgWBRepoSettings['searchIndexTypes'] (T369495)]] (duration: 30m 51s)

In T369495#9961780, @Lucas_Werkmeister_WMDE wrote:

If needed, we could identify all entities having an EntitySchema property and reindex those manually, but this requires some work and instrumentation on our side.

The data type is brand new, so this should be a pretty small set of entities. There’s only one property with this data type at the moment (list), and there are currently fewer than 500 entities linking to it; so if the hard part is just identifying the entities, that hopefully helps :) but if the hard part is reindexing a list of specific entities, then my guess would be that we can wait for the 8 weeks to pick up any stragglers that aren’t being edited anyway (unless @Arian_Bozorg disagrees).

Here are all the potentially affected pages, if it helps: P66482