Page MenuHomePhabricator

Create link for reporting system for dark mode issues
Closed, ResolvedPublic2 Estimated Story Points

Description

NOTE: This ticket is tracking the link creation only. Once the link is ready, we'll hold off deploying until we have a solution for the parent ticket T367325: [Spike] Discuss and scope out reporting system for dark mode issues

Background

  • We would like to add a link un the appearance menu that allows logged-in users to report issues with dark mode

User story

  • As a template editor, I want to see issues with dark mode reported by other editors, so I know where to focus my energy

Requirements

  • A link should be available in the appearance menu in the place where we typically put exception handling text
  • Link should be available to all users who can see dark mode in their appearance menu
  • Hovering over the link should show a tooltip
  • Reporting mechanism only available in Vector22 or other desktop skins with the appearance menu
  • Link is only available when dark mode is enabled
  • Link should never appear at the same time as exception handling disclaimers
  • Color label should have (beta) appended to it
  • Link should lead to pre-filled form
  • When the appearance menu is collapsed in the top bar and logged out users click the reporting link, the appearance menu should stay open so that they can see the "Report received" system feedback.
    • NOTE: page for form TBD -> we'll handle the rest of the reporting UX in T367795, including where the reports will go, copy, and what the reporting UX will look like.
  • Link should be translatable on wiki. Communities should have the ability to set the link to a different page on-wiki
  • For this ticket, the link should go to https://www.mediawiki.org/wiki/Talk:Reading/Web/Accessibility_for_reading. We will set up per-wiki links in a separate ticket.

Background

  • We would like to set up a reporting system for dark mode so that users that see issues with templates and other user-generated content, can report on these issues. We plan on using this system as a supplemental source of information for editors focused on dark mode fixes, similar to the current accessibility tool (https://night-mode-checker.wmcloud.org/)

User story

  • As a template editor, I want to see which pages users have dark mode issues, so that I can fix them

Requirements for Pt 2 (link destination and messaging)

BDD

  • For QA engineer to fill out

Test Steps

  • For QA engineer to fill out

Design

image.png (1×2 px, 172 KB)

Note: design has changed. Beta tag is now in the title of the section and not a chip next to the dark mode option.

Acceptance criteria

  • Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Weekly, we will create a dump of data received from 2 and 3 and post to each wiki. (Note: This will be later automated and will be implemented post-deploy.)

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.0.0 of the Web team task template using phabulous

Requirement

Add a link in the appearance menu for users to report issues with dark mode. This link should only appear when dark mode is enabled and lead to a pre-filled form on MediaWiki. The link should have a tooltip, be translatable, and should not appear alongside exception handling disclaimers.

Requirement

Ensure a link is available in the appearance menu for reporting dark mode issues. This link should be available to all users who can see dark mode in their appearance menu, only when dark mode is enabled. It should have a tooltip, lead to a pre-filled form, be translatable, and not appear with exception handling disclaimers. The color label should have (beta) appended to it.

BDD

Feature: Dark Mode Issue Reporting Link

  Scenario: Show reporting link when dark mode is enabled
    Given the user has enabled dark mode
    When the user opens the appearance menu in Vector22 or other desktop skins
    Then a link to report issues with dark mode should be available
    And the link should have a tooltip
    And the link should lead to a pre-filled form on MediaWiki
    And the link should not appear alongside exception handling disclaimers
    And the link should be translatable
    And the color label should have (beta) appended to it
    When the appearance menu is collapsed in the top bar
    Then clicking the link should keep the appearance menu open for logged-out users to see the "Report received" system feedback

Test Steps

Test Case 1: Verify Dark Mode Issue Reporting Link

  1. Enable dark mode.
  2. Open the appearance menu in Vector22 or other desktop skins.
  3. AC1: Confirm that a link to report issues with dark mode is available.
  4. AC2: Confirm that the link has a tooltip.
  5. Click the link.
  6. AC3: Confirm it leads to a pre-filled form on MediaWiki.
  7. AC4: Confirm that the link does not appear alongside exception handling disclaimers.
  8. AC5: Confirm that the link is translatable.
  9. AC6: Confirm that the color label has (beta) appended to it.
  10. Collapse the appearance menu in the top bar.
  11. Click the reporting link as a logged-out user.
  12. AC7: Confirm that the appearance menu stays open to show the "Report received" system feedback.

Design

image.png (1×2 px, 116 KB)

See T367795 for spec.

Open questions:

  • What does the link look like?
  • When does the link show? All the time? Only when dark mode is enabled?
  • DST is in active development on this tooltip component (T340456). How will this affect timelines/scope?

Acceptance criteria

  • The link should not show when the dark mode gadget is disabled.

Communication criteria - does this need an announcement or discussion?

  • n/a

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

Signoff criteria

  • Ensure there is a ticket to add the tooltip

This task was created by Version 1.0.0 of the Web team task template using phabulous

QA Results - PROD

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change #1052343 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Avoid using <noinclude> tag in Vector dark-mode i18n message

https://gerrit.wikimedia.org/r/1052343

thank you for the suggestion @Batorsz the HTML comment looks much simpler :)

Change #1052343 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Avoid using <noinclude> tag in Vector dark-mode i18n message

https://gerrit.wikimedia.org/r/1052343

Aklapper removed a subscriber: Batorsz.

[removing unrelated person from subscribers list]

ovasileva raised the priority of this task from Medium to High.Jul 8 2024, 10:53 AM

Will probably need additional review from @JScherer-WMF, but looks good to me! @JScherer-WMF - which copy do we want to finalize "report received" or "thank you for your report"? I'm okay with either.

Test wiki on Patch demo by JDrewniak (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/c1fef783c8/w/

Test wiki on Patch demo by JDrewniak (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/2a0143bbc0/w/

I talked to @JScherer-WMF about this earlier today and there are going to be a few modifications required. @Jdrewniak feel free to sync with Justin before he's commented if that makes sense.

Screenshot 2024-07-09 at 1.59.23 PM.png (412×572 px, 48 KB)

Bugs I found on the beta cluster today:

  1. The original design spec'd a tooltip explaining a bit more about reporting. I know we de-scoped that. Is it in the hopper as a fast-follow task.? cc @ovasileva
  2. The icon should be 12px not 14
  3. The text in the clicked state should be green, not in focus, and not styled as a link
  4. Have we tested the requirement about not being able to post multiple reports? I think we specified 1 report per page per user per session. I'm not sure how we define a "session" otherwise I'd be able to test it. But right now if you navigate away then back again, you can re-post. This was mostly an anti-spam measure. Given that we're asking people to write reports, I'm fine if we decide to forgo this requirement. cc @ovasileva

Change #1053358 had a related patch set uploaded (by Jdlrobson; author: Jdrewniak):

[mediawiki/skins/Vector@wmf/1.43.0-wmf.12] Add beta tag & feedback link to Appearance menu

https://gerrit.wikimedia.org/r/1053358

Change #1053358 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.43.0-wmf.12] Add beta tag & feedback link to Appearance menu

https://gerrit.wikimedia.org/r/1053358

Mentioned in SAL (#wikimedia-operations) [2024-07-10T20:37:14Z] <jdrewniak@deploy1002> Started scap sync-world: Backport for [[gerrit:1053036|[July 10th] Vector: enable dark mode for tier 1 wikis (logged in only) (T368795)]], [[gerrit:1053358|Add beta tag & feedback link to Appearance menu (T367871)]]

Mentioned in SAL (#wikimedia-operations) [2024-07-10T21:06:21Z] <jdrewniak@deploy1002> jdrewniak, jdlrobson: Backport for [[gerrit:1053036|[July 10th] Vector: enable dark mode for tier 1 wikis (logged in only) (T368795)]], [[gerrit:1053358|Add beta tag & feedback link to Appearance menu (T367871)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-07-10T21:09:33Z] <jdrewniak@deploy1002> Started scap sync-world: Backport for [[gerrit:1053036|[July 10th] Vector: enable dark mode for tier 1 wikis (logged in only) (T368795)]], [[gerrit:1053358|Add beta tag & feedback link to Appearance menu (T367871)]]

Mentioned in SAL (#wikimedia-operations) [2024-07-10T21:17:48Z] <jdrewniak@deploy1002> jdlrobson, jdrewniak: Backport for [[gerrit:1053036|[July 10th] Vector: enable dark mode for tier 1 wikis (logged in only) (T368795)]], [[gerrit:1053358|Add beta tag & feedback link to Appearance menu (T367871)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-07-10T21:18:27Z] <jdrewniak@deploy1002> Started scap sync-world: Backport for [[gerrit:1053036|[July 10th] Vector: enable dark mode for tier 1 wikis (logged in only) (T368795)]], [[gerrit:1053358|Add beta tag & feedback link to Appearance menu (T367871)]]

Mentioned in SAL (#wikimedia-operations) [2024-07-10T21:23:03Z] <jdrewniak@deploy1002> jdlrobson, jdrewniak: Backport for [[gerrit:1053036|[July 10th] Vector: enable dark mode for tier 1 wikis (logged in only) (T368795)]], [[gerrit:1053358|Add beta tag & feedback link to Appearance menu (T367871)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-07-10T21:30:03Z] <jdrewniak@deploy1002> Finished scap: Backport for [[gerrit:1053036|[July 10th] Vector: enable dark mode for tier 1 wikis (logged in only) (T368795)]], [[gerrit:1053358|Add beta tag & feedback link to Appearance menu (T367871)]] (duration: 11m 35s)

Remaining: size of icon and text color after click should be green

Change #1054599 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Increase specificity in dark-mode feedback link styles

https://gerrit.wikimedia.org/r/1054599

Change #1054599 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Increase specificity in dark-mode feedback link styles

https://gerrit.wikimedia.org/r/1054599

See linked bug about UX complaints.

The following requirement is not being met.

Link is only available when dark mode is enabled

Just added a new requirement to the logged out one-click reporting behaviour:

When the appearance menu is collapsed in the top bar and logged out users click the reporting link, the appearance menu should stay open so that they can see the "Report received" system feedback.

Change #1056059 had a related patch set uploaded (by Jdrewniak; author: Jdrewniak):

[mediawiki/skins/Vector@master] Dark-mode feedback link should only display in dark-mode

https://gerrit.wikimedia.org/r/1056059

☝️just fyi, the patch above has been amended to address both issues.

Change #1056059 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Dark-mode feedback link UX improvements

https://gerrit.wikimedia.org/r/1056059

Edtadros subscribed.

Test Result - Beta

Status: ❓Need More Info / ❌ FAIL
Environment: Beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Dark Mode Issue Reporting Link

  1. Enable dark mode.
  2. Open the appearance menu in Vector22 or other desktop skins.
  3. AC1: Confirm that a link to report issues with dark mode is available.

screenshot.png (999×1 px, 404 KB)

  1. AC2: Confirm that the link has a tooltip.

Logged out:

screenshot.mov.gif (884×1 px, 1 MB)

Logged in:
screenshot 2.mov.gif (884×1 px, 802 KB)
screenshot 4.mov.gif (884×1 px, 982 KB)

  1. Click the link.
  2. AC3: Confirm it leads to a pre-filled form on MediaWiki.

Is this what is meant by "form"?

screenshot 3.mov.gif (884×1 px, 830 KB)

  1. AC4: Confirm that the link does not appear alongside exception handling disclaimers.

//My understanding of this is that the reporting link won't appear next to a page that is excluded from dark mode and would have the following text "This page is always in light mode." There aren't any pages at this time in beta that are excluded so if my understanding is correct, this isn't testable in beta...

  1. AC5: Confirm that the link is translatable.

screenshot 1.png (999×1 px, 354 KB)

  1. AC6: Confirm that the color label has (beta) appended to it.

screenshot 2.png (955×1 px, 373 KB)

  1. Collapse the appearance menu in the top bar.
  2. Click the reporting link as a logged-out user.
  3. AC7: Confirm that the appearance menu stays open to show the "Report received" system feedback.

screenshot 1.mov.gif (884×1 px, 596 KB)

@Edtadros to make a new ticket for each case that isn't currently passing

Change #1057935 had a related patch set uploaded (by Kimberly Sarabia; author: Kimberly Sarabia):

[mediawiki/skins/Vector@master] Set data-event-name attribute for betaMessageEl

https://gerrit.wikimedia.org/r/1057935

New tickets have been opened: T371325 andT369849

@Jdlrobson @ovasileva For QA testing purposes in PROD, what should I now be testing from T367871#10020017 since this is part of the Verify 1.43.0-wmf.16 deployment task?

AC3 passes, AC4 should be verified in production on a page where dark mode is not available

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.6
Browser: Chrome 127
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify Dark Mode Issue Reporting Link

  1. Enable dark mode.
  2. Open the appearance menu in Vector22 or other desktop skins.
  3. AC1: Confirm that a link to report issues with dark mode is available.

2024-08-05_13-07-16.png (1×1 px, 581 KB)

  1. ⬜ AC2: Confirm that the link has a tooltip. Covered in T367871#10025368
  1. Click the link.
  2. AC3: Confirm it leads to a pre-filled form on MediaWiki.

Is this what is meant by "form"?

2024-08-05_13-09-24.mp4.gif (862×1 px, 794 KB)

  1. AC4: Confirm that the link does not appear alongside exception handling disclaimers.

https://en.wikipedia.org/wiki/Portal:Biography

2024-08-05_17-06-35.png (1×2 px, 611 KB)

  1. AC5: Confirm that the link is translatable.

2024-08-05_13-12-14.png (719×1 px, 237 KB)

  1. AC6: Confirm that the color label has (beta) appended to it.

2024-08-05_13-56-12.png (860×1 px, 377 KB)

  1. Collapse the appearance menu in the top bar.
  2. Click the reporting link as a logged-out user.
  3. AC7: Confirm that the appearance menu stays open to show the "Report received" system feedback.

2024-08-05_13-57-39.mp4.gif (678×1 px, 667 KB)

GMikesell-WMF added a project: Verified.
GMikesell-WMF updated the task description. (Show Details)