Page MenuHomePhabricator

Integrate schedule-deployment with WikimediaDebug
Open, Needs TriagePublicFeature

Description

Feature summary (what you would like to be able to do and where):
Currently, the schedule-deployment tool advises users to install WikimediaDebug ahead of time.

image.png (269×1 px, 104 KB)

It might be cool if the WikimediaDebug extension integrated with this message to tell the user that it’s already installed. (The tool could also change the phrasing of the message to something like “You still need to install the WikimediaDebug extension” and rely on the WikimediaDebug extension to hide that message.)

Benefits (why should this be implemented?):
Users wouldn’t have to check for themselves whether the extension is installed or not.

Caveats:
Users don’t necessarily schedule deployments from the same system where they’ll later test the deployment, I suppose.

Event Timeline

I believe this would need to work by adding something to the WikimediaDebug extension that changes what is rendered on the page. There are some methods for sniffing for an installed extension in Chrome that might work, but Firefox appears to have closed those same loopholes to reduce browser fingerprinting options.

I believe this would need to work by adding something to the WikimediaDebug extension that changes what is rendered on the page. There are some methods for sniffing for an installed extension in Chrome that might work, but Firefox appears to have closed those same loopholes to reduce browser fingerprinting options.

Can't extensions add CSS to pages? I have some extensions that do that. (It might require more permissions for the extension though, not sure.)
In that case, the message about adding WikimediaDebug could be given a class in the tool, and the extension could hide elements with that class.

Can't extensions add CSS to pages? I have some extensions that do that. (It might require more permissions for the extension though, not sure.)
In that case, the message about adding WikimediaDebug could be given a class in the tool, and the extension could hide elements with that class.

Yes, this is generally what I meant by "I believe this would need to work by adding something to the WikimediaDebug extension that changes what is rendered on the page."

The work that would need to be done looks something like:

  • Invent a css class to hide with WikimediaDebug injected css
  • Use that class on a <span> wrapping the reminder to install WikimediaDebug that is shown on https://schedule-deployment.toolforge.org/backport/*
  • Deploy updated version of schedule-deployment
  • Update the WikimediaDebug extension to apply to https://schedule-deployment.toolforge.org/backport/* pages and inject the needed display: none css on those pages
  • Publish the new version of WikimediaDebug to the Chrome and Firefox app stores
  • Hope that people update their installed extensions