Page MenuHomePhabricator
Create Task
Maniphest T366911

🎯 [Format/Rewrite] patch-target-not-found
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Acceptance criteria:

  • Error code: patch-target-not-found
  • New message: "Target not found on resource"
  • Context: { "path": "{json_pointer_to_target_in_patch}" } (e.g. { "path": "/patch/2/path" }, { "path": "/patch/3/from" })
  • HTTP status code: 409

Details

SubjectRepoBranchLines /-
REST: Format/rewrite patch-target-not-found errormediawiki/extensions/Wikibasemaster 93 -78
REST: Bump swaggest/json-diff to 3.11.0mediawiki/extensions/Wikibasemaster 1 -1
Bump swaggest/json-diff to 3.11.0mediawiki/vendormaster 43 -21
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ifrahkhanyaree_WMDE created this task.Jun 7 2024, 1:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 7 2024, 1:37 PM
Ollie.Shotton_WMDE updated the task description. (Show Details)Jun 19 2024, 10:53 AM
WMDE-leszek updated the task description. (Show Details)Jun 19 2024, 12:04 PM
WMDE-leszek moved this task from Backlog to Polished on the Wikibase Product Platform Team WPP board.Jun 19 2024, 12:07 PM
WMDE-leszek updated the task description. (Show Details)Jun 20 2024, 9:16 AM
WMDE-leszek set the point value for this task to 5.
Ollie.Shotton_WMDE updated the task description. (Show Details)Jun 20 2024, 9:18 AM
Ifrahkhanyaree_WMDE moved this task from Polished to Ready for planning on the Wikibase Product Platform Team WPP board.Jun 25 2024, 9:45 AM
Ifrahkhanyaree_WMDE moved this task from Ready for planning to Sprint 23 on the Wikibase Product Platform Team WPP board.Jun 25 2024, 9:51 AM
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 23); removed Wikibase Product Platform Team WPP.
Muhammad_Yasser_Jazirahly_WMDE renamed this task from [Format/Rewrite] patch-target-not-found to 🎯 [Format/Rewrite] patch-target-not-found.Jun 25 2024, 2:18 PM
Ollie.Shotton_WMDE mentioned this in T368398: [MAIN] REST API v1 CHECKLIST.Jun 26 2024, 5:13 PM
Jakob_WMDE closed subtask T368413: 🎯 Try a solution ourselves by applying one patch operation at a time as Invalid.EditedTue, Jul 2, 12:17 PM
Jakob_WMDE subscribed.

Since the upstream change was merged an published, this now requires:

Wikibase patch:

  • update the OpenAPI doc
  • bumping the version of json-diff to the latest one in composer.json
  • in repo/rest-api/src/Application/UseCases/PatchJson.php, change the UseCaseError accordingly
  • adjust e2e tests
Dima_Koushha_WMDE claimed this task.Tue, Jul 2, 12:29 PM
Dima_Koushha_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 23) board.
gerritbot added a comment.Tue, Jul 2, 1:14 PM

Change #1051356 had a related patch set uploaded (by Dima koushha; author: Dima koushha):

[mediawiki/vendor@master] Bump swaggest/json-diff to 3.11.0

https://gerrit.wikimedia.org/r/1051356

gerritbot added a project: Patch-For-Review.Tue, Jul 2, 1:14 PM
gerritbot added a comment.Tue, Jul 2, 2:36 PM

Change #1051386 had a related patch set uploaded (by Dima koushha; author: Dima koushha):

[mediawiki/extensions/Wikibase@master] REST: Bump swaggest/json-diff to 3.11.0

https://gerrit.wikimedia.org/r/1051386

gerritbot added a comment.Tue, Jul 2, 2:41 PM

Change #1051389 had a related patch set uploaded (by Dima koushha; author: Dima koushha):

[mediawiki/extensions/Wikibase@master] REST: Format/rewrite patch-target-not-found error

https://gerrit.wikimedia.org/r/1051389

gerritbot added a comment.Tue, Jul 2, 3:28 PM

Change #1051356 merged by jenkins-bot:

[mediawiki/vendor@master] Bump swaggest/json-diff to 3.11.0

https://gerrit.wikimedia.org/r/1051356

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.13; 2024-07-09).Tue, Jul 2, 4:00 PM
gerritbot added a comment.Wed, Jul 3, 9:31 AM

Change #1051386 abandoned by Dima koushha:

[mediawiki/extensions/Wikibase@master] REST: Bump swaggest/json-diff to 3.11.0

Reason:

https://gerrit.wikimedia.org/r/1051386

Dima_Koushha_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 23) board.Wed, Jul 3, 10:15 AM
gerritbot added a comment.Thu, Jul 4, 11:09 AM

Change #1051389 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Format/rewrite patch-target-not-found error

https://gerrit.wikimedia.org/r/1051389

Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 23) board.Thu, Jul 4, 12:13 PM
Dima_Koushha_WMDE removed a project: Patch-For-Review.Thu, Jul 4, 4:05 PM
Ollie.Shotton_WMDE closed this task as Resolved.Tue, Jul 9, 9:53 AM
Ollie.Shotton_WMDE closed subtask T368414: 🎯 Include the operation index in the upstream repo as Resolved.
Ifrahkhanyaree_WMDE added a parent task: T368398: [MAIN] REST API v1 CHECKLIST.Wed, Jul 17, 11:57 AM
Ifrahkhanyaree_WMDE removed a parent task: T368398: [MAIN] REST API v1 CHECKLIST.Thu, Jul 18, 9:53 AM
Ifrahkhanyaree_WMDE moved this task from Backlog to Done on the Wikibase REST API (WPP) board.Fri, Jul 26, 2:40 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits