Page MenuHomePhabricator
Create Task
Maniphest T366375

Special:QrCode and Special:UrlShortener has night mode issues
Closed, ResolvedPublic
Actions

Description

Background

Special:QrCode has color contrast issues in night theme.,

User story

As a user I want all my pages in dark mode.

Acceptance criteria

Communication criteria - does this need an announcement or discussion?

N/A

Rollback plan

N/A

This task was created by Version 1.0.0 of the Web team task template using phabulous

Details

SubjectRepoBranchLines /-
Enable user pages and select special pages in dark mode (1.43.0-wmf.11)operations/mediawiki-configmaster 0 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.May 31 2024, 4:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 31 2024, 4:17 PM
Ladsgroup subscribed.May 31 2024, 4:23 PM

"Get short url" widget is also not going to dark mode: https://test.wikipedia.org/wiki/Ruine_Thürndl?vectornightmode=1 (click on "Get shortened URL")

Jdlrobson moved this task from Backlog to Excluded experiences on the FY2023-24-WE 2.1 Typography and palette customizations board.May 31 2024, 4:46 PM
Jdlrobson triaged this task as Low priority.May 31 2024, 4:49 PM
• OKJ04 added a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:39 AM
JJMC89 removed a subtask: T366433: CentralAuth tests broken unless you run them inside Quibble.Jun 3 2024, 1:44 AM
Jdlrobson added a subtask: T364777: [EPIC] Enable dark mode in OOUI.Jun 3 2024, 10:55 PM
gerritbot added a comment.Jun 26 2024, 3:40 PM

Change #1049972 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable user pages and select special pages in dark mode (1.43.0-wmf.11)

https://gerrit.wikimedia.org/r/1049972

gerritbot added a project: Patch-For-Review.Jun 26 2024, 3:40 PM
Jdlrobson added a comment.Jun 26 2024, 3:42 PM

Looks like the updates to OOUI took care of night mode for these pages so I'll enable them tomorrow.

Jdlrobson closed subtask T364777: [EPIC] Enable dark mode in OOUI as Resolved.Jun 26 2024, 7:51 PM
gerritbot added a comment.Jun 26 2024, 8:23 PM

Change #1049972 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable user pages and select special pages in dark mode (1.43.0-wmf.11)

https://gerrit.wikimedia.org/r/1049972

Maintenance_bot removed a project: Patch-For-Review.Jun 26 2024, 8:32 PM
Stashbot mentioned this in T367581: Dark mode is not available on Special:MathStatus.Jun 26 2024, 8:42 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-26T20:42:24Z] <jdrewniak@deploy1002> Started scap: Backport for [[gerrit:1049972|Enable user pages and select special pages in dark mode (1.43.0-wmf.11) (T366364 T366375 T367375 T367581 T367582 T367583)]]

Stashbot mentioned this in T366364: Enable night theme on user pages.Jun 26 2024, 8:42 PM
Stashbot mentioned this in T367375: Search page doesn't work in dark mode.
Stashbot mentioned this in T367583: Dark mode is not available on Special:Block.
Stashbot mentioned this in T367582: Dark mode is not available on Special:GlobalRenameRequest.
Stashbot added a comment.Jun 26 2024, 8:44 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-26T20:44:55Z] <jdrewniak@deploy1002> jdlrobson, jdrewniak: Backport for [[gerrit:1049972|Enable user pages and select special pages in dark mode (1.43.0-wmf.11) (T366364 T366375 T367375 T367581 T367582 T367583)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Jun 26 2024, 8:50 PM

Mentioned in SAL (#wikimedia-operations) [2024-06-26T20:50:34Z] <jdrewniak@deploy1002> Finished scap: Backport for [[gerrit:1049972|Enable user pages and select special pages in dark mode (1.43.0-wmf.11) (T366364 T366375 T367375 T367581 T367582 T367583)]] (duration: 08m 09s)

Jdlrobson assigned this task to GMikesell-WMF.Jun 26 2024, 11:01 PM
Jdlrobson added a project: Web-Team-Backlog (FY2023-24 Q4 Sprint 6).
Jdlrobson moved this task from Needs analysis to QA on the Web-Team-Backlog (FY2023-24 Q4 Sprint 6) board.
Jdlrobson edited projects, added Web-Team-Backlog (FY2024-25 Q1 Sprint 1); removed Web-Team-Backlog (FY2023-24 Q4 Sprint 6).Jul 1 2024, 5:35 PM
Jdlrobson moved this task from Needs analysis to QA on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.
Jdlrobson moved this task from Excluded experiences to Dark mode on the FY2023-24-WE 2.1 Typography and palette customizations board.Jul 1 2024, 11:29 PM
KSarabia-WMF claimed this task.Jul 3 2024, 4:05 PM
KSarabia-WMF added a subscriber: GMikesell-WMF.
KSarabia-WMF added a comment.EditedJul 3 2024, 5:58 PM

Test Result - Prod

Status: ✅ PASS
Environment: Beta
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

Screenshot 2024-07-03 at 12.57.49 PM.png (1×1 px, 113 KB)

Test Steps
  1. Go to

https://test.wikipedia.org/wiki/Special:QrCode?vectornightmode=1
https://test.wikipedia.org/wiki/Special:UrlShortener?vectornightmode=1

  1. Run color contrast checker on
  2. Components related to Special:QrCode and Special:UrlShortener are passing, except the placeholder text in the input field.*

Notes

  1. There are other elements that do not pass on the page, but they do not appear to be related to this page’s components.
  2. The placeholder text does not pass accessibility standards. However, since the label is present, users can understand the purpose of the input field without relying solely on the placeholder text.
  3. The submit button (white text on a blue background) does not pass accessibility standards, but this issue is addressed in another ticket. (Please confirm before closing).
    Screenshot 2024-07-03 at 12.57.04 PM.png (682×678 px, 90 KB)
KSarabia-WMF reassigned this task from KSarabia-WMF to ovasileva.Jul 3 2024, 5:58 PM
KSarabia-WMF moved this task from QA to Ready for Signoff on the Web-Team-Backlog (FY2024-25 Q1 Sprint 1) board.
KSarabia-WMF subscribed.
ovasileva closed this task as Resolved.Jul 8 2024, 10:29 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits