Page MenuHomePhabricator

Roll out new heading markup to Vector legacy and Minerva skins.
Closed, ResolvedPublic

Description

NOTE: Planned deploy is week of 3rd June 2024

Background

In T363597 we rolled out markup for Timeless, Monobook, CologneBlue and Modern. As expected there were a few gadget breakages. Once we are confident these have been addressed, we can proceed to roll out for legacy Vector and Minerva skins.

Rationale:

  • Since Vector 2022 is the default skin for most wikis, and many gadgets do not run on Minerva it should be done last
  • Vector legacy is the default skin for 87 wikis, so this should give us more confidence before shipping to all skins

User story

As a reader I want to benefit from more accessible heading markup.

Requirements

  • Vector should get the new heading markup.
  • Vector 2022 should not get the new heading markup.
  • Logstash is monitored preceding the deploy
  • we address any problems with gadgets relating to this change.
  • Minerva should get the new heading markup.

QA steps

  • Test on the following wikis as an anonymous user, using the Vector legacy skin and Minerva skin for mobile:
  • en.wikiquote.org
  • ru.wikipedia.org
  • en.wikibooks.org
  1. Desktop
  2. Check the table of contents works and that headings correspond to the titles
  3. Check there are no visual problems with the heading e.g. misaligned icons/unexpected icons in strange places
  1. Mobile
  2. Using mobile skin scroll to any section heading
  3. Inspect section for any unusual visual differences from normal. For example: do icons look misaligned or out of place; does the section look different from normal.
  4. Check the section can be exanded/collapsed
  5. Check any buttons in the heading can be clicked.
  6. Confirm there are no JS errors in console when clicked.

Rollback plan

  • We should aim to resolve gadgets rather than rolling back whereever possible.
  • In the unexpected event that article content is failing to render for anonymous users, we can consider reverting the patch for Vector or Minerva.

Sign off steps

  • Create a task for rolling out the change on Vector 2022 skin > T367601

This task was created by Version 1.0.0 of the Web team task template using phabulous

QA Results - PROD

ACStatusDetails
1T365736#9894187

Event Timeline

Jdlrobson triaged this task as Medium priority.
Jdlrobson raised the priority of this task from Medium to High.
Jdlrobson updated the task description. (Show Details)

Change #1022356 had a related patch set uploaded (by Jdlrobson; author: Bartosz Dziewoński):

[mediawiki/skins/MinervaNeue@master] Indicate support for new heading HTML

https://gerrit.wikimedia.org/r/1022356

Change #1022361 had a related patch set uploaded (by Jdlrobson; author: Bartosz Dziewoński):

[mediawiki/skins/Vector@master] Vector: Indicate support for new heading HTML

https://gerrit.wikimedia.org/r/1022361

Change #1035482 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] [Vector 2022] Indicate support for new heading HTML

https://gerrit.wikimedia.org/r/1035482

For Tech News

  1. Timing: Please confirm if this is still going out in next week's train? (per task Description)
  2. Content: I believe we just need to repeat/adapt the prior mention from https://meta.wikimedia.org/wiki/Tech/News/2024/21 - Please confirm if this (adapted) draft is accurate? (or fix!)

The HTML used to render all headings is being changed to improve accessibility. It will change this week in some skins (Vector legacy and Minerva). Please test gadgets on your wiki on these skins and report any related problems so that they can be resolved before this change is made in Vector-2022. The developers are still considering the introduction of a Gadget API for adding buttons to section titles if that would be helpful to tool creators, and would appreciate any input you have on that.

E.g. Perhaps we can add an expected timing note for Vector-2022? (I.e. Changing that sentence to something like "[...] before this change is made in Vector-2022 in a few weeks.")
Thanks!

Timing: Please confirm if this is still going out in next week's train? (per task Description)

It might be the train after - it depends on how code review for table of contents goes (T358452) - I hadn't realized this was a blocker.

Change #1022361 merged by jenkins-bot:

[mediawiki/skins/Vector@master] [Vector legacy] Indicate support for new heading HTML

https://gerrit.wikimedia.org/r/1022361

It looks like this was actually merged already and could've been announced last week.
Shall we still include an entry in next week's Tech News?
If yes, is the draft above accurate? Thanks.

Yes please. It rolled out to Vector 2010 today!

I think this broke the WDQS example list, which has gnarly JS to extract titles from headers as linked in the above issue. (A patch now exists for this.)

Change #1022356 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Indicate support for new heading HTML

https://gerrit.wikimedia.org/r/1022356

On Thursday this will be out on Minerva, so I'm keeping this open until then. I also need to create the follow up task for Vector 2022.

@matmarex I got a report of headings with links and non-links looking odd:
for example:
https://en.m.wikipedia.org/wiki/Wikipedia_talk:WikiProject_Film#Writing_credits_in_the_lead_intro_of_A_Quiet_Place

Screenshot 2024-06-13 at 2.32.37 PM.png (344×639 px, 75 KB)

I'll open a bug but wanted to give you a heads up.

Apparently a bug was already filed: T367468

@Jdlrobson is this QA testable in PROD? I'm just wondering since I only know how to get an anonymous user by editing which we can't do in PROD. If there is another way, please let me know.

Yes testable in production - any user will do. There should be no need to edit as part of the QA steps! You only need to click the edit button!

@Jdlrobson @Edtadros I did come across a minor issue but I'm not sure if you want it part of this task or not. Can you please review the NMI section below and let me know how to proceed thanks!

Test Result - PROD

Status: ❓NMI
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 126
Device: MBA
Emulated Device: NA

Test Artifact(s):

✅AC1: Test on the following wikis as a user, using the Vector legacy skin and Minerva skin for mobile:
en.wikiquote.org (ex. https://en.wikiquote.org/wiki/Avengers:_Endgame)
ru.wikipedia.org (ex. https://ru.wikipedia.org/wiki/Конвенция_о_биологическом_оружии)
en.wikibooks.org (ex. https://en.wikibooks.org/wiki/Muggles'_Guide_to_Harry_Potter/Books/Philosopher's_Stone)

DesktopMobile
2024-06-14_11-02-59.png (1×3 px, 1016 KB)
image.png (1×3 px, 753 KB)
2024-06-14_11-09-14.png (1×3 px, 489 KB)
2024-06-14_11-24-32 (3).gif (655×511 px, 2 MB)
2024-06-14_11-17-27 (5).gif (582×456 px, 3 MB)
2024-06-14_11-15-28 (2).gif (684×556 px, 2 MB)

❓NMI- I'm not sure if you want this even part of this task or not but in view history, they are overlapping in Wikibooks mobile as seen in the screenshot

2024-06-14_11-20-13.png (916×2 px, 180 KB)

Jdlrobson updated the task description. (Show Details)

❓NMI- I'm not sure if you want this even part of this task or not but in view history, they are overlapping in Wikibooks mobile as seen in the screenshot

Not related to this change. I think this is captured elsewhere.
This can now be resolved with T367601 as the next step.