Page MenuHomePhabricator

Reference preview preference is defined inside Popups not Cite
Closed, ResolvedPublicBUG REPORT

Description

Background

This is follow up work to T366419 and T362332. The current state of code does not clearly separate the reference preview code from page previews, meaning changes in page preview can impact the issue. These should be decoupled.

User story

As a member of the web team I want to feel safe making changes to my codebase without impacting another team's feature.

Requirements

BDD

  • For QA engineer to fill out

Test Steps

  • For QA engineer to fill out

Design

  • Add mockups and design requirements

Acceptance criteria

  • Add acceptance criteria

Communication criteria - does this need an announcement or discussion?

  • Add communication criteria

Rollback plan

  • What is the rollback plan in production for this task if something goes wrong?

This task was created by Version 1.0.0 of the Web team task template using phabulous

Event Timeline

Change #1037192 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Popups@master] Reference preview preferences should be defined inside Cite

https://gerrit.wikimedia.org/r/1037192

Is it possible to get another review on this @awight ? Thanks in advance!

Change #1037192 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Clean up preferences code

https://gerrit.wikimedia.org/r/1037192

Thanks! Leaving open in case you want to run QA, otherwise please feel free to resolve!

WMDE-Fisch subscribed.

Ran a last round of test but it seems all fine.