Page MenuHomePhabricator

Release dark mode as a beta feature on desktop (May 15th)
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

This ticket will track the release of dark mode as a beta feature on desktop across wikis.

User story

  • As a logged-in user, I want the ability to opt into dark mode as a beta feature, so that I can quickly benefit from the feature and test the new feature before wider release

Requirements

  • All subtasks are resolved and their code is in production
  • Dark mode must be packaged with the current "Accessibility for reading" beta feature, which enables the appearance menu and its functionality
  • Upon deployment, the dark mode option will be made available in the appearance menu
  • Selecting dark mode will switch the interface to dark mode
  • The default setting for the dark mode option will be "light"
  • Note: We released with a default of "automatic". After reviewing the difficulty and disturbance to change the initial default, we decided to keep the default as "automatic"

BDD

Feature: Release Dark Mode as a Beta Feature on Desktop

  Scenario: Dark mode option available in appearance menu
    Given the user is logged into Wikipedia
    And the "Accessibility for reading" beta feature is enabled
    When the user accesses the appearance menu
    Then the dark mode option should be available

  Scenario: Switching to dark mode
    Given the user is logged into Wikipedia
    And the dark mode option is available in the appearance menu
    When the user selects the dark mode option
    Then the interface should switch to dark mode

  Scenario: Default setting is Automatic
    Given the user is logged into Wikipedia
    When the user accesses the appearance menu
    Then the default setting for the dark mode option should be "Automatic"

Test Steps

Test Case 1: Dark Mode Option Available in Appearance Menu

  1. Log in to Wikipedia.
  2. Ensure the "Accessibility for reading" beta feature is enabled.
  3. Access the appearance menu.
  4. AC1: Confirm that the dark mode option is available.

Test Case 2: Switching to Dark Mode

  1. Log in to Wikipedia.
  2. Ensure the dark mode option is available in the appearance menu.
  3. Select the dark mode option.
  4. AC2: Confirm that the interface switches to dark mode.

Test Case 3: Default Setting is Automatic

  1. Log in to Wikipedia.
  2. Access the appearance menu.
  3. AC3: Confirm that the default setting for the dark mode option is "Automatic."

Design

  • see subtasks

Acceptance criteria

  • Ensure all requirements are complete
  • Check with @ovasileva and @sgrabarczuk before deployment
  • Keep track of tasks that are not in the train, and check with Olga if any of those need fixing.
  • Backport fixes earlier in the week where possible.

Communication criteria - does this need an announcement or discussion?

  • An cross-wiki announcement of the deployment must be prepared ahead of deployment and ready to post

QA Results - Beta

ACStatusDetails
1T363814#9802534
2T363814#9802534
3This requirement has changed per T363814#9802881 and T363814#9806671, this shows a fail in the test comment, but it is a pass.

QA Results - PROD

ACStatusDetails
1T363814#9832643
2T363814#9832643
3T363814#9832643

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
ovasileva renamed this task from Release dark mode as a beta feature on desktop to Release dark mode as a beta feature on desktop (May 13th) .Apr 30 2024, 5:52 PM
ovasileva renamed this task from Release dark mode as a beta feature on desktop (May 13th) to Release dark mode as a beta feature on desktop (May 15th) .May 13 2024, 5:34 PM

Change #1031495 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable night mode on Vector on testwiki

https://gerrit.wikimedia.org/r/1031495

Change #1031495 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable night mode on Vector on testwiki, disable on Special:Homepage

https://gerrit.wikimedia.org/r/1031495

Mentioned in SAL (#wikimedia-operations) [2024-05-14T20:05:54Z] <cjming@deploy1002> Started scap: Backport for [[gerrit:1031495|Enable night mode on Vector on testwiki, disable on Special:Homepage (T357699 T363814)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-14T20:08:34Z] <cjming@deploy1002> jdlrobson and cjming: Backport for [[gerrit:1031495|Enable night mode on Vector on testwiki, disable on Special:Homepage (T357699 T363814)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-14T20:24:34Z] <cjming@deploy1002> Finished scap: Backport for [[gerrit:1031495|Enable night mode on Vector on testwiki, disable on Special:Homepage (T357699 T363814)]] (duration: 18m 40s)

Change #1031560 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Mark night mode as a valid beta feature

https://gerrit.wikimedia.org/r/1031560

Change #1031478 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.43.0-wmf.4] Mark night mode as a valid beta feature

https://gerrit.wikimedia.org/r/1031478

Change #1031479 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@wmf/1.43.0-wmf.5] Mark night mode as a valid beta feature

https://gerrit.wikimedia.org/r/1031479

Change #1031561 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable night mode as a desktop beta feature

https://gerrit.wikimedia.org/r/1031561

Jdlrobson added subscribers: Jdrewniak, Jdlrobson.

If all goes to plan:

  • @Jdrewniak will deploy the last 3 blockers in the early backport window tomorrow at 6am PST
  • I will enable the config flag at 1pm PST.

Change #1031560 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Mark night mode as a valid beta feature

https://gerrit.wikimedia.org/r/1031560

Change #1031479 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.43.0-wmf.5] Mark night mode as a valid beta feature

https://gerrit.wikimedia.org/r/1031479

Change #1031478 merged by jenkins-bot:

[mediawiki/skins/Vector@wmf/1.43.0-wmf.4] Mark night mode as a valid beta feature

https://gerrit.wikimedia.org/r/1031478

Mentioned in SAL (#wikimedia-operations) [2024-05-15T14:48:27Z] <jsn@deploy1002> Started scap: Backport for [[gerrit:1031477|[Follow-up] Override VE overlays in night-mode (T363861)]], [[gerrit:1031479|Mark night mode as a valid beta feature (T363814)]], [[gerrit:1031478|Mark night mode as a valid beta feature (T363814)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-15T14:51:08Z] <jsn@deploy1002> jsn and jdlrobson: Backport for [[gerrit:1031477|[Follow-up] Override VE overlays in night-mode (T363861)]], [[gerrit:1031479|Mark night mode as a valid beta feature (T363814)]], [[gerrit:1031478|Mark night mode as a valid beta feature (T363814)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-15T15:06:54Z] <jsn@deploy1002> Finished scap: Backport for [[gerrit:1031477|[Follow-up] Override VE overlays in night-mode (T363861)]], [[gerrit:1031479|Mark night mode as a valid beta feature (T363814)]], [[gerrit:1031478|Mark night mode as a valid beta feature (T363814)]] (duration: 18m 26s)

Change #1031561 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable night mode as a desktop beta feature

https://gerrit.wikimedia.org/r/1031561

Mentioned in SAL (#wikimedia-operations) [2024-05-15T20:30:37Z] <samtar@deploy1002> Started scap: Backport for [[gerrit:1031561|Enable night mode as a desktop beta feature (T363814)]], [[gerrit:1031817|[enwiki] Throttle exemption for Editathon (T364708)]]

Mentioned in SAL (#wikimedia-operations) [2024-05-15T20:33:15Z] <samtar@deploy1002> samtar and superpes and jdlrobson: Backport for [[gerrit:1031561|Enable night mode as a desktop beta feature (T363814)]], [[gerrit:1031817|[enwiki] Throttle exemption for Editathon (T364708)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-05-15T20:48:13Z] <samtar@deploy1002> Finished scap: Backport for [[gerrit:1031561|Enable night mode as a desktop beta feature (T363814)]], [[gerrit:1031817|[enwiki] Throttle exemption for Editathon (T364708)]] (duration: 17m 35s)

Edtadros subscribed.

Test Result - Beta

Status: ❌ FAIL
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Dark Mode Option Available in Appearance Menu

  1. Log in to Wikipedia.
  2. Ensure the "Accessibility for reading" beta feature is enabled.
  3. Access the appearance menu.
  4. AC1: Confirm that the dark mode option is available.

screenshot 345.png (1×1 px, 381 KB)

Test Case 2: Switching to Dark Mode

  1. Log in to Wikipedia.
  2. Ensure the dark mode option is available in the appearance menu.
  3. Select the dark mode option.
  4. AC2: Confirm that the interface switches to dark mode.

screenshot 73.mov.gif (1×1 px, 854 KB)

Test Case 3: Default Setting is Light Mode

  1. Log in to Wikipedia.
  2. Access the appearance menu.
  3. AC3: Confirm that the default setting for the dark mode option is "light."

I tried a few beta users that I have not ever used with the appearance menu. It looks like the default is "Automatic"

screenshot 74.mov.gif (1×1 px, 1 MB)
screenshot 75.mov.gif (1×1 px, 2 MB)

The default setting for the dark mode option will be "light"

This is my bad. I thought we agreed to make "automatic" the default as the more eyes on this the better. We can talk about this in task sync tomorrow and adjust if needed.

Olga: if we want to change the default let's do this in a new ticket.

Change #1032578 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Reflect production defaults

https://gerrit.wikimedia.org/r/1032578

Change #1032578 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Reflect production defaults

https://gerrit.wikimedia.org/r/1032578

ovasileva updated the task description. (Show Details)
ovasileva updated the task description. (Show Details)

All done. Resolving

AC3 in the [[ T363814#9802534 | beta test results ]]is now a pass per T363814#9802881 and T363814#9806671

@Edtadros is there something I'm doing wrong here in AC3? Cookies have been deleted and this is a new user I created in test.wiki.
AC3 is fine. It is now updated

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 125
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Dark Mode Option Available in Appearance Menu

  1. Log in to Wikipedia.
  2. Ensure the "Accessibility for reading" beta feature is enabled.
  3. Access the appearance menu.
  4. AC1: Confirm that the dark mode option is available.

Test link: https://en.wikipedia.org/wiki/Lightsaber

2024-05-22_12-44-38.png (1×2 px, 572 KB)

Test Case 2: Switching to Dark Mode

  1. Log in to Wikipedia.
  2. Ensure the dark mode option is available in the appearance menu.
  3. Select the dark mode option.
  4. AC2: Confirm that the interface switches to dark mode.

2024-05-22_12-47-06 (1).gif (1×1 px, 3 MB)

Test Case 3: Default Setting is Light Mode

  1. Log in to Wikipedia.
  2. Access the appearance menu.

3.✅ AC3: Confirm that the default setting for the dark mode option is "Automatic"

2024-05-23_10-41-25 (1).gif (1×3 px, 2 MB)