Page MenuHomePhabricator
Create Task
Maniphest T363135

Popup on "Message participants" hidden behind participants container
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Be an event organizer without having an e-mail address registered in your settings
  • Create an event
  • Have one account register for the event
  • Go to the event details page
  • Press the "Participants" tab
  • Click the "Message participants" button

What happens?:

  • A popup appears just below the button, with the text "To message participants, you'll need an email address on your account. Add email."
  • However, this popup is hidden behind the participants list, when it should appear in front of it (see screenshot)

Screenshot_20240423_095445.png (252×919 px, 19 KB)

What should have happened instead?:

  • The popup should appear in front of the participants list, so that it's actually visible.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):
MediaWiki 1.43.0-alpha (8d2b3ad), CampaignEvents 333fec4

Other information (browser name/version, screenshots, etc.):
Tested in Firefox 124.0 and Chrome 122.0.6261.128

Details

SubjectRepoBranchLines /-
SpecialEventDetails: fix z-index of "message participants" popupmediawiki/extensions/CampaignEventsmaster 13 -3
Customize query in gerrit

Related Objects

Event Timeline

jhsoby created this task.Apr 23 2024, 7:57 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2024, 7:57 AM
jhsoby added a comment.Apr 23 2024, 8:02 AM

This happens because the selector .ext-campaignevents-details-participants-container .ext-campaignevents-details-participants-table .ext-campaignevents-details-participants-table-header th has position:sticky; z-index: 100;.

Giving .ext-campaignevents-details-participants-header the CSS position: relative; z-index: 101; (or another number > 100) would solve the issue.

Daimona claimed this task.Apr 23 2024, 5:58 PM
Daimona subscribed.

Indeed, I can confirm this. I remember fixing this exact bug a while ago while implementing the feature; according to a git bisect, this regressed in r969808.

gerritbot added a comment.Apr 23 2024, 6:18 PM

Change #1023479 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] SpecialEventDetails: fix z-index of "message participants" popup

https://gerrit.wikimedia.org/r/1023479

gerritbot added a project: Patch-For-Review.Apr 23 2024, 6:18 PM
Daimona added a project: Campaign-Tools (Campaign-Tools-Current-Sprint).Apr 23 2024, 6:18 PM
Daimona moved this task from Upcoming / refining 💡 to Code Review 💬 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.
gerritbot added a comment.Apr 24 2024, 8:04 AM

Change #1023479 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] SpecialEventDetails: fix z-index of "message participants" popup

https://gerrit.wikimedia.org/r/1023479

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.3; 2024-04-30).Apr 24 2024, 9:00 AM
Daimona moved this task from Code Review 💬 to QA 🐛 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.Apr 24 2024, 11:47 AM
Daimona mentioned this in T363573: Maintenance_bot not removing patch-for-review when all conditions are seemingly met.Apr 26 2024, 12:47 PM
vaughnwalters closed this task as Resolved.Apr 26 2024, 5:08 PM
vaughnwalters moved this task from QA 🐛 to Done 🏁 on the Campaign-Tools (Campaign-Tools-Current-Sprint) board.
vaughnwalters subscribed.

✅ The popup appears in front of the participants list

message all participants message participants
Screenshot 2024-04-26 at 12.06.30 PM.png (1×2 px, 295 KB)
Screenshot 2024-04-26 at 12.07.02 PM.png (1×2 px, 315 KB)

Tested in betacluster. This is fixed and will go out with the train next week. Marking as done / resolved.

vaughnwalters removed a project: Patch-For-Review.Apr 26 2024, 5:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits