🗑️Design the frontend for the Delete wikibase card
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Rosalie_WMDE
	Apr 16 2024, 7:18 AM

Description

see figma: https://www.figma.com/file/PwtgjVckmJbSgme6eRhMQg/Wikibase-Cloud?node-id=2097:1776&mode=dev

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Rosalie_WMDE	T347865 🗑️Ask for feedback before deleting a WB instance to ask "why"
		Resolved		Rosalie_WMDE	T362609 🗑️Design the frontend for the Delete wikibase card

Event Timeline

Rosalie_WMDE created this task.Apr 16 2024, 7:18 AM

Rosalie_WMDE moved this task from To do to In Review on the Wikibase Cloud (Kanban board Q1 2024) board.Apr 16 2024, 7:57 AM

Pull Request: https://github.com/wbstack/ui/pull/801

@Charlie_WMDE please have a look at the PR

Hey @Rosalie_WMDE ! Looks great to me! I found three small spacing issues:

The spacing between the card text and the beginning of the checkboxes is currently too large. It should be 16px
The spacing between the last checkbox and the label of the text field is too large. Should be 8px.
The spacing between the text field and the buttons below is too large. Should be 8px.

Please check the figma specs for details and let me know if you have any questions. Thanks!

conny-kawohl_WMDE edited projects, added Wikibase Cloud (Kanban Board Q2 2024); removed Wikibase Cloud (Kanban board Q1 2024).Apr 17 2024, 1:50 PM

conny-kawohl_WMDE moved this task from To do to In Review on the Wikibase Cloud (Kanban Board Q2 2024) board.Apr 17 2024, 1:50 PM

Rosalie_WMDE moved this task from In Review to Doing on the Wikibase Cloud (Kanban Board Q2 2024) board.Apr 22 2024, 7:19 AM

Thank you Spacing is fixed

Is this ready for an engineer to look at now or are you two still getting the design correct?

My understanding from yesterday's daily is that it's waiting for an engineering review. at least i don't have it on my todo so please correct me if i should be looking at something @Rosalie_WMDE

Rosalie_WMDE moved this task from In Review to Doing on the Wikibase Cloud (Kanban Board Q2 2024) board.Apr 25 2024, 11:25 AM

This is ready for engineering review

Rosalie_WMDE moved this task from Doing to In Review on the Wikibase Cloud (Kanban Board Q2 2024) board.Apr 25 2024, 11:48 AM

Deniz_WMDE updated Other Assignee, added: Deniz_WMDE.Apr 26 2024, 8:06 AM

Fring updated Other Assignee, added: Tarrow; removed: Deniz_WMDE.May 8 2024, 9:35 AM

I'm off tomorrow; happy to look again on Monday but feel free to have someone else take a look on Friday

Rosalie_WMDE moved this task from In Review to Waiting for Deploy to Staging on the Wikibase Cloud (Kanban Board Q2 2024) board.May 13 2024, 8:29 AM

Rosalie_WMDE changed the task status from Open to Stalled.May 13 2024, 12:14 PM

Anton.Kokh mentioned this in T365967: Show something friendly on wikibase.cloud sites after deletion.May 27 2024, 8:53 AM

Anton.Kokh renamed this task from Design the frontend for the Delete wikibase card to 🗑️Design the frontend for the Delete wikibase card.May 29 2024, 11:54 AM

Anton.Kokh triaged this task as Medium priority.

Anton.Kokh added a project: PM Review before Production.Jun 19 2024, 12:15 PM

Anton.Kokh edited projects, added Wikibase Cloud (Kanban Board Q3 2024); removed Wikibase Cloud (Kanban Board Q2 2024).Jul 1 2024, 7:28 AM

Anton.Kokh moved this task from To do to Waiting for Deploy to Production on the Wikibase Cloud (Kanban Board Q3 2024) board.

Anton.Kokh moved this task from Waiting for Deploy to Production to Waiting for Deploy to Staging on the Wikibase Cloud (Kanban Board Q3 2024) board.