User-provided mapstyle is not forwarded to the dynamic map
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

None

Authored By

	thiemowmde
	Apr 15 2024, 1:10 PM

Description

mapstyle="osm" is an option that always was available, but apparently only works on wikis with static maps. The dynamic map we show as part of preview ignores this attribute.

Reported here: https://www.mediawiki.org/wiki/Topic:Y2y6ee1cw7ntixfj

Details

	Subject	Repo	Branch	Lines /-
	Fix incomplete forwarding of mapstyle="osm" attribute	mediawiki/extensions/Kartographer	master	1 -0

Customize query in gerrit

Event Timeline

thiemowmde created this task.Apr 15 2024, 1:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 15 2024, 1:10 PM

Change #1019764 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Fix incomplete forwarding of mapstyle="osm" attribute

https://gerrit.wikimedia.org/r/1019764

gerritbot added a project: Patch-For-Review.Apr 15 2024, 1:13 PM

thiemowmde updated the task description. (Show Details)Apr 15 2024, 1:16 PM

awight added projects: WMDE-TechWish-Sprint-2024-04-12, Unplanned-Sprint-Work.Apr 15 2024, 1:24 PM

awight moved this task from Sprint Backlog to Watching / Epic / Stalled on the WMDE-TechWish-Sprint-2024-04-12 board.Apr 16 2024, 7:23 AM

Change #1019764 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Fix incomplete forwarding of mapstyle="osm" attribute

https://gerrit.wikimedia.org/r/1019764

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.2; 2024-04-23).Apr 16 2024, 9:00 AM

Hmm this attribute was also not documented. https://www.mediawiki.org/w/index.php?title=Help:Extension:Kartographer&diff=prev&oldid=6471835

thiemowmde moved this task from Watching / Epic / Stalled to Demo on the WMDE-TechWish-Sprint-2024-04-12 board.Apr 17 2024, 11:01 AM

Suggestion for TechNews:

Kartographer maps can use an alternative mapstyle=osm without labels. This wasn't working in previews, creating the wrong impression it wouldn't be supported.

WMDE-Fisch closed this task as Resolved.Apr 24 2024, 5:10 PM

WMDE-Fisch claimed this task.

Quiddity moved this task from To Triage to In current Tech/News draft on the User-notice board.Apr 25 2024, 10:26 PM

Quiddity awarded a token.

WMDE-Fisch removed WMDE-Fisch as the assignee of this task.Apr 26 2024, 10:26 AM

WMDE-Fisch removed a project: Patch-For-Review.

Trizek-WMF moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.May 2 2024, 2:07 PM

Maintenance_bot edited projects, added User-notice-archive; removed User-notice.May 12 2024, 2:31 PM