Page MenuHomePhabricator

CkeckUser and/or WikimediaEvents block CI for unrelated codebases
Closed, DuplicatePublicBUG REPORT

Description

A failing CheckUser tests currently blocks patches in several codebases:

HTTP request blocked: /feed/v1/ip/127.0.0.1 by NullHttpRequestFactory::create. Use MockHttpTrait.

Example stacktrace:

14:29:47 1) CentralAuthCreateLocalTest::testWithNonAttachedUser
14:29:47 HTTP request blocked: /feed/v1/ip/127.0.0.1 by NullHttpRequestFactory::create. Use MockHttpTrait.
14:29:47 
14:29:47 /workspace/src/tests/phpunit/mocks/NullHttpRequestFactory.php:46
14:29:47 /workspace/src/extensions/WikimediaEvents/includes/IPReputationHooks.php:106
14:29:47 /workspace/src/includes/libs/objectcache/wancache/WANObjectCache.php:1726
14:29:47 /workspace/src/includes/libs/objectcache/wancache/WANObjectCache.php:1556
14:29:47 /workspace/src/extensions/WikimediaEvents/includes/IPReputationHooks.php:149
14:29:47 /workspace/src/extensions/WikimediaEvents/includes/IPReputationHooks.php:229
14:29:47 /workspace/src/extensions/WikimediaEvents/includes/IPReputationHooks.php:215
14:29:47 /workspace/src/includes/deferred/MWCallableUpdate.php:42
14:29:47 /workspace/src/includes/deferred/DeferredUpdates.php:486
14:29:47 /workspace/src/includes/deferred/DeferredUpdates.php:198
14:29:47 /workspace/src/includes/deferred/DeferredUpdates.php:285
14:29:47 /workspace/src/includes/deferred/DeferredUpdatesScope.php:269
14:29:47 /workspace/src/includes/deferred/DeferredUpdatesScope.php:198
14:29:47 /workspace/src/includes/deferred/DeferredUpdates.php:304
14:29:47 /workspace/src/includes/deferred/DeferredUpdates.php:368
14:29:47 /workspace/src/includes/deferred/DeferredUpdates.php:162
14:29:47 /workspace/src/includes/deferred/DeferredUpdates.php:176
14:29:47 /workspace/src/extensions/WikimediaEvents/includes/IPReputationHooks.php:216
14:29:47 /workspace/src/includes/HookContainer/HookContainer.php:159
14:29:47 /workspace/src/includes/HookContainer/HookRunner.php:2400
14:29:47 /workspace/src/includes/auth/AuthManager.php:1966
14:29:47 /workspace/src/extensions/CentralAuth/includes/CentralAuthUtilityService.php:179
14:29:47 /workspace/src/extensions/CentralAuth/includes/User/CentralAuthForcedLocalCreationService.php:93
14:29:47 /workspace/src/extensions/CentralAuth/includes/Special/SpecialCreateLocalAccount.php:89
14:29:47 /workspace/src/extensions/CentralAuth/tests/phpunit/CentralAuthCreateLocalTest.php:122

I checked the git histories and can't find anything suspicious in the CheckUser codebase. I suspect it's a recent change either in WikimediaEvents or core.