127.0.0.1 by NullHttpRequestFactory::create. Use MockHttpTrait.
Closed, ResolvedPublic
Actions

Description

CheckUser extension CI is blocked with the following error:

13:29:47 4) MediaWiki\CheckUser\Tests\Integration\Maintenance\PopulateCheckUserTablesWithSimulatedDataTest::testCreateRegisteredUser with data set "Username provided" ('408c3e59ae7fa52bf0cc9a73f52f3b86')
13:29:47 HTTP request blocked: /feed/v1/ip/127.0.0.1 by NullHttpRequestFactory::create. Use MockHttpTrait.
13:29:47 
13:29:47 /workspace/src/tests/phpunit/mocks/NullHttpRequestFactory.php:46
13:29:47 /workspace/src/extensions/WikimediaEvents/includes/IPReputationHooks.php:106
13:29:47 /workspace/src/includes/libs/objectcache/wancache/WANObjectCache.php:1726
13:29:47 /workspace/src/includes/libs/objectcache/wancache/WANObjectCache.php:1556
13:29:47 /workspace/src/extensions/WikimediaEvents/includes/IPReputationHooks.php:149
13:29:47 /workspace/src/extensions/WikimediaEvents/includes/IPReputationHooks.php:229
13:29:47 /workspace/src/extensions/WikimediaEvents/includes/IPReputationHooks.php:215
13:29:47 /workspace/src/includes/deferred/MWCallableUpdate.php:42
13:29:47 /workspace/src/includes/deferred/DeferredUpdates.php:486
13:29:47 /workspace/src/includes/deferred/DeferredUpdates.php:198
13:29:47 /workspace/src/includes/deferred/DeferredUpdates.php:285
13:29:47 /workspace/src/includes/deferred/DeferredUpdatesScope.php:269
13:29:47 /workspace/src/includes/deferred/DeferredUpdatesScope.php:198
13:29:47 /workspace/src/includes/deferred/DeferredUpdates.php:304
13:29:47 /workspace/src/includes/deferred/DeferredUpdates.php:368
13:29:47 /workspace/src/includes/deferred/DeferredUpdates.php:162
13:29:47 /workspace/src/includes/deferred/DeferredUpdates.php:176
13:29:47 /workspace/src/extensions/WikimediaEvents/includes/IPReputationHooks.php:216
13:29:47 /workspace/src/includes/HookContainer/HookContainer.php:159
13:29:47 /workspace/src/includes/HookContainer/HookRunner.php:2400
13:29:47 /workspace/src/includes/auth/AuthManager.php:1966
13:29:47 /workspace/src/extensions/CheckUser/maintenance/populateCheckUserTablesWithSimulatedData.php:335
13:29:47 /workspace/src/vendor/wikimedia/testing-access-wrapper/src/TestingAccessWrapper.php:114
13:29:47 /workspace/src/extensions/CheckUser/tests/phpunit/integration/maintenance/P

Seems to be caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaEvents/ /1013723/11 et. al.

Example failure is at https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium/928/consoleFull

Details

	Subject	Repo	Branch	Lines /-
	Check for ipoid base url in all hooks	mediawiki/extensions/WikimediaEvents	master	13 -13

Customize query in gerrit

Related Objects

Duplicates Merged Here: T362383: CkeckUser and/or WikimediaEvents block CI for unrelated codebases

Event Timeline

Dreamy_Jazz created this task.Apr 11 2024, 12:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 11 2024, 12:32 PM

Dreamy_Jazz added projects: CheckUser, MediaWiki-extensions-WikimediaEvents.Apr 11 2024, 12:32 PM

Dreamy_Jazz updated the task description. (Show Details)Apr 11 2024, 12:44 PM

Looks to be caused by:

PopulateCheckUserTablesWithSimulatedDataTest calls createRegisteredUser to test it
That method generates a registered username and causes an autocreation for that username
That causes IPReputationHooks::onLocalUserCreated to be called
That tries to make a request to the IPoid service (which does not exist in CI)
That request fails because the request was tried using a NullHttpRequestFactory.